Re: [PATCH] cksum: improve problematic_chars function

2023-07-14 Thread Jim Meyering
On Fri, Jul 14, 2023 at 3:27 AM Pádraig Brady wrote: > On 14/07/2023 07:54, Jim Meyering wrote: > > Small suggested improvement: > > Looks good thanks. > Testing with the attached shows a 23% improvement on average > with using strcspn() over strchr()x3. Thanks for checking. Pushed.

Re: [PATCH] cksum: improve problematic_chars function

2023-07-14 Thread Pádraig Brady
On 14/07/2023 07:54, Jim Meyering wrote: Small suggested improvement: Looks good thanks. Testing with the attached shows a 23% improvement on average with using strcspn() over strchr()x3. thanks, Pádraig.#include #include #include #include __attribute__ ((__pure__)) static bool problemati

[PATCH] cksum: improve problematic_chars function

2023-07-13 Thread Jim Meyering
Small suggested improvement: >From c0e7e4a1d41049bbf38cf902d13746b1ab5b1e38 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 13 Jul 2023 22:29:52 -0700 Subject: [PATCH] cksum: improve problematic_chars function * src/digest.c (problematic_chars): Implement using strcspn, and traversin