[coreboot] Re: How to best handle new Intel Saphire Rapids server boards based on Intel Archer City?

2023-06-19 Thread Angel Pons
Hi Paul, list, On Thu, Jun 8, 2023, 16:16 Paul Menzel wrote: > [Annie, Yiwei, I only added you to Cc. It’d be great if you made sure > that all involved people are subscribed to the coreboot mailing list.] > > Dear coreboot folks, > > > Two server boards based on Intel Archer City board, commit

[coreboot] Re: How to best handle new Intel Saphire Rapids server boards based on Intel Archer City?

2023-06-19 Thread Martin Roth via coreboot
Duplicated code between mainboards isn't a big issue in my opinion. It allows the boards to be customized without worrying about other companies' mainboards. We've tried to make mainboards as small as we can, and we can keep refactoring things out where it makes sense. If some common code fits

[coreboot] Re: How to best handle new Intel Saphire Rapids server boards based on Intel Archer City?

2023-06-19 Thread Paul Menzel
Dear Martin, Thank you very much for taking the time to answer. Am 19.06.23 um 22:31 schrieb Martin Roth: Duplicated code between mainboards isn't a big issue in my opinion. It allows the boards to be customized without worrying about other companies' mainboards. We've tried to make mainboard

[coreboot] Re: How to best handle new Intel Saphire Rapids server boards based on Intel Archer City?

2023-06-19 Thread Nico Huber
On 19.06.23 23:01, Paul Menzel wrote: > Am 19.06.23 um 22:31 schrieb Martin Roth: >> Duplicated code between mainboards isn't a big issue in my opinion. >> It allows the boards to be customized without worrying about other >> companies' mainboards. We've tried to make mainboards as small as we >> c

[coreboot] Re: How to best handle new Intel Saphire Rapids server boards based on Intel Archer City?

2023-06-19 Thread ron minnich
There have always been two approaches to new mainboards in coreboot. The first, "copy and convert", is to take the most similar board, copy the code, and then change it. I believe this is the strategy paul is unhappy with. The second, "embrace and extend", is to modify existing board in place to