Re: RFR: 8358530: Properties#list should warn against non-String values [v2]

2025-07-16 Thread cagliostro92
On Tue, 15 Jul 2025 16:29:11 GMT, Justin Lu wrote: >> cagliostro92 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8358530: adds warnings against non-String values in Properties class >> documentation &

Re: RFR: 8358530: Properties#list should warn against non-String values [v2]

2025-07-16 Thread cagliostro92
> Trivial PR to enhance Javadoc for the `Properties#list` method, which has > cost me some debugging time. cagliostro92 has updated the pull request incrementally with one additional commit since the last revision: 8358530: adds warnings against non-String values in Properties

Re: RFR: 8358530: enhanced Properties#list javadoc

2025-07-15 Thread cagliostro92
On Fri, 11 Jul 2025 20:51:38 GMT, Justin Lu wrote: >> Trivial PR to enhance Javadoc for the `Properties#list` method, which has >> cost me some debugging time. > > It does appear true that a `ClassCastException` is thrown if a value is not a > String for `Properties.list(PrintWriter)` and the b

RFR: 8358530: enhanced Properties#list javadoc

2025-07-15 Thread cagliostro92
Trivial PR to enhance Javadoc for the `Properties#list` method, which has cost me some debugging time. - Commit messages: - 8358530: adds warnings against non-String values in Properties class documentation Changes: https://git.openjdk.org/jdk/pull/25334/files Webrev: https://we

Re: RFR: 8358530: Properties#list should warn against non-String values [v3]

2025-07-17 Thread cagliostro92
> Trivial PR to enhance Javadoc for the `Properties#list` method, which has > cost me some debugging time. cagliostro92 has updated the pull request incrementally with one additional commit since the last revision: 8358530: adds oxford comma - Changes: - all:

Re: RFR: 8358530: Properties#list should warn against non-String values [v3]

2025-07-17 Thread cagliostro92
On Wed, 16 Jul 2025 17:42:45 GMT, Justin Lu wrote: >> My bad, sorry. Fixed with 8d7e3d2fde65bd1e4ad85eca5ea93a430e2e8238 > > Thanks for the changes. The current form seems reasonable to me, although > others might have comments. I created the following CSR, > [JDK-8362447](https://bugs.openjdk.

Integrated: 8358530: Properties#list should warn against non-String values

2025-07-23 Thread cagliostro92
On Tue, 20 May 2025 16:03:14 GMT, cagliostro92 wrote: > Trivial PR to enhance Javadoc for the `Properties#list` method, which has > cost me some debugging time. This pull request has now been integrated. Changeset: 03e9ea16 Author:Edoardo Patti Committer: Justin Lu URL:

Re: RFR: 8358530: Properties#list should warn against non-String values [v3]

2025-07-23 Thread cagliostro92
On Wed, 23 Jul 2025 16:29:38 GMT, Justin Lu wrote: >> cagliostro92 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8358530: adds oxford comma > > Thanks @cagliostro92 for the changes and @liach for review