On Fri, 21 Jun 2024 14:24:26 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This is similar with previous JDK-8334396.
> Added some tests.
>
> ### Test
>
> | Tests | Scores | Errors | Unit
> -- | -- | -- | -- | --
> Intrinsic, +zbb, +rvv | Characters.reverseBy
On Fri, 21 Jun 2024 14:24:26 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This is similar with previous JDK-8334396.
> Added some tests.
>
> ### Test
>
> | Tests | Scores | Errors | Unit
> -- | -- | -- | -- | --
> Intrinsic, +zbb, +rvv | Characters.reverseBy
On Tue, 25 Jun 2024 08:12:53 GMT, Hamlin Li wrote:
>> test/micro/org/openjdk/bench/java/lang/Characters.java line 69:
>>
>>> 67:
>>> 68: @Benchmark
>>> 69: public void reverseBytes() {
>>
>> I'm not sure we want to be adding that benchmark to this class. Could you
>> move to a differe
On Tue, 25 Oct 2022 10:37:40 GMT, Claes Redestad wrote:
> Continuing the work initiated by @luhenry to unroll and then intrinsify
> polynomial hash loops.
>
> I've rewired the library changes to route via a single `@IntrinsicCandidate`
> method. To make this work I've harmonized how they are i
On Mon, 31 Oct 2022 02:35:18 GMT, Quan Anh Mai wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Require UseSSE >= 3 due transitive use of sse3 instructions from ReduceI
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x8
On Mon, 31 Oct 2022 22:06:20 GMT, Claes Redestad wrote:
>> No you don't need to, the vector loop can be calculated as:
>>
>> IntVector accumulation = IntVector.zero(INT_SPECIES);
>> for (int i = 0; i < bound; i += INT_SPECIES.length()) {
>> IntVector current = IntVector.load(INT_
On Mon, 31 Oct 2022 22:06:20 GMT, Claes Redestad wrote:
>> No you don't need to, the vector loop can be calculated as:
>>
>> IntVector accumulation = IntVector.zero(INT_SPECIES);
>> for (int i = 0; i < bound; i += INT_SPECIES.length()) {
>> IntVector current = IntVector.load(INT_
On Sun, 13 Nov 2022 21:08:53 GMT, Claes Redestad wrote:
> Also, I'd like to note that C2 auto-vectorization support is not too far away
> from being able to optimize hash code computations. At some point, I was able
> to achieve some promising results with modest tweaking of SuperWord pass:
htt
On Wed, 16 Nov 2022 18:18:55 GMT, Claes Redestad wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missing & 0xff in StringLatin1::hashCode
>
> I'm getting pulled into other tasks and would request for this to be e
On Wed, 21 Dec 2022 17:29:23 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
On Tue, 17 Jan 2023 21:06:01 GMT, Claes Redestad wrote:
>> Continuing the work initiated by @luhenry to unroll and then intrinsify
>> polynomial hash loops.
>>
>> I've rewired the library changes to route via a single `@IntrinsicCandidate`
>> method. To make this work I've harmonized how they
On Mon, 4 Dec 2023 11:58:55 GMT, Magnus Ihse Bursie wrote:
> I can't say anything for sure, but I picked up some positive vibes from our
> internal chat. I think the idea was that libsleef could potentially cover up
> vector math for all platforms that the current Intel lib solution is missing
On Tue, 6 Feb 2024 08:20:39 GMT, Magnus Ihse Bursie wrote:
> I'd just hate to see all this work go to waste.
Same here!
-
PR Comment: https://git.openjdk.org/jdk/pull/16234#issuecomment-1929780538
On Fri, 26 Apr 2024 14:06:02 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this simple patch?
> Some index check in Byte/ShortVector.fromArray/fromArray0Template seems not
> necessary, could be removed.
> Thanks
@PaulSandoz who would be a good person to give a review on this one? It's no
On Sun, 6 Oct 2024 02:35:45 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `java/foreign/TestUpcallStress.java` call
> `System.loadLibrary("TestUpcall")` load native library, so this test should
> mark as `/native`.
> The change has been verified locally, trivial fix, no risk.
Marked a
On Mon, 7 Apr 2025 14:23:52 GMT, Hamlin Li wrote:
> the reason is the generated code by Zicond is much larger than branch version
I'm curious about this one. It's surprising to me that we see bigger code
generated with Zicond. Do you know why that is the case?
-
PR Comment: https:
On Thu, 17 Apr 2025 18:03:47 GMT, Vladimir Ivanov wrote:
>> Migrate Vector API math library (SVML and SLEEF) linkage from native code
>> (in JVM) to Java FFM API.
>>
>> Since FFM API doesn't support vector calling conventions yet, migration
>> affects only symbol lookup for now. But it still e
17 matches
Mail list logo