Re: RFR: 8331879: Clean up non-standard use of /// comments in `java.base`

2024-05-28 Thread Jonathan Gibbons
On Wed, 22 May 2024 20:13:08 GMT, Naoto Sato wrote: >> With the advent of JEP 467, `///` comments may be treated as documentation >> comments, and may be subject to the recently new `javac` warning about >> "dangling doc comments" in unexpected places. >> >> In keeping with the policy to keep

Re: RFR: 8331879: Clean up non-standard use of /// comments in `java.base`

2024-05-28 Thread Jonathan Gibbons
On Thu, 23 May 2024 05:52:57 GMT, Alan Bateman wrote: > > A long vertical series of lines beginning /// is replaced by lines > > beginning //|. > > This one looks unusual when it's just one line, I could imagine deleting the > "|" in these cases. OK. I was just trying to honor the apparent in

Re: RFR: 8331879: Clean up non-standard use of /// comments in `java.base`

2024-05-28 Thread Jonathan Gibbons
On Tue, 28 May 2024 20:01:46 GMT, Alan Bateman wrote: > > OK. I was just trying to honor the apparent intent to make the comment > > stand out more than just a plain `//` comment, but I have no strong > > feelings against reducing `///` to `//` > > In this case I would reduce it to '//' but ot

Re: RFR: 8331879: Clean up non-standard use of /// comments in `java.base` [v2]

2024-05-28 Thread Jonathan Gibbons
> exact form of the comment prefix was not significant. (Phew!) > > > (This PR is informally blocked by JEP 467). Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: incorporate review comments - Chan

Integrated: 8331879: Clean up non-standard use of /// comments in `java.base`

2024-05-31 Thread Jonathan Gibbons
On Tue, 7 May 2024 22:23:48 GMT, Jonathan Gibbons wrote: > With the advent of JEP 467, `///` comments may be treated as documentation > comments, and may be subject to the recently new `javac` warning about > "dangling doc comments" in unexpected places. > > In keepin

Re: RFR: 8330954: since-checker - Fix remaining `@since` tags in `java.base` [v4]

2024-06-03 Thread Jonathan Gibbons
On Mon, 13 May 2024 20:14:38 GMT, Nizar Benalla wrote: >> Please review this PR that aims to add all the remaining needed `@since` >> tags in `java.base`, and group them into a single fix. >> This is related to #18934 and my work around the `@since` checker feature. >> Explicit `@since` tags are

Re: RFR: 8333828: Use value javadoc tag in java.lang.{Float, Double}

2024-06-07 Thread Jonathan Gibbons
On Fri, 7 Jun 2024 21:05:33 GMT, Joe Darcy wrote: > Use the value tag to make the javadoc for various format-related constants > more informative to readers. Currently the information is available by > following the "Constant Field Values" link. > > I'll reflow the paragraphs before a push. Y

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Jonathan Gibbons
On Sun, 9 Jun 2024 22:07:44 GMT, Damon Nguyen wrote: >> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties >> line 183: >> >>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach >>> Umschalt+Tab.\nVerwenden Sie "I" für automatischen Import, "V" zur >>> V

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update

2024-06-10 Thread Jonathan Gibbons
iffs are viewable here and was generated using Jonathan > Gibbons' diff tool for l10n: > https://cr.openjdk.org/~dnguyen/output2/ src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties line 409: > 407: compiler.err.unconditional.pattern.and.default=Switch

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]

2024-06-10 Thread Jonathan Gibbons
the language or tools, (e.g. >> `the name of this class`, ``, ``. >> >> This change seems to be going backwards. >> >> Whatever the policy we use for translating (or not translating) parts of a >> message, we should be consistent across all tools and documents. >

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v2]

2024-06-26 Thread Jonathan Gibbons
On Wed, 26 Jun 2024 18:08:21 GMT, Nizar Benalla wrote: >> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commi

Re: RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-11 Thread Jonathan Gibbons
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote: > Can I please get a review for this small change, the relative link to the > stylesheet isn't needed as it wasn't used anyway in the generated HTML. The > correct link to the stylesheet is already in the generated HTML. > > This is the di

Re: RFR: 8338014: Improve usage of @jvms tags in class file API

2024-08-12 Thread Jonathan Gibbons
On Mon, 12 Aug 2024 18:42:25 GMT, Joe Darcy wrote: >> Hi all, >> >> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014) >> improving the use of `@jvms` tags by adding `JVMS` prior to the tag. >> >> Thanks, >> Sonia > > Looks fine; increasing review count to also include

Re: RFR: 8339115: Rename TypeKind enum constants to follow code style

2024-08-27 Thread Jonathan Gibbons
On Tue, 27 Aug 2024 22:15:17 GMT, Chen Liang wrote: > `TypeKind` enum constants are named in wrong code style; correct them before > finalization. > > Also improved `TypeKind` specification to talk about not mentioned > `returnType`, `void`, and subword types being erased to int (and how). See

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page [v4]

2022-09-29 Thread Jonathan Gibbons
On Tue, 27 Sep 2022 11:37:23 GMT, Hannes Wallnöfer wrote: >> Please review an enhancement to the preview page to add a list of preview >> features and allow users to explore the preview APIs by feature. >> >> While the changes for the enhancement itself are not overly complex, the >> work ent

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page [v4]

2022-09-29 Thread Jonathan Gibbons
On Tue, 27 Sep 2022 11:37:23 GMT, Hannes Wallnöfer wrote: >> Please review an enhancement to the preview page to add a list of preview >> features and allow users to explore the preview APIs by feature. >> >> While the changes for the enhancement itself are not overly complex, the >> work ent

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v4]

2022-10-03 Thread Jonathan Gibbons
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote: >> Problem: Unnecessary instances of StringBuffer within java.text (internal >> only) >> >> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method >> names > > Justin Lu has updated the pull request incrementally with two

Re: RFR: JDK-8294539: Augment discussion of equivalence relations on floating-point values [v2]

2022-10-04 Thread Jonathan Gibbons
On Tue, 4 Oct 2022 15:18:08 GMT, Paul Sandoz wrote: >> Before sending out the PR, I used a snippet, but it formatted the code using >> too much vertical space for the definition list. I didn't look to see if >> there was a "compact" styling option that could be used. > > Ok, i am not aware of a

Re: RFR: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited [v2]

2022-10-06 Thread Jonathan Gibbons
On Tue, 27 Sep 2022 12:14:23 GMT, Pavel Rappo wrote: >> This adds exception documentation to JDK methods that would otherwise lose >> that documentation once JDK-8287796 is integrated. While adding this >> exception documentation now does not change [^1] the JDK API Documentation, >> it will a

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-24 Thread Jonathan Gibbons
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-28 Thread Jonathan Gibbons
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism defin

RFR: JDK-8296547: Add @spec tags to API

2022-11-09 Thread Jonathan Gibbons
Please review a "somewhat automated" change to insert `@spec` tags into doc comments, as appropriate, to leverage the recent new javadoc feature to generate a new page listing the references to all external specifications listed in the `@spec` tags. "Somewhat automated" means that I wrote and u

Re: RFR: JDK-8296546: Add @spec tags to API

2022-11-10 Thread Jonathan Gibbons
On Thu, 10 Nov 2022 11:30:51 GMT, Daniel Fuchs wrote: > Hi Jon, > > When referencing an RFC, it might be good to keep the RFC number in the text > link. For instance I see that java.net.URL now has this: > > http://cr.openjdk.java.net/~jjg/8296546/api.00/java.base/java/net/URL.html > > Extern

Re: RFR: JDK-8296546: Add @spec tags to API

2022-11-10 Thread Jonathan Gibbons
On Thu, 10 Nov 2022 11:45:39 GMT, Alan Bateman wrote: > > When referencing an RFC, it might be good to keep the RFC number in the > > text link. For instance I see that java.net.URL now has this: > > I agree and also to add that some RFCs have commas in their titles, the same > separator used

Re: RFR: JDK-8296546: Add @spec tags to API

2022-11-10 Thread Jonathan Gibbons
On Thu, 10 Nov 2022 12:01:11 GMT, Alan Bateman wrote: > I'm trying to understand what "fix-ups" will be needed if the automated patch > is applied. In some cases, it looks the same spec will be linked from "See > also" and "External Specifications", e.g. > http://cr.openjdk.java.net/~jjg/82965

Re: RFR: 8296546: Add @spec tags to API

2022-11-10 Thread Jonathan Gibbons
On Thu, 10 Nov 2022 16:33:09 GMT, AJ1062910 wrote: > did you changed 420 files ? I ran a custom utility that edited these files, yes. - PR: https://git.openjdk.org/jdk/pull/11073

RFR: JDK-8297164: Update troff man pages and CheckManPageOptions.java

2022-11-17 Thread Jonathan Gibbons
Please review an update for the troff man pages, following the recent update to upgrade to use pandoc 2.19.2 (See https://bugs.openjdk.org/browse/JDK-8297165) In conjunction with this, one javadoc test also needs to be updated, to work with the new form of output generated by the new version of

Re: RFR: JDK-8297164: Update troff man pages and CheckManPageOptions.java

2022-11-18 Thread Jonathan Gibbons
On Fri, 18 Nov 2022 02:31:19 GMT, David Holmes wrote: > Hi @jonathan-gibbons , > > I notice that in the new version dash characters are no longer escaped as > `-`, do these still display correctly? Yes, at least in all the files I verified and I have no reason to believe

Re: RFR: JDK-8297164: Update troff man pages and CheckManPageOptions.java [v2]

2022-11-21 Thread Jonathan Gibbons
t generated by the new version of pandoc. Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Fix merge issue - Merge with upstream/master - JDK-8297164: Update troff man pages and CheckM

Re: RFR: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools

2022-11-21 Thread Jonathan Gibbons
On Mon, 21 Nov 2022 15:40:19 GMT, Christian Stein wrote: > This PR copies the `CommandLine.java` file from module `jdk.compiler` > (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module, > creating a new package with name `jdk.internal.opt`. That new > `jdk.internal.opt` packa

Integrated: JDK-8297164: Update troff man pages and CheckManPageOptions.java

2022-11-21 Thread Jonathan Gibbons
On Thu, 17 Nov 2022 22:23:53 GMT, Jonathan Gibbons wrote: > Please review an update for the troff man pages, following the recent update > to upgrade to use pandoc 2.19.2 > (See https://bugs.openjdk.org/browse/JDK-8297165) > > In conjunction with this, one javadoc test also need

Re: RFR: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools [v2]

2022-11-22 Thread Jonathan Gibbons
On Tue, 22 Nov 2022 15:57:57 GMT, Christian Stein wrote: >> This PR copies the `CommandLine.java` file from module `jdk.compiler` >> (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module, >> creating a new package with name `jdk.internal.opt`. That new >> `jdk.internal.opt` p

Re: RFR: 8296546: Add @spec tags to API [v2]

2022-11-22 Thread Jonathan Gibbons
.java.net/~jjg/8296546/api.00/external-specs.html) > page, which you can also find via the new link near the top of the > [Index](http://cr.openjdk.java.net/~jjg/8296546/api.00/index-files/index-1.html) > pages. Jonathan Gibbons has updated the pull request incrementally with one ad

Re: RFR: 8296546: Add @spec tags to API [v2]

2022-11-23 Thread Jonathan Gibbons
On Wed, 23 Nov 2022 12:43:16 GMT, Daniel Fuchs wrote: > Thanks for adding the RFC prefix to the RFC link. What is the purpose of > editing non exported classes though, like those in the `sun.net` subpackages? That was not intentional, and is a result of the scripted edit. I will look to r

Re: RFR: 8296546: Add @spec tags to API [v3]

2022-11-23 Thread Jonathan Gibbons
.java.net/~jjg/8296546/api.00/external-specs.html) > page, which you can also find via the new link near the top of the > [Index](http://cr.openjdk.java.net/~jjg/8296546/api.00/index-files/index-1.html) > pages. Jonathan Gibbons has updated the pull request incrementally with one addi

Re: RFR: 8296546: Add @spec tags to API [v3]

2022-11-23 Thread Jonathan Gibbons
On Wed, 23 Nov 2022 19:20:53 GMT, Daniel Fuchs wrote: > The java.base/net/, java.http/, java.naming/ changes look reasonable to me - > though like Alan I wonder if it wouldn't be better to have an inline `{@spec > }` tag - similar to `{@systemProperty }`, rather than repeating all the > refere

Re: RFR: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools [v3]

2022-11-28 Thread Jonathan Gibbons
On Wed, 23 Nov 2022 15:59:42 GMT, Christian Stein wrote: >> This PR copies the `CommandLine.java` file from module `jdk.compiler` >> (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module, >> creating a new package with name `jdk.internal.opt`. That new >> `jdk.internal.opt` p

Re: RFR: 8296710: Update to use jtreg 7.1

2022-11-30 Thread Jonathan Gibbons
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote: > Please review the change to update to using jtreg `7.1`. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the requiredVersi

Re: RFR: 8296546: Add @spec tags to API [v3]

2022-12-01 Thread Jonathan Gibbons
On Wed, 23 Nov 2022 23:04:36 GMT, Joe Wang wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove updates from unexported files > > src/java.xml/share/classes/javax/xml/XMLCo

Re: RFR: 8296546: Add @spec tags to API [v3]

2022-12-01 Thread Jonathan Gibbons
front page with pointers to all of the current semi-canonical versions of the spec (e.g. text, pdf-a, html, and xml). Mike On 11/28/2022 6:27 PM, Phil Race wrote: On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote: Please review a "somewhat automated" change to insert `@spec

Re: RFR: 8296546: Add @spec tags to API [v4]

2022-12-01 Thread Jonathan Gibbons
.java.net/~jjg/8296546/api.00/external-specs.html) > page, which you can also find via the new link near the top of the > [Index](http://cr.openjdk.java.net/~jjg/8296546/api.00/index-files/index-1.html) > pages. Jonathan Gibbons has updated the pull request with a new target base due to

Re: RFR: 8296546: Add @spec tags to API [v4]

2022-12-01 Thread Jonathan Gibbons
On Thu, 10 Nov 2022 23:51:19 GMT, Naoto Sato wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contai

Re: RFR: 8296546: Add @spec tags to API [v3]

2022-12-01 Thread Jonathan Gibbons
On 11/28/22 3:27 PM, Phil Race wrote: On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote: Please review a "somewhat automated" change to insert `@spec` tags into doc comments, as appropriate, to leverage the recent new javadoc feature to generate a new page listing the ref

Re: Boilerplate to add a new module

2022-12-15 Thread Jonathan Gibbons
No changes or updates are required for jtreg -- Jon On 12/13/22 7:36 PM, Ethan McCue wrote: (jtreg I assume has some extra setup? Anything else?)

Re: RFR: JDK-8300133: Use generalized see and link tags in core libs

2023-01-13 Thread Jonathan Gibbons
On Fri, 13 Jan 2023 21:30:06 GMT, Joe Darcy wrote: > With generalized see and link tags that can refer to anchors (JDK-8200337), > the see and link tags in core libraries should be updated to use this feature > when possible. This PR covers such updates for java.base. Nice to see all those `ht

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v7]

2023-01-25 Thread Jonathan Gibbons
On Wed, 25 Jan 2023 17:51:20 GMT, Damon Nguyen wrote: >> Open l10n drop. Files have been updated with translated versions. Whitespace >> tool has been ran on files. >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revisi

Re: [jdk20] RFR: 8300719: JDK 20 RDP2 L10n resource files update [v5]

2023-01-25 Thread Jonathan Gibbons
it more English-like and separate two otherwise consecutive occurrences of > "type" in that sentence, I split the words with a hyphen and lower-cased > them: exception-type. > > @jonathan-gibbons thoughts? While the text is technically correct, it may not be as clear as it could

Re: [jdk20] RFR: 8300953: ClassDesc::ofInternalName missing @since tag

2023-01-27 Thread Jonathan Gibbons
On Tue, 24 Jan 2023 13:35:14 GMT, Adam Sotona wrote: > ClassDesc::ofInternalName was added in JDK 20, however @since tag is missing. > This patch fixes the javadoc. > > Please review. > > Thanks, > Adam Marked as reviewed by jjg (Reviewer). - PR: https://git.openjdk.org/jdk20/p

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles

2023-03-01 Thread Jonathan Gibbons
On Wed, 1 Mar 2023 18:47:14 GMT, Pavel Rappo wrote: > Please review this trivial fix for _comments_. While some affected comments > aren't doc comments and none of the affected comments partake in the API > Documentation, it seems reasonable to be consistent. Marked as reviewed by jjg (Reviewe

Re: RFR: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles [v2]

2023-03-01 Thread Jonathan Gibbons
On Wed, 1 Mar 2023 19:07:40 GMT, Pavel Rappo wrote: >> Please review this trivial fix for _comments_. While some affected comments >> aren't doc comments and none of the affected comments partake in the API >> Documentation, it seems reasonable to be consistent. > > Pavel Rappo has updated the

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Jonathan Gibbons
On Fri, 3 Mar 2023 11:31:04 GMT, Alexey Ivanov wrote: >> Yes, iff means if-and-only-if and is used for extra precision in formal >> logic, mathematics. As @pavelrappo points out it's a relatively common >> occurrence in the OpenJDK sources, though perhaps not in the public >> javadocs. Perhaps

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Jonathan Gibbons
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-03-15 Thread Jonathan Gibbons
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote: > This PR converts Unicode sequences to UTF-8 native in .properties file. > (Excluding the Unicode space and tab sequence). The conversion was done using > native2ascii. > > In addition, the build logic is adjusted to support reading in the >

Re: RFR: 8304837: Classfile API throws IOOBE for MethodParameters attribute without parameter names [v2]

2023-03-23 Thread Jonathan Gibbons
On Thu, 23 Mar 2023 22:34:24 GMT, Hannes Greule wrote: >> After merging master into https://github.com/openjdk/jdk/pull/9862, we >> encountered test failures (e.g., >> https://github.com/SirYwell/jdk/actions/runs/4500940829/jobs/7923018438#step:9:2541). >> The Classfile API tries to read from

Re: RFR: 8304837: Classfile API throws IOOBE for MethodParameters attribute without parameter names [v2]

2023-03-23 Thread Jonathan Gibbons
On Thu, 23 Mar 2023 22:34:24 GMT, Hannes Greule wrote: >> After merging master into https://github.com/openjdk/jdk/pull/9862, we >> encountered test failures (e.g., >> https://github.com/SirYwell/jdk/actions/runs/4500940829/jobs/7923018438#step:9:2541). >> The Classfile API tries to read from

RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1)

2023-03-30 Thread Jonathan Gibbons
Please review a change to add `@spec` tags (and remove some equivalent `@see` tags) to the main "core-libs" packages in `java.base` module. This is similar to, and a subset of, PR #11073. That PR was withdrawn, and based on the ensuing discussion and suggestion, is now being handled with a se

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1)

2023-03-30 Thread Jonathan Gibbons
On Thu, 30 Mar 2023 19:42:33 GMT, Alan Bateman wrote: >> Please review a change to add `@spec` tags (and remove some equivalent >> `@see` tags) to the main "core-libs" packages in `java.base` module. >> >> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and >> based on

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1) [v2]

2023-03-30 Thread Jonathan Gibbons
80e62c4031c4c9752460de5f36c/make/Docs.gmk#L68 > [disabled]: > https://github.com/openjdk/jdk/blob/83cf28f99639d80e62c4031c4c9752460de5f36c/make/Docs.gmk#L115 Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: address revie

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1)

2023-03-30 Thread Jonathan Gibbons
On Thu, 30 Mar 2023 17:24:11 GMT, Jonathan Gibbons wrote: > Please review a change to add `@spec` tags (and remove some equivalent `@see` > tags) to the main "core-libs" packages in `java.base` module. > > This is similar to, and a subset of, PR #11073. That PR was with

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1) [v2]

2023-03-31 Thread Jonathan Gibbons
On Fri, 31 Mar 2023 10:45:39 GMT, Lance Andersen wrote: > > Hi Jon, > > This looks fine. I was wondering if we should do the same for java.util.zip > > and the PKWare Zip Spec or where java.sql references the JDBC Spec? > > Well, I must need coffee this morning as obviously JDBC is in the java.

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1) [v2]

2023-03-31 Thread Jonathan Gibbons
On Fri, 31 Mar 2023 17:14:01 GMT, Iris Clark wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review feedback > > src/java.base/share/classes/java/io/ObjectOutputStream.jav

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1) [v3]

2023-03-31 Thread Jonathan Gibbons
80e62c4031c4c9752460de5f36c/make/Docs.gmk#L68 > [disabled]: > https://github.com/openjdk/jdk/blob/83cf28f99639d80e62c4031c4c9752460de5f36c/make/Docs.gmk#L115 Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: revert re

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1) [v2]

2023-03-31 Thread Jonathan Gibbons
On Fri, 31 Mar 2023 16:28:14 GMT, Sean Mullan wrote: > I didn't see any changes to security APIs - are they coming in a follow-on > issue? Yes, this is _Add `@spec` tags in java.base/java.* (part 1)_ The rest of `java.base` will be in part 2. - PR Comment: https://git.openjdk.org/

Integrated: JDK-8305206: Add @spec tags in java.base/java.* (part 1)

2023-04-03 Thread Jonathan Gibbons
On Thu, 30 Mar 2023 17:24:11 GMT, Jonathan Gibbons wrote: > Please review a change to add `@spec` tags (and remove some equivalent `@see` > tags) to the main "core-libs" packages in `java.base` module. > > This is similar to, and a subset of, PR #11073. That PR was with

RFR: JDK-8305713: DocCommentParser: merge blockContent and inlineContent

2023-04-11 Thread Jonathan Gibbons
Please review a cleanup in DocCommentParser to merge blockContent and inlineContent into a single method to parse "rich content" in a doc comment. - Depends on: https://git.openjdk.org/jdk/pull/13362 Commit messages: - JDK-8305713: DocCommentParser: merge blockContent and inlineCon

Re: RFR: JDK-8305713: DocCommentParser: merge blockContent and inlineContent [v2]

2023-04-11 Thread Jonathan Gibbons
> Please review a cleanup in DocCommentParser to merge blockContent and > inlineContent into a single method to parse "rich content" in a doc comment. Jonathan Gibbons has updated the pull request incrementally with 42 additional commits since the last revision: - Merge remote

Re: RFR: JDK-8305713: DocCommentParser: merge blockContent and inlineContent [v3]

2023-04-11 Thread Jonathan Gibbons
> Please review a cleanup in DocCommentParser to merge blockContent and > inlineContent into a single method to parse "rich content" in a doc comment. Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The pull request now con

Re: RFR: 8304896: Update to use jtreg 7.2

2023-04-18 Thread Jonathan Gibbons
On Tue, 18 Apr 2023 12:08:50 GMT, Andrey Turbanov wrote: > Interesting, why this JBS ticked is considered as a bug? There's no obvious best choice here (bug, enhancement, task) and as is, it was the same as for similar previous items. - PR Comment: https://git.openjdk.org/jdk/pull

Re: RFR: JDK-8304036: Use CommandLine class from shared module

2023-04-21 Thread Jonathan Gibbons
On Mon, 13 Mar 2023 08:16:54 GMT, Christian Stein wrote: > This pull request addresses the open ends left by > [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): > - #11272 > > Changes: > - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` > to `jdk.compiler`

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v2]

2023-04-21 Thread Jonathan Gibbons
On Fri, 21 Apr 2023 21:14:00 GMT, Christian Stein wrote: >> This pull request addresses the open ends left by >> [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): >> - #11272 >> >> Changes: >> - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` >> to `jdk.com

Re: RFR: JDK-8306584: Start of release updates for JDK 22

2023-05-23 Thread Jonathan Gibbons
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote: > Time to get JDK 22 underway... test/langtools/tools/javac/versions/Versions.java line 26: > 24: /* > 25: * @test > 26: * @bug 4981566 5028634 5094412 6304984 7025786 7025789 8001112 8028545 > 8000961 8030610 8028546 8188870 8173382 8173382

Integrated: JDK-8288624: Cleanup CommentHelper.getText0

2022-07-13 Thread Jonathan Gibbons
On Sat, 9 Jul 2022 01:55:32 GMT, Jonathan Gibbons wrote: > Please review a moderately simple fix to clean up (as in _remove_!) > `CommentHelper.getText` and friends/overloads. > > This is moderately simple, because most of the heavy lifting was done in > [JDK-8288699](https://b

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-18 Thread Jonathan Gibbons
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote: > Please review these changes to the nroff manpage files so that they match > their markdown sources that Oracle maintains. > > All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 > if needed. Additionally: > > T

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

2022-07-18 Thread Jonathan Gibbons
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote: > Please review these changes to the nroff manpage files so that they match > their markdown sources that Oracle maintains. > > All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 > if needed. Additionally: > > T

Re: RFR: 8289562: Change bugs.java.com and bugreport.java.com URL's to https

2022-08-16 Thread Jonathan Gibbons
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote: > 8289562: Change bugs.java.com and bugreport.java.com URL's to https `jdk.compiler` and `jdk.javadoc` changes look OK - Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.org/jdk/pull/9445

Re: RFR: JDK-8287597: List all preview features on the javadoc PREVIEW page

2022-08-18 Thread Jonathan Gibbons
On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to the preview page to add a list of preview > features and allow users to explore the preview APIs by feature. > > While the changes for the enhancement itself are not overly complex, the work > entailed

Re: RFR: 8285368: Overhaul doc-comment inheritance

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 14:19:16 GMT, Pavel Rappo wrote: > Please review this long-awaited change to documentation inheritance. > > This change improves "methods comment algorithm" and introduces directed > documentation inheritance. While "methods comment algorithm" -- automatic > search for inher

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote: >> Please review this long-awaited change to documentation inheritance. >> >> This change improves "methods comment algorithm" and introduces directed >> documentation inheritance. While "methods comment algorithm" -- automatic >> search for

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 20:48:58 GMT, Pavel Rappo wrote: >> test/langtools/jdk/javadoc/doclet/testDirectedInheritance/TestDirectedInheritance.java >> line 673: >> >>> 671: * >>> 672: * For now a warning is issued if a doc comment inherits from >>> 673: * an indirect supertype. >> >>

Re: RFR: 8285368: Overhaul doc-comment inheritance [v2]

2023-06-07 Thread Jonathan Gibbons
On Wed, 7 Jun 2023 21:37:42 GMT, Jonathan Gibbons wrote: >> Sure we can; this relates to an earlier comment of yours on >> Utils.isDirectSupertype here: >> https://github.com/openjdk/jdk/pull/14357#discussion_r1222053011 > > The general criticism here is whether we sh

RFR: JDK-8309686: inconsistent URL for https://www.unicode.org/reports/tr35

2023-06-08 Thread Jonathan Gibbons
Please review a trivial docs change to fix a URL in a `@spec` tag consistent with equivalent URLs in other tags. (Consistency will be required when the External Specifications page is enabled.) - Commit messages: - JDK-8309686: inconsistent URL for https://www.unicode.org/reports/tr

Integrated: JDK-8309686: inconsistent URL for https://www.unicode.org/reports/tr35

2023-06-08 Thread Jonathan Gibbons
On Thu, 8 Jun 2023 21:36:03 GMT, Jonathan Gibbons wrote: > Please review a trivial docs change to fix a URL in a `@spec` tag consistent > with equivalent URLs in other tags. > (Consistency will be required when the External Specifications page is > enabled.) This pull request

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Jonathan Gibbons
On Tue, 13 Jun 2023 18:38:28 GMT, Naoto Sato wrote: > Left some comments on the translations mainly in Japanese. It is now very > easy to look at the l10n changes in the generated HTML. One small comment to > the tool is that it would be nice if the order in HTML (alphabetically sorted > curre

Re: [jdk21] RFR: 8309670: java -help output for --module-path / -p is incomplete

2023-06-26 Thread Jonathan Gibbons
On Fri, 23 Jun 2023 11:32:04 GMT, Christian Stein wrote: > Hi all, > > This pull request contains a backport of commit > [4bf78162](https://github.com/openjdk/jdk/commit/4bf78162c52564645af79b8324b69d89102dc024) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

RFR: JDK-8310909: java.io.InvalidObjectException has redundant `@since` tag

2023-06-26 Thread Jonathan Gibbons
Please review a trivial update to remove a redundant `@since` tag. - Commit messages: - JDK-8310909: java.io.InvalidObjectException has redundant `@since` tag Changes: https://git.openjdk.org/jdk/pull/14662/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14662&range=00 Iss

Integrated: JDK-8310909: java.io.InvalidObjectException has redundant `@since` tag

2023-06-26 Thread Jonathan Gibbons
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote: > Please review a trivial update to remove a redundant `@since` tag. This pull request has now been integrated. Changeset: 46add3f8 Author: Jonathan Gibbons URL: https://git.openjdk.org/jdk/com

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-05 Thread Jonathan Gibbons
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: RFR: 8308753: Class-File API transition to Preview [v2]

2023-09-28 Thread Jonathan Gibbons
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v3]

2023-10-20 Thread Jonathan Gibbons
On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work, t

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Jonathan Gibbons
On Tue, 21 Nov 2023 18:51:55 GMT, Jim Laskey wrote: > The comments are attached to the modifiers (first thing it encounters.) I’m > sure the javadoc toolset has a method that gets the comments from the right > thing. In the AST created by the parser, doc comments should be attached to _declar

Re: RFR: 8322041: JDK 22 RDP1 L10n resource files update [v2]

2023-12-15 Thread Jonathan Gibbons
On Thu, 14 Dec 2023 22:17:54 GMT, Alisen Chung wrote: >> Translation drop for JDK22 RDP1 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > removed quotes around Ablehnen The diffs are more conveniently available here: https:

Re: RFR: 8339631: Fix block @jls and @jvms tags

2024-09-05 Thread Jonathan Gibbons
On Thu, 5 Sep 2024 21:46:34 GMT, Pavel Rappo wrote: > This fixes some of the recently discovered [issues] with the block variants > of the specification tags. While reviewing, please check the proposed changes > against the actual specifications. Since the specifications for JDK 23 are > not y

Re: RFR: 8339631: Fix block @jls and @jvms tags [v2]

2024-09-06 Thread Jonathan Gibbons
On Fri, 6 Sep 2024 12:09:16 GMT, Pavel Rappo wrote: > Thoughts? My initial thought is, at least we're working with specific tags (`@jls` and `@jvms`) rather than generic HTML links (`...`), since that permits the kind of detailed analysis and checking you are doing. Preview-ness is a pervasiv

Re: RFR: 8339789: Use index and definition tags in AnnotatedElement

2024-09-09 Thread Jonathan Gibbons
On Mon, 9 Sep 2024 18:37:47 GMT, Joe Darcy wrote: > Use index and definition tags in AnnotatedElement. OK. As a subsidiary follow-up, one might ask whether `{@index...}` should implicitly include `` tags in its output. - Marked as reviewed by jjg (Reviewer). PR Review: https://g

Re: RFR: JDK-8323760 putIfAbsent documentation conflicts with itself [v2]

2024-02-14 Thread Jonathan Gibbons
On Tue, 13 Feb 2024 17:11:05 GMT, John Hendrikx wrote: >> Update the documentation for `@return` tag of `putIfAbsent` to match the >> main description. `putIfAbsent` uses the same wording as `put` for its >> `@return` tag, but that is incorrect. `putIfAbsent` never returns the >> **previous**

  1   2   >