On Wed, 22 May 2024 20:13:08 GMT, Naoto Sato wrote:
>> With the advent of JEP 467, `///` comments may be treated as documentation
>> comments, and may be subject to the recently new `javac` warning about
>> "dangling doc comments" in unexpected places.
>>
>> In keeping with the policy to keep
On Thu, 23 May 2024 05:52:57 GMT, Alan Bateman wrote:
> > A long vertical series of lines beginning /// is replaced by lines
> > beginning //|.
>
> This one looks unusual when it's just one line, I could imagine deleting the
> "|" in these cases.
OK. I was just trying to honor the apparent in
On Tue, 28 May 2024 20:01:46 GMT, Alan Bateman wrote:
> > OK. I was just trying to honor the apparent intent to make the comment
> > stand out more than just a plain `//` comment, but I have no strong
> > feelings against reducing `///` to `//`
>
> In this case I would reduce it to '//' but ot
> exact form of the comment prefix was not significant. (Phew!)
>
>
> (This PR is informally blocked by JEP 467).
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
incorporate review comments
-
Chan
On Tue, 7 May 2024 22:23:48 GMT, Jonathan Gibbons wrote:
> With the advent of JEP 467, `///` comments may be treated as documentation
> comments, and may be subject to the recently new `javac` warning about
> "dangling doc comments" in unexpected places.
>
> In keepin
On Mon, 13 May 2024 20:14:38 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
On Fri, 7 Jun 2024 21:05:33 GMT, Joe Darcy wrote:
> Use the value tag to make the javadoc for various format-related constants
> more informative to readers. Currently the information is available by
> following the "Constant Field Values" link.
>
> I'll reflow the paragraphs before a push.
Y
On Sun, 9 Jun 2024 22:07:44 GMT, Damon Nguyen wrote:
>> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties
>> line 183:
>>
>>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach
>>> Umschalt+Tab.\nVerwenden Sie "I" für automatischen Import, "V" zur
>>> V
iffs are viewable here and was generated using Jonathan
> Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties
line 409:
> 407: compiler.err.unconditional.pattern.and.default=Switch
the language or tools, (e.g.
>> `the name of this class`, ``, ``.
>>
>> This change seems to be going backwards.
>>
>> Whatever the policy we use for translating (or not translating) parts of a
>> message, we should be consistent across all tools and documents.
>
On Wed, 26 Jun 2024 18:08:21 GMT, Nizar Benalla wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commi
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change, the relative link to the
> stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
> correct link to the stylesheet is already in the generated HTML.
>
> This is the di
On Mon, 12 Aug 2024 18:42:25 GMT, Joe Darcy wrote:
>> Hi all,
>>
>> This PR addresses [8338014](https://bugs.openjdk.org/browse/JDK-8338014)
>> improving the use of `@jvms` tags by adding `JVMS` prior to the tag.
>>
>> Thanks,
>> Sonia
>
> Looks fine; increasing review count to also include
On Tue, 27 Aug 2024 22:15:17 GMT, Chen Liang wrote:
> `TypeKind` enum constants are named in wrong code style; correct them before
> finalization.
>
> Also improved `TypeKind` specification to talk about not mentioned
> `returnType`, `void`, and subword types being erased to int (and how). See
On Tue, 27 Sep 2022 11:37:23 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to the preview page to add a list of preview
>> features and allow users to explore the preview APIs by feature.
>>
>> While the changes for the enhancement itself are not overly complex, the
>> work ent
On Tue, 27 Sep 2022 11:37:23 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to the preview page to add a list of preview
>> features and allow users to explore the preview APIs by feature.
>>
>> While the changes for the enhancement itself are not overly complex, the
>> work ent
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Tue, 4 Oct 2022 15:18:08 GMT, Paul Sandoz wrote:
>> Before sending out the PR, I used a snippet, but it formatted the code using
>> too much vertical space for the definition list. I didn't look to see if
>> there was a "compact" styling option that could be used.
>
> Ok, i am not aware of a
On Tue, 27 Sep 2022 12:14:23 GMT, Pavel Rappo wrote:
>> This adds exception documentation to JDK methods that would otherwise lose
>> that documentation once JDK-8287796 is integrated. While adding this
>> exception documentation now does not change [^1] the JDK API Documentation,
>> it will a
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism defin
Please review a "somewhat automated" change to insert `@spec` tags into doc
comments, as appropriate, to leverage the recent new javadoc feature to
generate a new page listing the references to all external specifications
listed in the `@spec` tags.
"Somewhat automated" means that I wrote and u
On Thu, 10 Nov 2022 11:30:51 GMT, Daniel Fuchs wrote:
> Hi Jon,
>
> When referencing an RFC, it might be good to keep the RFC number in the text
> link. For instance I see that java.net.URL now has this:
>
> http://cr.openjdk.java.net/~jjg/8296546/api.00/java.base/java/net/URL.html
>
> Extern
On Thu, 10 Nov 2022 11:45:39 GMT, Alan Bateman wrote:
> > When referencing an RFC, it might be good to keep the RFC number in the
> > text link. For instance I see that java.net.URL now has this:
>
> I agree and also to add that some RFCs have commas in their titles, the same
> separator used
On Thu, 10 Nov 2022 12:01:11 GMT, Alan Bateman wrote:
> I'm trying to understand what "fix-ups" will be needed if the automated patch
> is applied. In some cases, it looks the same spec will be linked from "See
> also" and "External Specifications", e.g.
> http://cr.openjdk.java.net/~jjg/82965
On Thu, 10 Nov 2022 16:33:09 GMT, AJ1062910 wrote:
> did you changed 420 files ?
I ran a custom utility that edited these files, yes.
-
PR: https://git.openjdk.org/jdk/pull/11073
Please review an update for the troff man pages, following the recent update to
upgrade to use pandoc 2.19.2
(See https://bugs.openjdk.org/browse/JDK-8297165)
In conjunction with this, one javadoc test also needs to be updated, to work
with the new form of output generated by the new version of
On Fri, 18 Nov 2022 02:31:19 GMT, David Holmes wrote:
> Hi @jonathan-gibbons ,
>
> I notice that in the new version dash characters are no longer escaped as
> `-`, do these still display correctly?
Yes, at least in all the files I verified and I have no reason to believe
t generated by the new version of pandoc.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains three commits:
- Fix merge issue
- Merge with upstream/master
- JDK-8297164: Update troff man pages and CheckM
On Mon, 21 Nov 2022 15:40:19 GMT, Christian Stein wrote:
> This PR copies the `CommandLine.java` file from module `jdk.compiler`
> (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module,
> creating a new package with name `jdk.internal.opt`. That new
> `jdk.internal.opt` packa
On Thu, 17 Nov 2022 22:23:53 GMT, Jonathan Gibbons wrote:
> Please review an update for the troff man pages, following the recent update
> to upgrade to use pandoc 2.19.2
> (See https://bugs.openjdk.org/browse/JDK-8297165)
>
> In conjunction with this, one javadoc test also need
On Tue, 22 Nov 2022 15:57:57 GMT, Christian Stein wrote:
>> This PR copies the `CommandLine.java` file from module `jdk.compiler`
>> (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module,
>> creating a new package with name `jdk.internal.opt`. That new
>> `jdk.internal.opt` p
.java.net/~jjg/8296546/api.00/external-specs.html)
> page, which you can also find via the new link near the top of the
> [Index](http://cr.openjdk.java.net/~jjg/8296546/api.00/index-files/index-1.html)
> pages.
Jonathan Gibbons has updated the pull request incrementally with one ad
On Wed, 23 Nov 2022 12:43:16 GMT, Daniel Fuchs wrote:
> Thanks for adding the RFC prefix to the RFC link. What is the purpose of
> editing non exported classes though, like those in the `sun.net` subpackages?
That was not intentional, and is a result of the scripted edit. I will look to
r
.java.net/~jjg/8296546/api.00/external-specs.html)
> page, which you can also find via the new link near the top of the
> [Index](http://cr.openjdk.java.net/~jjg/8296546/api.00/index-files/index-1.html)
> pages.
Jonathan Gibbons has updated the pull request incrementally with one addi
On Wed, 23 Nov 2022 19:20:53 GMT, Daniel Fuchs wrote:
> The java.base/net/, java.http/, java.naming/ changes look reasonable to me -
> though like Alan I wonder if it wouldn't be better to have an inline `{@spec
> }` tag - similar to `{@systemProperty }`, rather than repeating all the
> refere
On Wed, 23 Nov 2022 15:59:42 GMT, Christian Stein wrote:
>> This PR copies the `CommandLine.java` file from module `jdk.compiler`
>> (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module,
>> creating a new package with name `jdk.internal.opt`. That new
>> `jdk.internal.opt` p
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersi
On Wed, 23 Nov 2022 23:04:36 GMT, Joe Wang wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove updates from unexported files
>
> src/java.xml/share/classes/javax/xml/XMLCo
front page with pointers to all of the current semi-canonical
versions of the spec (e.g. text, pdf-a, html, and xml).
Mike
On 11/28/2022 6:27 PM, Phil Race wrote:
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons
wrote:
Please review a "somewhat automated" change to insert `@spec
.java.net/~jjg/8296546/api.00/external-specs.html)
> page, which you can also find via the new link near the top of the
> [Index](http://cr.openjdk.java.net/~jjg/8296546/api.00/index-files/index-1.html)
> pages.
Jonathan Gibbons has updated the pull request with a new target base due to
On Thu, 10 Nov 2022 23:51:19 GMT, Naoto Sato wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On 11/28/22 3:27 PM, Phil Race wrote:
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
Please review a "somewhat automated" change to insert `@spec` tags into doc
comments, as appropriate, to leverage the recent new javadoc feature to generate a new
page listing the ref
No changes or updates are required for jtreg
-- Jon
On 12/13/22 7:36 PM, Ethan McCue wrote:
(jtreg I assume has some extra setup? Anything else?)
On Fri, 13 Jan 2023 21:30:06 GMT, Joe Darcy wrote:
> With generalized see and link tags that can refer to anchors (JDK-8200337),
> the see and link tags in core libraries should be updated to use this feature
> when possible. This PR covers such updates for java.base.
Nice to see all those `ht
On Wed, 25 Jan 2023 17:51:20 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
it more English-like and separate two otherwise consecutive occurrences of
> "type" in that sentence, I split the words with a hyphen and lower-cased
> them: exception-type.
>
> @jonathan-gibbons thoughts?
While the text is technically correct, it may not be as clear as it could
On Tue, 24 Jan 2023 13:35:14 GMT, Adam Sotona wrote:
> ClassDesc::ofInternalName was added in JDK 20, however @since tag is missing.
> This patch fixes the javadoc.
>
> Please review.
>
> Thanks,
> Adam
Marked as reviewed by jjg (Reviewer).
-
PR: https://git.openjdk.org/jdk20/p
On Wed, 1 Mar 2023 18:47:14 GMT, Pavel Rappo wrote:
> Please review this trivial fix for _comments_. While some affected comments
> aren't doc comments and none of the affected comments partake in the API
> Documentation, it seems reasonable to be consistent.
Marked as reviewed by jjg (Reviewe
On Wed, 1 Mar 2023 19:07:40 GMT, Pavel Rappo wrote:
>> Please review this trivial fix for _comments_. While some affected comments
>> aren't doc comments and none of the affected comments partake in the API
>> Documentation, it seems reasonable to be consistent.
>
> Pavel Rappo has updated the
On Fri, 3 Mar 2023 11:31:04 GMT, Alexey Ivanov wrote:
>> Yes, iff means if-and-only-if and is used for extra precision in formal
>> logic, mathematics. As @pavelrappo points out it's a relatively common
>> occurrence in the OpenJDK sources, though perhaps not in the public
>> javadocs. Perhaps
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Thu, 23 Mar 2023 22:34:24 GMT, Hannes Greule wrote:
>> After merging master into https://github.com/openjdk/jdk/pull/9862, we
>> encountered test failures (e.g.,
>> https://github.com/SirYwell/jdk/actions/runs/4500940829/jobs/7923018438#step:9:2541).
>> The Classfile API tries to read from
On Thu, 23 Mar 2023 22:34:24 GMT, Hannes Greule wrote:
>> After merging master into https://github.com/openjdk/jdk/pull/9862, we
>> encountered test failures (e.g.,
>> https://github.com/SirYwell/jdk/actions/runs/4500940829/jobs/7923018438#step:9:2541).
>> The Classfile API tries to read from
Please review a change to add `@spec` tags (and remove some equivalent `@see`
tags) to the main "core-libs" packages in `java.base` module.
This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
based on the ensuing discussion and suggestion, is now being handled with a
se
On Thu, 30 Mar 2023 19:42:33 GMT, Alan Bateman wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> based on
80e62c4031c4c9752460de5f36c/make/Docs.gmk#L68
> [disabled]:
> https://github.com/openjdk/jdk/blob/83cf28f99639d80e62c4031c4c9752460de5f36c/make/Docs.gmk#L115
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
address revie
On Thu, 30 Mar 2023 17:24:11 GMT, Jonathan Gibbons wrote:
> Please review a change to add `@spec` tags (and remove some equivalent `@see`
> tags) to the main "core-libs" packages in `java.base` module.
>
> This is similar to, and a subset of, PR #11073. That PR was with
On Fri, 31 Mar 2023 10:45:39 GMT, Lance Andersen wrote:
> > Hi Jon,
> > This looks fine. I was wondering if we should do the same for java.util.zip
> > and the PKWare Zip Spec or where java.sql references the JDBC Spec?
>
> Well, I must need coffee this morning as obviously JDBC is in the java.
On Fri, 31 Mar 2023 17:14:01 GMT, Iris Clark wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
> src/java.base/share/classes/java/io/ObjectOutputStream.jav
80e62c4031c4c9752460de5f36c/make/Docs.gmk#L68
> [disabled]:
> https://github.com/openjdk/jdk/blob/83cf28f99639d80e62c4031c4c9752460de5f36c/make/Docs.gmk#L115
Jonathan Gibbons has updated the pull request incrementally with one additional
commit since the last revision:
revert re
On Fri, 31 Mar 2023 16:28:14 GMT, Sean Mullan wrote:
> I didn't see any changes to security APIs - are they coming in a follow-on
> issue?
Yes, this is _Add `@spec` tags in java.base/java.* (part 1)_
The rest of `java.base` will be in part 2.
-
PR Comment: https://git.openjdk.org/
On Thu, 30 Mar 2023 17:24:11 GMT, Jonathan Gibbons wrote:
> Please review a change to add `@spec` tags (and remove some equivalent `@see`
> tags) to the main "core-libs" packages in `java.base` module.
>
> This is similar to, and a subset of, PR #11073. That PR was with
Please review a cleanup in DocCommentParser to merge blockContent and
inlineContent into a single method to parse "rich content" in a doc comment.
-
Depends on: https://git.openjdk.org/jdk/pull/13362
Commit messages:
- JDK-8305713: DocCommentParser: merge blockContent and inlineCon
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request incrementally with 42 additional
commits since the last revision:
- Merge remote
> Please review a cleanup in DocCommentParser to merge blockContent and
> inlineContent into a single method to parse "rich content" in a doc comment.
Jonathan Gibbons has updated the pull request with a new target base due to a
merge or a rebase. The pull request now con
On Tue, 18 Apr 2023 12:08:50 GMT, Andrey Turbanov wrote:
> Interesting, why this JBS ticked is considered as a bug?
There's no obvious best choice here (bug, enhancement, task) and as is, it was
the same as for similar previous items.
-
PR Comment: https://git.openjdk.org/jdk/pull
On Mon, 13 Mar 2023 08:16:54 GMT, Christian Stein wrote:
> This pull request addresses the open ends left by
> [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919):
> - #11272
>
> Changes:
> - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt`
> to `jdk.compiler`
On Fri, 21 Apr 2023 21:14:00 GMT, Christian Stein wrote:
>> This pull request addresses the open ends left by
>> [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919):
>> - #11272
>>
>> Changes:
>> - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt`
>> to `jdk.com
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote:
> Time to get JDK 22 underway...
test/langtools/tools/javac/versions/Versions.java line 26:
> 24: /*
> 25: * @test
> 26: * @bug 4981566 5028634 5094412 6304984 7025786 7025789 8001112 8028545
> 8000961 8030610 8028546 8188870 8173382 8173382
On Sat, 9 Jul 2022 01:55:32 GMT, Jonathan Gibbons wrote:
> Please review a moderately simple fix to clean up (as in _remove_!)
> `CommentHelper.getText` and friends/overloads.
>
> This is moderately simple, because most of the heavy lifting was done in
> [JDK-8288699](https://b
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote:
> Please review these changes to the nroff manpage files so that they match
> their markdown sources that Oracle maintains.
>
> All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022
> if needed. Additionally:
>
> T
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote:
> Please review these changes to the nroff manpage files so that they match
> their markdown sources that Oracle maintains.
>
> All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022
> if needed. Additionally:
>
> T
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
`jdk.compiler` and `jdk.javadoc` changes look OK
-
Marked as reviewed by jjg (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9445
On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to the preview page to add a list of preview
> features and allow users to explore the preview APIs by feature.
>
> While the changes for the enhancement itself are not overly complex, the work
> entailed
On Wed, 7 Jun 2023 14:19:16 GMT, Pavel Rappo wrote:
> Please review this long-awaited change to documentation inheritance.
>
> This change improves "methods comment algorithm" and introduces directed
> documentation inheritance. While "methods comment algorithm" -- automatic
> search for inher
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Wed, 7 Jun 2023 16:02:40 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Wed, 7 Jun 2023 20:48:58 GMT, Pavel Rappo wrote:
>> test/langtools/jdk/javadoc/doclet/testDirectedInheritance/TestDirectedInheritance.java
>> line 673:
>>
>>> 671: *
>>> 672: * For now a warning is issued if a doc comment inherits from
>>> 673: * an indirect supertype.
>>
>>
On Wed, 7 Jun 2023 21:37:42 GMT, Jonathan Gibbons wrote:
>> Sure we can; this relates to an earlier comment of yours on
>> Utils.isDirectSupertype here:
>> https://github.com/openjdk/jdk/pull/14357#discussion_r1222053011
>
> The general criticism here is whether we sh
Please review a trivial docs change to fix a URL in a `@spec` tag consistent
with equivalent URLs in other tags.
(Consistency will be required when the External Specifications page is enabled.)
-
Commit messages:
- JDK-8309686: inconsistent URL for https://www.unicode.org/reports/tr
On Thu, 8 Jun 2023 21:36:03 GMT, Jonathan Gibbons wrote:
> Please review a trivial docs change to fix a URL in a `@spec` tag consistent
> with equivalent URLs in other tags.
> (Consistency will be required when the External Specifications page is
> enabled.)
This pull request
On Tue, 13 Jun 2023 18:38:28 GMT, Naoto Sato wrote:
> Left some comments on the translations mainly in Japanese. It is now very
> easy to look at the l10n changes in the generated HTML. One small comment to
> the tool is that it would be nice if the order in HTML (alphabetically sorted
> curre
On Fri, 23 Jun 2023 11:32:04 GMT, Christian Stein wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [4bf78162](https://github.com/openjdk/jdk/commit/4bf78162c52564645af79b8324b69d89102dc024)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
Please review a trivial update to remove a redundant `@since` tag.
-
Commit messages:
- JDK-8310909: java.io.InvalidObjectException has redundant `@since` tag
Changes: https://git.openjdk.org/jdk/pull/14662/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14662&range=00
Iss
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
This pull request has now been integrated.
Changeset: 46add3f8
Author: Jonathan Gibbons
URL:
https://git.openjdk.org/jdk/com
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Fri, 20 Oct 2023 15:45:50 GMT, Doug Simon wrote:
>> The Graal code base has
>> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33)
>> its module to `jdk.compiler.graal` as part of preparations for Project
>> Galahad. Due to the way Java modules work, t
On Tue, 21 Nov 2023 18:51:55 GMT, Jim Laskey wrote:
> The comments are attached to the modifiers (first thing it encounters.) I’m
> sure the javadoc toolset has a method that gets the comments from the right
> thing.
In the AST created by the parser, doc comments should be attached to
_declar
On Thu, 14 Dec 2023 22:17:54 GMT, Alisen Chung wrote:
>> Translation drop for JDK22 RDP1
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed quotes around Ablehnen
The diffs are more conveniently available here:
https:
On Thu, 5 Sep 2024 21:46:34 GMT, Pavel Rappo wrote:
> This fixes some of the recently discovered [issues] with the block variants
> of the specification tags. While reviewing, please check the proposed changes
> against the actual specifications. Since the specifications for JDK 23 are
> not y
On Fri, 6 Sep 2024 12:09:16 GMT, Pavel Rappo wrote:
> Thoughts?
My initial thought is, at least we're working with specific tags (`@jls` and
`@jvms`) rather than generic HTML links (`...`), since that
permits the kind of detailed analysis and checking you are doing.
Preview-ness is a pervasiv
On Mon, 9 Sep 2024 18:37:47 GMT, Joe Darcy wrote:
> Use index and definition tags in AnnotatedElement.
OK.
As a subsidiary follow-up, one might ask whether `{@index...}` should
implicitly include `` tags in its output.
-
Marked as reviewed by jjg (Reviewer).
PR Review: https://g
On Tue, 13 Feb 2024 17:11:05 GMT, John Hendrikx wrote:
>> Update the documentation for `@return` tag of `putIfAbsent` to match the
>> main description. `putIfAbsent` uses the same wording as `put` for its
>> `@return` tag, but that is incorrect. `putIfAbsent` never returns the
>> **previous**
1 - 100 of 147 matches
Mail list logo