On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote:
> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19366#pullrequestreview-2074232921
On Thu, 30 May 2024 17:11:31 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 18 commits:
>
> - Merge branch 'master' into JDK-8330188
> - Update symbol files for JDK 23
On Tue, 28 May 2024 22:31:15 GMT, Jonathan Gibbons wrote:
>> With the advent of JEP 467, `///` comments may be treated as documentation
>> comments, and may be subject to the recently new `javac` warning about
>> "dangling doc comments" in unexpected places.
>>
>> In keeping with the policy to
On Mon, 3 Jun 2024 04:25:38 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which uncomments an
> additional test that was commented out in
> `test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java`?
>
> As noted in https://bugs.openjdk.org/browse/JDK-89
On Tue, 4 Jun 2024 21:17:43 GMT, Joe Wang wrote:
> Fix a broken link.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19551#pullrequestreview-2097432388
On Wed, 5 Jun 2024 15:35:18 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 23 commits:
>
> - Update copyright.
> - Updated problem list after bug fix.
> - Merge branch
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote:
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks up the unpublished chan
On Thu, 13 Jun 2024 16:47:43 GMT, Viktor Klang wrote:
> Making sure that the Javadoc is correct for Gatherer
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19704#pullrequestreview-2116350395
On Mon, 17 Jun 2024 21:05:13 GMT, Justin Lu wrote:
> Please review this PR, which is a trivial update of the IANA subtag registry
> to version 2024-06-14.
> Announcement:
> https://mm.icann.org/pipermail/ietf-languages-announcements/2024-June/92.html
Marked as reviewed by iris (Reviewer).
On Wed, 19 Jun 2024 02:21:05 GMT, Joe Darcy wrote:
> Simple doc improvement.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19781#pullrequestreview-2126919618
On Fri, 28 Jun 2024 22:46:22 GMT, Naoto Sato wrote:
>> lingjun-cg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 896: Performance regression of DecimalFormat.format
>> - 896: Performance regression of DecimalFormat.format
>
>
On Wed, 10 Jul 2024 22:08:47 GMT, Justin Lu wrote:
> Please review this PR, which is a backport of commit
> [86b0cf25](https://github.com/openjdk/jdk/commit/86b0cf259fb3cbe3a1973151148e5d36c6a99d91)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This change incorporates
On Wed, 10 Jul 2024 21:46:36 GMT, Justin Lu wrote:
> Please review this PR, which is a backport of commit
> [861aefca](https://github.com/openjdk/jdk/commit/861aefcafacdc21459ef966307f52568e327fd49)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This updates the IANA sub
On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote:
> Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and
> erroneous links in the doc files.
Confirmed identical to original PR.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk/
On Tue, 16 Jul 2024 16:54:09 GMT, Naoto Sato wrote:
>> Removing a redundant private method, which has the same implementation with
>> the public sibling and obsolete method description.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revisio
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished changes to java.
On Mon, 29 Jul 2024 15:49:10 GMT, Naoto Sato wrote:
> This fix is to address the tier_1 test run on Windows taking much longer time
> than before. The test case creates child processes that remain behind after
> the test run has completed, which is problematic on Windows as the make
> command
On Tue, 6 Aug 2024 00:50:48 GMT, Naoto Sato wrote:
> Fixing a regression caused by the removal of the legacy locale data. Legacy
> locale data happened to have resource bundle for "he" language (new ISO code)
> with the launguage name for "iw" (old ISO code). CLDR does not have it, thus
> the
On Tue, 27 Aug 2024 10:42:08 GMT, Per Minborg wrote:
> This trivial PR proposes to fix a typo in the `MemorySegment` docs.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20727#pullrequestreview-2263509002
On Thu, 29 Sep 2022 15:01:25 GMT, Roger Riggs wrote:
> Correct javadoc links and references.
>
> The links should refer to the method `()` instead of field.
>
> The apiNote in `getErrorStream` should refer to the error stream not the
> input stream and reader.
Marked as reviewed by iris (Revi
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated th
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/
On Wed, 5 Oct 2022 22:17:26 GMT, Justin Lu wrote:
> Problem: Unused variables in GregorianCalendar, JapaneseImperialCalendar, and
> Base Calendar.
>
> Fix: Removed all unused variables in bug description except normalizedYear in
> JapaneseImpericalCalendar.getActualMaximum.() as there was no m
On Tue, 11 Oct 2022 15:48:56 GMT, Raffaello Giulietti
wrote:
> Simple doc correction.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10658
On Tue, 11 Oct 2022 17:11:49 GMT, Pavel Rappo wrote:
> Please review this utmost trivial fix for an issue discovered while working
> on something else in jdk.javadoc. As far as I can see, this is the only case
> of `{@inheritDoc}` not being the sole content of a `@throws` description in
> JDK.
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote:
> Fixed to utilize `StaticProperty` so that the system property value for
> `java.locale.useOldISOCodes` set on the command line is honored even with
> lazy `Locale` initialization.
Marked as reviewed by iris (Reviewer).
-
PR: h
On Mon, 17 Oct 2022 23:34:22 GMT, Justin Lu wrote:
>> test/jdk/java/util/Formatter/Basic.java line 93:
>>
>>> 91:+ fail + " failure(s), first",
>>> first);
>>> 92: else
>>> 93: System.out.println("all " + (fail + pass) + " tests
>>> p
On Wed, 19 Oct 2022 19:04:57 GMT, Naoto Sato wrote:
> This is a regression caused by upgrading CLDR to version 39 (JDK-8258794), in
> which CLDR changed the locale inheritance for Norwegian. Some locale data
> (including number elements) that were in `nn` locale was moved to `no`. There
> was
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
Marked as reviewed by iris (Review
On Wed, 16 Nov 2022 19:07:48 GMT, Naoto Sato wrote:
> Adding a `@sealedGraph` tag to `ZoneId` class.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11195
On Mon, 28 Nov 2022 16:52:09 GMT, Weibing Xiao wrote:
> fix the illegal characters of directory names in Windows
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11393
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote:
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10924
On Thu, 1 Dec 2022 18:53:38 GMT, Joe Darcy wrote:
>> Usual start-of-release updates. Symbol updates in initial version reflect
>> JDK 20 build 21.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated change
On Tue, 6 Dec 2022 17:05:16 GMT, Joe Darcy wrote:
>> Usual start-of-release updates. Symbol updates in initial version reflect
>> JDK 20 build 21.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 19 commits:
>
> - Me
On Mon, 12 Dec 2022 19:51:22 GMT, Brent Christian wrote:
> Backport [8295857](https://bugs.openjdk.org/browse/JDK-8295857) to jdk20
Changes appear to be identical to those in JDK 21.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.org/jdk20/pull/19
On Fri, 16 Dec 2022 21:02:21 GMT, Daniel D. Daugherty
wrote:
> A batch a trivial fixes to ProblemList tests:
> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList
> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64
> [JDK-8298977](https://bugs.openjdk.org/
On Mon, 19 Dec 2022 22:20:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to slightly increase the default timeout so that
> java/lang/reflect/IllegalArgumentsTest.java
> passes with slowdebug bits.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk20/pul
/IllegalArgumentsTest.java
times out with slowdebug bits
On Mon, 19 Dec 2022 22:34:00 GMT, Iris Clark wrote:
>> A trivial fix to slightly increase the default timeout so that
>> java/lang/reflect/IllegalArgumentsTest.java
>> passes with slowdebug bits.
>
> Marked as re
On Mon, 19 Dec 2022 22:20:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to slightly increase the default timeout so that
> java/lang/reflect/IllegalArgumentsTest.java
> passes with slowdebug bits.
Trivial update approved.
-
Marked as reviewed by iris (Reviewer).
PR: https:/
On Wed, 4 Jan 2023 19:57:56 GMT, Naoto Sato wrote:
> This is a pre-requisite fix for upgrading CLDR to v43. The upcoming CLDR
> changed the inheritance mechanism a bit with this change:
> https://unicode-org.atlassian.net/browse/CLDR-15054 where they removed the
> duplication of data. This rev
On Wed, 4 Jan 2023 21:04:08 GMT, Naoto Sato wrote:
>> This is a pre-requisite fix for upgrading CLDR to v43. The upcoming CLDR
>> changed the inheritance mechanism a bit with this change:
>> https://unicode-org.atlassian.net/browse/CLDR-15054 where they removed the
>> duplication of data. This
On Wed, 4 Jan 2023 21:48:26 GMT, Justin Lu wrote:
> Added the missing copyright header
Provided GPL license appear to match the standard template available here:
https://github.com/openjdk/jdk/blob/master/make/data/license-templates/gpl-header
-
Marked as reviewed by iris (Reviewe
On Thu, 5 Jan 2023 20:45:20 GMT, Mandy Chung wrote:
> Trivial fix. Fix `Invokers.checkExactType` to call
> `newWrongMethodTypeException(actual, expected)` with parameters in right
> order.
Parameter order for method invocation now matches method declaration on line
521.
-
Marke
On Fri, 6 Jan 2023 06:35:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes an issue in the javadoc
> text of the internal class IteratorSpliterator? This addresses the issue
> reported at https://bugs.openjdk.org/browse/JDK-8297306.
Marked as reviewed by iris
On Wed, 4 Jan 2023 21:49:18 GMT, Justin Lu wrote:
> Within _test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java_
>
> GregorianCalendar alone handles all the necessary imports, Calendar is not
> needed
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jd
On Tue, 10 Jan 2023 17:17:41 GMT, Naoto Sato wrote:
> Fixing the subject method to recover gracefully on a failed
> `ZoneRulesProvider` registration.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11928
On Wed, 11 Jan 2023 17:12:39 GMT, Justin Lu wrote:
> In [JDK-4368016](https://bugs.openjdk.org/browse/JDK-4368016)
> **TimeZone.setDefaultZone()** was updated so that
>
> _TimeZone.java [will] not cause an NPE. If getSystemTimeZoneID()
> can't determine the time zone from java.home and user.re
On Thu, 12 Jan 2023 22:31:24 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.ChoiceFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/ChoiceFormat.html).
>
> Code examples using ... blocks are replaced
On Fri, 13 Jan 2023 17:45:51 GMT, Justin Lu wrote:
>> This PR implements JEP 413: Code Snippets in Java API Documentation for
>> _[java.util.TimeZone](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/TimeZone.html)_.
>>
>> Code examples using ... blocks are replaced wit
On Fri, 13 Jan 2023 21:47:40 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.MessageFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/class-use/MessageFormat.html).
>
> Code examples using ... blocks a
On Fri, 13 Jan 2023 21:53:50 GMT, Justin Lu wrote:
> This pull request contains a backport of commit
> [cd10c727](https://github.com/openjdk/jdk/commit/cd10c7278d8fcf7ce6713a3ee688bb1e10c024f6)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported wa
On Tue, 17 Jan 2023 21:29:15 GMT, Joe Darcy wrote:
> In the course of some other work (JDK-8300133), I noticed some cases where
> the javadoc in the package-info file for javax.sql.rowset used HTML links
> where a more readable javadoc link tag would suffice.
Marked as reviewed by iris (Review
On Tue, 17 Jan 2023 22:35:54 GMT, Justin Lu wrote:
> This PR implements JEP 413: Code Snippets in Java API Documentation for
> [java.text.DateFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/DateFormat.html).
>
> Code examples using ... blocks are replaced with t
On Wed, 18 Jan 2023 19:36:51 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.Collator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/Collator.html).
>
> Code examples using ... blocks are replaced with the
On Wed, 18 Jan 2023 20:43:37 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/Collator.java line 83:
>>
>>> 81: * System.out.println("abc is greater than or equal to ABC");
>>> 82: * }
>>> 83: * }
>>
>> I don't think you need a second '}' here.
>
> The first `}` is for clos
On Fri, 20 Jan 2023 17:31:26 GMT, Justin Lu wrote:
>> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
>> [java.text.CollationKey](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CollationKey.html)
>> and
>> [java.text.CompactNumberFormat](https:
On Mon, 23 Jan 2023 02:59:42 GMT, David Holmes wrote:
> There was one missing update in javac.1 from:
>
> [JDK-8245246](https://bugs.openjdk.org/browse/JDK-8245246): Deprecate
> -profile option in javac
>
> otherwise the change is limited to dropping the "-ea".
>
> Thanks.
Marked as reviewed
On Mon, 23 Jan 2023 14:59:08 GMT, Per Minborg wrote:
> This PR fixes a couple of typos in the documentation.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12142
On Mon, 23 Jan 2023 13:53:38 GMT, Per Minborg wrote:
> Some variables are declared using old-style declarations. These should be
> modified to conform to modern style.
>
> This is a task derived from https://github.com/openjdk/jdk/pull/11848
Marked as reviewed by iris (Reviewer).
---
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
Marked as reviewed by iris (Reviewer).
-
On Wed, 1 Mar 2023 00:24:31 GMT, Justin Lu wrote:
> The following typo: `@returnss` was reported on line _482 of Reflection
> Factory.java_.
>
> In addition to fixing that, I have replaced multiple instances of `@returns`
> with `@return` in the same file.
Marked as reviewed by iris (Reviewer
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote:
>> This is a pre-requisite for supporting CLDR v43, where they combine `seeds`
>> locales with `common` locales
>> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order
>> to have the same coverage level of locales, CLDRC
On Fri, 3 Mar 2023 21:10:57 GMT, Naoto Sato wrote:
>> This change is to fix a regression caused by the fix to
>> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix
>> was simply disabling offset-based parsing if the parser was text-based.
>> Instead, check if it is an
On Fri, 24 Mar 2023 17:56:03 GMT, Ian Graves wrote:
> Updating copyright headers on some files missed in a previous commit
Confirmed all files listed in 8304691 save the deleted
JLinkPostProcessingTest.java now have updated copyright year.
-
Marked as reviewed by iris (Reviewer).
On Tue, 28 Mar 2023 18:25:21 GMT, Naoto Sato wrote:
> Fixing a documentation bug for `CharacterCodingException` without any
> description to it as attached. A corresponding CSR is also drafted.
>
> ![Screenshot 2023-03-28 at 11 19 00
> AM](https://user-images.githubusercontent.com/3122603/2283
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png";>
>
> After:
> src="https:/
On Wed, 29 Mar 2023 22:51:12 GMT, Justin Lu wrote:
> Small typo fix in Locale.lookupTag
>
> _tangs_ should be _tags_
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13235#pullrequestreview-1364106018
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Fri, 31 Mar 2023 22:07:26 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Sat, 1 Apr 2023 18:08:44 GMT, Joe Darcy wrote:
> This PR is a redo of JDK-8302801: Remove fdlibm C sources. The problem with
> JDK-8302801 was that it neglected (mea culpa) to include a Java
> implementation of IEEEremainder before the FDLIBM C implementation was
> deleted. Such an implemen
On Mon, 3 Apr 2023 22:58:30 GMT, Naoto Sato wrote:
> Introducing new regex constructs that match those 6 new Unicode Emoji
> properties implemented in the `Character` class
> (https://bugs.openjdk.org/browse/JDK-8303018). A corresponding CSR has been
> drafted.
Associated CSR also Reviewed.
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote:
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets
On Wed, 5 Apr 2023 15:48:02 GMT, Roger Riggs wrote:
>> With the addition of `jdk.internal.util.OperatingSystem` references to the
>> system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>> - java.prefs,
>> - java.security.jgss,
>> - java.smartcardio,
>> - jdk.c
On Wed, 5 Apr 2023 14:48:52 GMT, Viktor Klang wrote:
> a -> an
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13353#pullrequestreview-1373292633
On Sat, 8 Apr 2023 05:37:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc only change which fixes a trivial typo
> in the documentation of `ObjectOutputStream.replaceObject()` method, as noted
> in https://bugs.openjdk.org/browse/JDK-6441827?
Marked as reviewed by iris (Revi
On Sat, 8 Apr 2023 13:00:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc only change which fixes a trivial typo
>> in the documentation of `ObjectOutputStream.replaceObject()` method, as
>> noted in https://bugs.openjdk.org/browse/JDK-6441827?
>
> Jaikiran Pai has updated t
On Mon, 10 Apr 2023 18:24:08 GMT, Mandy Chung wrote:
> `s/ConstantBootstraps.staticVarHandle/ConstantBootstraps.staticFieldVarHandle`
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13411#pullrequestreview-1377951955
On Mon, 10 Apr 2023 17:58:00 GMT, Chen Liang wrote:
> Please review a small patch, fixing extraneous right braces in field javadocs
> of BSM_EXPLICIT_CAST, BSM_CLASS_DATA, and BSM_CLASS_DATA_AT.
>
> JDK 20:
> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/Const
On Fri, 14 Apr 2023 14:34:39 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the `java.compiler`
>> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676.
>>
>> A CSR has been filed for this change and is available at
>> https://bugs.ope
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.2.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersion
On Tue, 18 Apr 2023 18:40:03 GMT, Naoto Sato wrote:
> The upgrade to CLDR v43 was missing the license-related file updates. Here
> are the supplemental updates.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13517#pullrequestreview-1390801345
On Thu, 20 Apr 2023 06:32:41 GMT, Justin Lu wrote:
> Small cleanup / tweak spotted in Calendar to improve readability.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13554#pullrequestreview-1394591566
On Wed, 26 Apr 2023 20:42:01 GMT, Naoto Sato wrote:
> Updating the collation rules for Swedish to the modern one, which is aligned
> with the CLDR's default collation rules. Since it is changing the existing
> behavior, a release note has also been drafted:
> https://bugs.openjdk.org/browse/JD
On Thu, 18 May 2023 16:42:23 GMT, Naoto Sato wrote:
>> This change intends to interpret the BCP47 U extension wrt collation
>> settings in the given `Locale`, then applies them to the created instances
>> in the 1-arg factory method in `Collator`. A corresponding CSR has also been
>> drafted.
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote:
> Time to get JDK 22 underway...
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13567#pullrequestreview-1440582657
On Wed, 24 May 2023 23:32:18 GMT, Pavel Rappo wrote:
> Please review this simple fix.
Looks good. (I'm not sure I'd characterize this as a "typo", more like a
failure to adjust "cut and paste" replication. Regardless you're fixing an
error.)
-
Marked as reviewed by iris (Review
On Thu, 16 Jun 2022 21:21:36 GMT, Joe Darcy wrote:
> Whatever the motivation for how this method was coded when added in JDK 8,
> since Executable is now a sealed class with Constructor and Method the only
> allowed subclasses, getParameterCount can be coded as an normal abstract
> method. (Th
On Thu, 16 Jun 2022 22:21:23 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8286287](https://bugs.openjdk.org/browse/JDK-8286287), which assumed the
> method `String.decodeWithDecoder()` was only invoked with cs.REPLACE mode
> based on the comment "should not happen"
On Tue, 21 Jun 2022 16:52:52 GMT, Joe Wang wrote:
> Some of the links cause redirection, iso.org in particular took 1-2 seconds,
> that looks like was longer than the wait time of the doccheck and docs link
> checker. Changed it to the current homepage to avoid redirection. Also
> changed othe
On Mon, 13 Jun 2022 22:58:43 GMT, Naoto Sato wrote:
>> As the name suggests, `COMPAT` locale provider keeps compatibility with
>> JDK8's locale data (before CLDR). This is useful for legacy applications,
>> but some of its data got obsolete for later locale data updates, such as the
>> countr
On Wed, 22 Jun 2022 21:48:35 GMT, Joe Wang wrote:
>> Fix a regression in Document.normalizeDocument() caused by a change in JDK
>> 10.
>>
>> Test: new test (as in the bug report) and Tier2 passed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the la
V5N9M2RV99hQ!JWTXtcOlxAlKs1OamoE2hbweIBcqRBtUZoAQmPyrENX5-6Dr9ygPxqGcpC9F_ATb8jBkILMiisolDKuTAoQu$
> ) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Naoto Sato on 23 Jun 2022 and was
> reviewed by Roger Riggs, Iris Clark and Alan Bateman.
>
> Thanks!
On Fri, 17 Jun 2022 08:43:00 GMT, Andrey Turbanov wrote:
> Fields `STARTTIME_ANY` and `STARTTIME_PROCESS_UNKNOWN` are actually unused,
> but they are useful as documentation on the interface to native.
> Make them `static` to reduce memory usage.
Marked as reviewed by iris (Reviewer).
On Thu, 30 Jun 2022 22:05:38 GMT, Naoto Sato wrote:
> Trivial fix to currency data files. The change was only made to its amendment
> number, as the new Sierra Leone currency has already been active with
> amendment 171.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.op
On Tue, 5 Jul 2022 18:38:57 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR cleans up `VersionProps::print` removing the unused parameter `newln`.
>
> Mach5 tiers1-3 are currently running.
>
> Best,
> Lance
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jd
On Wed, 6 Jul 2022 00:32:00 GMT, Stuart Marks wrote:
> Simple javadoc fix of an editorial nature.
Marked as reviewed by iris (Reviewer).
src/java.base/share/classes/java/util/Map.java line 740:
> 738: * @param function the function to apply to each entry
> 739: * @throws UnsupportedO
On Wed, 6 Jul 2022 23:03:42 GMT, Stuart Marks wrote:
>> Simple javadoc fix of an editorial nature.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflow and adjust whitespace per Alan's & Iris' comments.
Marked as reviewe
On Thu, 7 Jul 2022 06:06:42 GMT, Stuart Marks wrote:
> Minor doc wording changes, to be consistent with HashSet.newHashSet et. al.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/118
On Fri, 8 Jul 2022 18:23:05 GMT, Joe Wang wrote:
> Update module-info
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/126
1 - 100 of 308 matches
Mail list logo
