This is an approach to adding a flag to jlink that will allow --compress to
take the same types of arguments as jmod, thus bringing the two into alignment.
This likely requires a CSR and a discussion on whether we should deprecate or
simply remove the original numeric compression arguments.
---
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Swapping deprecations in properties
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/fi
On Thu, 15 Dec 2022 06:43:40 GMT, Jaikiran Pai wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Swapping deprecations in properties
>
> src/jdk.jlink/share/classes/jd
On Thu, 15 Dec 2022 06:45:22 GMT, Jaikiran Pai wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Swapping deprecations in properties
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/i
compression arguments.
Ian Graves has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains four additional commits since
the last revision:
- Merge remote-tra
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Adding test for new plugin
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/files/9c03c6
On Thu, 15 Dec 2022 07:22:49 GMT, Jaikiran Pai wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Swapping deprecations in properties
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/in
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Adding plugin type to force compact strings vs zip ordering
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Fixing up resources
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/files/06f4b3c3..2af25
On Tue, 14 Feb 2023 20:20:03 GMT, Mandy Chung wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing up resources
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/C
On Wed, 15 Feb 2023 18:23:02 GMT, Mandy Chung wrote:
>> I think that deprecating the entire plugin could be appropriate, given the
>> overhead, unless there's some performance data to the contrary. I haven't
>> seen much in favor of keeping it, but I do think that breaking it apart from
>> zip
compression arguments.
Ian Graves has updated the pull request incrementally with three additional
commits since the last revision:
- Removing string compression plugin
- Fixing errant compact-constant-pools
- ShareUTF8Entries update
-
Changes:
- all: https://git.openjdk.org/jdk/pull
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Updating properties
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/files/92416003..c9f4f
On Thu, 16 Feb 2023 19:08:39 GMT, Mandy Chung wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating properties
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePlugi
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Additional updates
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/files/c9f4f32b..a9a4d
On Mon, 9 Jan 2023 21:38:59 GMT, Mandy Chung wrote:
>> I skimmed through this (not a detailed review) and I think it's mostly okay.
>> It's --compress 0 and 2 that should be listed as deprecated as --compress 1
>> is string sharing rather than zip compression.
>
>> I skimmed through this (not a
On Wed, 8 Feb 2023 13:27:09 GMT, Jaikiran Pai wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding plugin type to force compact strings vs zip ordering
>
> src/jdk.jlink/share/cl
On Thu, 16 Feb 2023 23:04:30 GMT, Mandy Chung wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Additional updates
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/Default
On Fri, 17 Feb 2023 02:12:41 GMT, Mandy Chung wrote:
>> Thanks. I note that there is a non-localized warning done this way elsewhere
>> in jlink. May need to make a bug to localize this.
>
> I prefer this one should use the localized message. The other ones should be
> followed up in a separat
On Thu, 16 Feb 2023 22:50:25 GMT, Mandy Chung wrote:
>> I think, there's also a typo in the next line:
>>
>> checkCompress(classes, compressPlugin,
>>
>> should have been:
>>
>> checkCompress(classes, compressPluginZip0,
>>
>> I haven't yet looked at the existing test code in `checkCompress`
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Updates per feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/files/a9a4d4f0..b2c44
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Adding runtime testing of new compression args
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull
On Wed, 22 Feb 2023 19:39:28 GMT, Ian Graves wrote:
>> This is an approach to adding a flag to jlink that will allow --compress to
>> take the same types of arguments as jmod, thus bringing the two into
>> alignment. This likely requires a CSR and a discussion on
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Tweaking properties
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/files/74ec4f4b..b4339
On Thu, 23 Feb 2023 18:27:53 GMT, Mandy Chung wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweaking properties
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/Defa
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Tweaking warning messages and shortening them
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Additional cleanup
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/files/271eb254..186e0
compression arguments.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
s/from/in
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11617/files
- new: https://git.openjdk.org/jdk/pull/11617/files/186e0224..05841fb5
Webr
On Fri, 24 Feb 2023 03:52:31 GMT, Mandy Chung wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Additional cleanup
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.p
On Fri, 9 Dec 2022 21:42:15 GMT, Ian Graves wrote:
> This is an approach to adding a flag to jlink that will allow --compress to
> take the same types of arguments as jmod, thus bringing the two into
> alignment. This likely requires a CSR and a discussion on whether we should
>
Updates to the documentation to describe behavior in Matcher.group().
-
Commit messages:
- Updating verbiage
- Merge branch 'master' into matcher-group-doc-update
- 8217496 Matcher.group() can return null after usePattern
Changes: https://git.openjdk.org/jdk/pull/12835/files
Webr
On Thu, 2 Mar 2023 17:13:28 GMT, Ian Graves wrote:
> Updates to the documentation to describe behavior in Matcher.group().
This pull request has now been integrated.
Changeset: ac3ab5b0
Author: Ian Graves
URL:
https://git.openjdk.org/jdk/com
Removing the hidden `jlink --post-process-path` option.
-
Commit messages:
- Removing Post Processing functionality
Changes: https://git.openjdk.org/jdk/pull/13126/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13126&range=00
Issue: https://bugs.openjdk.org/browse/JDK-830
> Removing the hidden `jlink --post-process-path` option.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Updates per feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13126/files
- new: ht
On Wed, 22 Mar 2023 16:25:51 GMT, Ian Graves wrote:
>> Removing the hidden `jlink --post-process-path` option.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updates per feedback
Thanks! Upd
> Removing the hidden `jlink --post-process-path` option.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Removing leftover properties
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13126/files
- new: ht
On Wed, 22 Mar 2023 19:57:51 GMT, Mandy Chung wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing leftover properties
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Jlin
> Removing the hidden `jlink --post-process-path` option.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Removing post process opt reference
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13126/files
- new: ht
> Removing the hidden `jlink --post-process-path` option.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Removing last bits of post process test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13126/files
-
On Tue, 21 Mar 2023 20:39:38 GMT, Ian Graves wrote:
> Removing the hidden `jlink --post-process-path` option.
This pull request has now been integrated.
Changeset: af0504e3
Author: Ian Graves
URL:
https://git.openjdk.org/jdk/commit/af0504e3f3de4ba40fa6187e48b584854b8e41f3
St
Updating copyright headers on some files missed in a previous commit
-
Commit messages:
- 8304898: Fix Copyright Headers for JLink Source Files
Changes: https://git.openjdk.org/jdk/pull/13181/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13181&range=00
Issue: https://bug
On Fri, 24 Mar 2023 17:56:03 GMT, Ian Graves wrote:
> Updating copyright headers on some files missed in a previous commit
This pull request has now been integrated.
Changeset: 3f59b75b
Author: Ian Graves
URL:
https://git.openjdk.org/jdk/com
On Thu, 3 Aug 2023 12:34:19 GMT, Raffaello Giulietti
wrote:
>> Cristian Vat has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes and test for CIBackRef
>
> The change looks good.
> However, I'm not a Reviewer.
This looks good to me,
On Wed, 16 Aug 2023 09:11:34 GMT, Cristian Vat wrote:
>> Reduces excessive allocation of Matcher.groups array when the original
>> Pattern has no groups or less than 9 groups.
>>
>> Original clamping to 10 possibly due to documented behavior from javadoc:
>> "In this class, \1 through \9 are a
Adding ForceInline to helper methods.
-
Commit messages:
- Adding ForceInline to helper operations
Changes: https://git.openjdk.org/jdk/pull/24165/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24165&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8339543
Stats: 64
On Fri, 21 Mar 2025 17:38:53 GMT, Ian Graves wrote:
> Adding ForceInline to helper methods.
This pull request has now been integrated.
Changeset: 7d1fe0e0
Author: Ian Graves
URL:
https://git.openjdk.org/jdk/commit/7d1fe0e03fbdc73920094ff7905208a57dc4ee65
Stats: 64 lines in
Updating Javadoc for vector operators with VO_NOFP flags, but no corresponding
"Integral only." note in docs.
-
Commit messages:
- JDK-8351290: Clarify integral only for vector operators
Changes: https://git.openjdk.org/jdk/pull/24237/files
Webrev: https://webrevs.openjdk.org/?re
> Updating Javadoc for vector operators with VO_NOFP flags, but no
> corresponding "Integral only." note in docs.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Missing period
-
Changes:
- all: https:/
On Tue, 25 Mar 2025 20:44:31 GMT, Ian Graves wrote:
> Updating Javadoc for vector operators with VO_NOFP flags, but no
> corresponding "Integral only." note in docs.
This pull request has now been integrated.
Changeset: fe8bd756
Author:Ian Graves
URL:
https://git
On Sat, 31 May 2025 13:14:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes the problem listing
> entry for the `jdk/incubator/vector/PreferredSpeciesTest.java#id0` test which
> has been failing in our CI?
>
> tier1 testing with this change is currently in prog
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Fixin
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Twe
Removing incorrect assumptions and assertions from a breaking test related to
https://bugs.openjdk.org/browse/JDK-8358218
-
Commit messages:
- Removing incorrect assumptions from test
Changes: https://git.openjdk.org/jdk/pull/25565/files
Webrev: https://webrevs.openjdk.org/?repo=
On Sat, 31 May 2025 16:18:59 GMT, Ian Graves wrote:
> Removing incorrect assumptions and assertions from a breaking test related to
> https://bugs.openjdk.org/browse/JDK-8358218
The original test made an incorrect assumption about *MaxVector sizes that
doesn't hold across every pl
> Removing incorrect assumptions and assertions from a breaking test related to
> https://bugs.openjdk.org/browse/JDK-8358218
Ian Graves has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge remote-tracking
On Sat, 31 May 2025 16:18:59 GMT, Ian Graves wrote:
> Removing incorrect assumptions and assertions from a breaking test related to
> https://bugs.openjdk.org/browse/JDK-8358218
This pull request has now been integrated.
Changeset: 901144ee
Author: Ian Graves
URL:
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Adding test
On Thu, 29 May 2025 21:52:30 GMT, Ian Graves wrote:
>> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
>> package-private. This propose change makes it public and adds documentation
>> for it.
>
> Ian Graves has updated the pull reques
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Updating c
On Wed, 28 May 2025 21:22:30 GMT, Ian Graves wrote:
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
This pull request has now been integrated.
Changeset: 09301c
VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
package-private. This propose change makes it public and adds documentation for
it.
-
Commit messages:
- Making VectorShape.largestShapeFor public and documenting
Changes: https://git.openjdk.org/jdk/pull/2
> Adding SUADD an associative operation in the Vector API. Saturated addition
> on fixed-width unsigned integers is provably associative.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Adding masked associative
On Fri, 11 Jul 2025 03:45:14 GMT, Xiaohong Gong wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding masked associative tests
>
> src/jdk.incubator.vector/share/classes/jdk/incubat
Adding SUADD an associative operation in the Vector API. Saturated addition on
fixed-width unsigned integers is provably associative.
-
Commit messages:
- Adding associative support for SUADD and associated tests
Changes: https://git.openjdk.org/jdk/pull/26099/files
Webrev: https
> Adding SUADD an associative operation in the Vector API. Saturated addition
> on fixed-width unsigned integers is provably associative.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Cleaning up test cases
-
C
> Adding SUADD an associative operation in the Vector API. Saturated addition
> on fixed-width unsigned integers is provably associative.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Condensing test data
-
C
On Tue, 15 Jul 2025 15:41:59 GMT, Quan Anh Mai wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Condensing test data
>
> I believe this is inadequate, an `Associative` will allow reduc
On Wed, 2 Jul 2025 16:47:36 GMT, Ian Graves wrote:
> Adding SUADD an associative operation in the Vector API. Saturated addition
> on fixed-width unsigned integers is provably associative.
This pull request has now been integrated.
Changeset: b65fdf5a
Author: Ian Graves
URL:
68 matches
Mail list logo
