le. The value of the `id` attribute uses the format
> `contents-`.
>
> There is one additional CSS class called `preview-feature-list` used for the
> list of preview feature JEPs.
>
> Demo output for the new preview page as well as other pages is available here:
&g
On Thu, 29 Sep 2022 20:12:43 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix URL in test
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/
On Thu, 29 Sep 2022 21:21:44 GMT, Jonathan Gibbons wrote:
> Approved, with a question...
>
> Looking at the generated output, would it be better to prefix theJEP numbers
> in the initial list of checkboxes with the word `JEP` ?
That format was suggested by Alex as it is the one used in other p
On Thu, 30 Jun 2022 15:14:40 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to the preview page to add a list of preview
> features and allow users to explore the preview APIs by feature.
>
> While the changes for the enhancement itself are not overly compl
Please review a simple change to hide internal classes in generated
documentation by adding doc comments containing a `@hidden` tag. I verified the
fix by making sure `grep -r jdk.internal` returns no matches in the generated
documentation tree.
-
Commit messages:
- JDK-8277074: Q
This `noreg-doc` PR has been moved over from the mainline repository, the
original PR is openjdk/jdk#11163.
The purpose is to hide internal classes in generated documentation by adding
doc comments containing a @hidden tag. I verified the fix by making sure the
internal vector and event classe
On Mon, 19 Dec 2022 16:28:17 GMT, Hannes Wallnöfer wrote:
> This `noreg-doc` PR has been moved over from the mainline repository, the
> original PR is openjdk/jdk#11163.
>
> The purpose is to hide internal classes in generated documentation by adding
> doc comments containin
On Tue, 15 Nov 2022 12:15:42 GMT, Hannes Wallnöfer wrote:
> Please review a simple change to hide internal classes in generated
> documentation by adding doc comments containing a `@hidden` tag. I verified
> the fix by making sure `grep -r jdk.internal` returns no matches in the
&g
Please review an enhancement to the preview page to add a list of preview
features and allow users to explore the preview APIs by feature.
While the changes for the enhancement itself are not overly complex, the work
entailed a moderate cleanup of other summary API lists (Deprecated and New API
On Tue, 12 Jul 2022 17:04:40 GMT, Jonathan Gibbons wrote:
>> Please review a moderately simple fix to clean up (as in _remove_!)
>> `CommentHelper.getText` and friends/overloads.
>>
>> This is moderately simple, because most of the heavy lifting was done in
>> [JDK-8288699](https://bugs.openjd
le. The value of the `id` attribute uses the format
> `contents-`.
>
> There is one additional CSS class called `preview-feature-list` used for the
> list of preview feature JEPs.
>
> Demo output for the new preview page as well as other pages is available here:
> http://cr.op
On Thu, 18 Aug 2022 21:42:04 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' into JDK-8287597
&
le. The value of the `id` attribute uses the format
> `contents-`.
>
> There is one additional CSS class called `preview-feature-list` used for the
> list of preview feature JEPs.
>
> Demo output for the new preview page as well as other pages is available here:
> http://cr.op
On Thu, 22 Sep 2022 17:16:55 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to the preview page to add a list of preview
>> features and allow users to explore the preview APIs by feature.
>>
>> While the changes for the enhancement itself are not over
le. The value of the `id` attribute uses the format
> `contents-`.
>
> There is one additional CSS class called `preview-feature-list` used for the
> list of preview feature JEPs.
>
> Demo output for the new preview page as well as other pages is available here:
> http
This change fixes two errors in inline HTML styles in the `java.lang` package:
- wrong CSS property name in `java.lang.String`
- CSS declaration terminated by colon instead of semicolon in
`java.lang.Thread`
Both errors caused the style declarations to be ignored and an error message to
be
ons to be ignored and an error message
> to be shown in the browser console.
>
> The bug is `noreg-doc`, I tested the docs in the browser to make sure the
> error message is gone and the HTML displays as intended.
Hannes Wallnöfer has updated the pull request incrementally with o
On Wed, 25 Oct 2023 09:04:37 GMT, Jaikiran Pai wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Find and fix more invalid CSS declarations
>
> Hello Hannes, the changes look fin
On Wed, 25 Oct 2023 09:09:07 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 192:
>>
>>> 190: * with the following system properties:
>>> 191: *
>>> 192: * System properties
>>
>> Just out of curiosity, is that semi-colon even needed, or would
>> `display
On Thu, 2 Nov 2023 10:57:15 GMT, Hannes Wallnöfer wrote:
>> This change fixes two errors in inline HTML styles in the `java.lang`
>> package:
>>
>> - wrong CSS property name in `java.lang.String`
>> - CSS declaration terminated by colon instead of semi
On Fri, 15 Sep 2023 13:56:21 GMT, Hannes Wallnöfer wrote:
> This change fixes two errors in inline HTML styles in the `java.lang`
> package:
>
> - wrong CSS property name in `java.lang.String`
> - CSS declaration terminated by colon instead of semicolon in
> `java.lang
Please review a simple change to remove a stray inline CSS element from the
Collection Framework index doc file. The only thing the `a {font-weight:
bold;}` rule did was to make all links in the header and footer bold as [can be
seen here][1]; the three content links to the other doc files are s
On Wed, 6 Dec 2023 16:22:24 GMT, Hannes Wallnöfer wrote:
> Please review a simple change to remove a stray inline CSS element from the
> Collection Framework index doc file. The only thing the `a {font-weight:
> bold;}` rule did was to make all links in the header and footer bold as [
Please review a change to fix JavaDoc references using a nested class instead
of the enclosing class containing the target method. Until now this is accepted
by JavaDoc (with the correct link being created). With
[JDK-8164094](https://bugs.openjdk.org/browse/JDK-8164094) these references are
re
orted as errors.
>
> I made sure the rendered documentation is identical before and after the
> change (JavaDoc previously generated the correct links for these references).
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 12 Dec 2023 09:46:29 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change for JavaDoc references using a nested class
> instead of the enclosing class containing the target method. Until now this
> is accepted by JavaDoc, but with
> [JDK-8164094](https://bugs
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote:
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote:
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote:
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in
On Wed, 24 Apr 2024 14:10:29 GMT, Nizar Benalla wrote:
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in
On Fri, 4 Oct 2024 16:32:50 GMT, Pavel Rappo wrote:
>> test/langtools/jdk/javadoc/doclet/testRestricted/TestRestricted.java line 45:
>>
>>> 43: public static void main(String... args) throws Exception {
>>> 44: var tester = new TestRestricted();
>>> 45: tester.setAutomaticChe
On Tue, 24 Sep 2024 14:56:19 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas
On Fri, 4 Oct 2024 17:17:53 GMT, Joe Darcy wrote:
> Fix broken links.
I hadn't caught the use of the plural form anchor in `Types.java`. Looks good.
-
Marked as reviewed by hannesw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21360#pullrequestreview-2348949061
On Fri, 4 Oct 2024 19:07:54 GMT, Joe Darcy wrote:
>> Please review a doc change to fix the target anchor for the "wrapper class"
>> links added in #21215.
>>
>> In addition to changing the anchor to "wrapperClass" (singular) I also moved
>> the id attribute to the `` tag so that browser view
On Fri, 4 Oct 2024 17:37:09 GMT, Hannes Wallnöfer wrote:
> Please review a doc change to fix the target anchor for the "wrapper class"
> links added in #21215.
>
> In addition to changing the anchor to "wrapperClass" (singular) I also moved
> the id attr
On Mon, 30 Sep 2024 02:07:08 GMT, Joe Darcy wrote:
>> `` is a semantic tag to indicate the defining instance of a term. It
>> may be used by search engines, to improve their results. When `` is
>> used as intended, it may be reasonable and convenient to put an `id` on the
>> tag, to provide
On Tue, 24 Sep 2024 14:56:19 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas
On Mon, 21 Oct 2024 13:45:47 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc `@param` tags in
> module java.base.
>
> We are working on a javadoc feature to add an opt-in doclint warning for
> `@param` tags that don't match the or
On Mon, 21 Oct 2024 13:45:47 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc `@param` tags in
> module java.base.
>
> We are working on a javadoc feature to add an opt-in doclint warning for
> `@param` tags that don't match the or
Please review a doc-only change to fix the order of javadoc `@param` tags in
module java.base.
We are working on a javadoc feature to add an opt-in doclint warning for
`@param` tags that don't match the order of parameters in the documented
element. The warning will be enabled in OpenJDK builds
Please review a doc change to fix the target anchor for the "wrapper class"
links added in #21215.
In addition to changing the anchor to "wrapperClass" (singular) I also moved
the id attribute to the `` tag so that browser view is positioned over the
whole paragraph instead of just the term "w
On Tue, 22 Oct 2024 15:05:05 GMT, Jaikiran Pai wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc feature to
On Tue, 22 Oct 2024 14:12:11 GMT, Daniel Fuchs wrote:
> Changes to java.management, java.naming, and sctp look good to me.
Thanks @dfuch, setting reviewers to 2 for changes in the the remaining modules.
-
PR Comment: https://git.openjdk.org/jdk/pull/21637#issuecomment-2429782605
Please review a doc-only change to fix the order of javadoc @param tags in in
various OpenJDK modules. This is the third and last PR to fix the order of
@param tags in OpenJDK libraries.
We are working on a javadoc feature to add an opt-in doclint warning for @param
tags that don't match the or
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>&g
On Tue, 22 Oct 2024 13:36:43 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc @param tags in in
> various OpenJDK modules. This is the third and last PR to fix the order of
> @param tags in OpenJDK libraries.
>
> We are working on a jav
d API docs built with this branch with API docs built
> from master branch to make sure they are identical.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Fix copyright header
-
Changes:
- all: https://git.openjd
On Thu, 24 Oct 2024 11:39:33 GMT, Jaikiran Pai wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix copyright header
>
> src/java.xml/share/classes/javax/xml/validation/Schema
On Mon, 30 Sep 2024 11:41:19 GMT, Pavel Rappo wrote:
>> Adding the `id` attribute to the `dfn` tag is an improvement over the `> name=...>` tag, but the embedded `{@index ...}` tag already generates a
>> `span` tag with a very similar id derived from the tag content, in this case
>> `id="wrappe
On Fri, 20 Dec 2024 10:21:17 GMT, Nizar Benalla wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [2a68f741](https://github.com/openjdk/jdk/commit/2a68f741884e73c9ed8e5222e57f5ecb088b3cf7)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit be
On Mon, 18 Nov 2024 17:06:03 GMT, Nizar Benalla wrote:
> Can I get a review for this test only change to the Since Checker?
>
> I drop the distinction between classes and interfaces when generating ids and
> use a generic name "class" to describe both, as to not consider classes that
> get con
Please review a doc-only change to add missing `@serial` javadoc tags in module
`java.base`. This is a sub-task of [JDK-8286931] to allow us to re-enable the
javadoc `-serialwarn` option in the JDK doc build, which has been disabled
since JDK 19.
[JDK-8286931]: https://bugs.openjdk.org/browse/J
On Tue, 21 Jan 2025 19:41:39 GMT, Phil Race wrote:
>> Please review a doc-only change to mostly add missing `@serial` javadoc
>> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the
>> javadoc `-serialwarn` option in the JDK doc build, which has been disabled
>> since JDK 19.
On Wed, 22 Jan 2025 20:35:22 GMT, Phil Race wrote:
>> Only the `writeExternal` method is required to have a `@serialData` tag in
>> order to keep javadoc running with `-serialwarn` option from complaining. I
>> guess the thinking is that the `readExternal` logic can be derived from that.
>>
>>
On Thu, 23 Jan 2025 16:16:03 GMT, Hannes Wallnöfer wrote:
>> There's not a great number of "good" examples of this in the JDK, so
>> probably OK except it
>> seems like most cases will do it like a normal javadoc method so you'd want
>> an @param ta
e in this
> PR that adds documentation text and causes a change in the generated
> documentation.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Update @serialData text to CSR-approved version
-
Changes:
- a
Please review a doc-only change to mostly add missing `@serial` javadoc tags.
This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc
`-serialwarn` option in the JDK doc build, which has been disabled since JDK 19.
[JDK-8286931]: https://bugs.openjdk.org/browse/JDK-8286931
For
On Wed, 8 Jan 2025 19:41:42 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to add missing `@serial` javadoc tags in
> module `java.base`. This is a sub-task of [JDK-8286931] to allow us to
> re-enable the javadoc `-serialwarn` option in the JDK doc build, which ha
ag in interfaces,
> which was previously missing, and adds coverage to `TestHiddenTag.java`.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Review feedback: add Utils.isVisible(TypeElement) method
-
Changes:
- all:
On Sat, 5 Apr 2025 00:35:35 GMT, Chen Liang wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review feedback: add Utils.isVisible(TypeElement) method
>
> src/jdk.javadoc/shar
On Fri, 4 Apr 2025 13:36:19 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to treat classes and interfaces that are not
> included and not unconditionally exported as hidden. This means they do not
> show up in the generated documentation even if they are imple
On Wed, 8 Jan 2025 20:13:50 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to mostly add missing `@serial` javadoc tags.
> This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc
> `-serialwarn` option in the JDK doc build, which has been disabled
Please review an enhancement to make `DocCommentParser` normalize whitespace
inside `` elements. The normalization is conceptually simple and and
intended to be minimally invasive. Before parsing, `DocCommentParser` checks
whether the text is a traditional doc comment and whether every line star
pt
> operation is indiscernible and it solves the problem.
>
> [1]: https://html.spec.whatwg.org/#the-pre-element:the-pre-element
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Remove script for normalizing leading space
On Thu, 6 Mar 2025 05:18:26 GMT, Hannes Wallnöfer wrote:
>> Please review an enhancement to make `DocCommentParser` normalize whitespace
>> inside `` elements. The normalization is conceptually simple and and
>> intended to be minimally invasive. Before parsing, `DocCom
pt
> operation is indiscernible and it solves the problem.
>
> [1]: https://html.spec.whatwg.org/#the-pre-element:the-pre-element
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Fix comment
-
Changes:
-
pt
> operation is indiscernible and it solves the problem.
>
> [1]: https://html.spec.whatwg.org/#the-pre-element:the-pre-element
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Switch to post-processing approach that fix
On Wed, 5 Mar 2025 18:07:11 GMT, Jonathan Gibbons wrote:
>> Please review an enhancement to make `DocCommentParser` normalize whitespace
>> inside `` elements. The normalization is conceptually simple and and
>> intended to be minimally invasive. Before parsing, `DocCommentParser` checks
>> wh
On Mon, 3 Mar 2025 16:41:18 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to make `DocCommentParser` normalize whitespace
> inside `` elements. The normalization is conceptually simple and and
> intended to be minimally invasive. Before parsing, `DocCommentParse
On Mon, 3 Mar 2025 16:41:18 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to make `DocCommentParser` normalize whitespace
> inside `` elements. The normalization is conceptually simple and and
> intended to be minimally invasive. Before parsing, `DocCommentParse
Please review an enhancement to treat classes and interfaces that are not
included and not unconditionally exported as hidden. This means they do not
show up in the generated documentation even if they are implemented or extended
by a documented type.
This change makes the `@hidden` JavaDoc ta
On Wed, 23 Jul 2025 14:33:34 GMT, Hannes Wallnöfer wrote:
>> @hns Would it be possible to confirm that it's okay to remove this from the
>> doclet tests?
>
> The list is used as list of external linkable modules/packages for the
> `-linkoffline` option. Since the
On Wed, 23 Jul 2025 05:55:11 GMT, Alan Bateman wrote:
>> As expected, the above test passes fine if I remove the jsobject entries
>> from `test/langtools/jdk/javadoc/doclet/testRecordTypes/jdk17/element-list`.
>> I'll go ahead and remove them, since it seems like good cleanup.
>
> @hns Would it
73 matches
Mail list logo
