On Tue, 8 Jul 2025 16:34:47 GMT, Mikhail Yankelevich
wrote:
>> Refactored extract method to encapsulate Windows specific test logic
>
> test/jdk/java/io/File/MaxPathLength.java line 200:
>
>> 198: String name = fileName;
>> 199: while (name.length() < MAX_LENGTH) {
>> 20
Refactored extract method to encapsulate Windows specific test logic
-
Commit messages:
- 8360411:[TEST] open/test/jdk/java/io/File/MaxPathLength.java Refactor
extract method to encapsulate Windows specific
Changes: https://git.openjdk.org/jdk/pull/26193/files
Webrev: https://web
On Tue, 8 Jul 2025 16:10:17 GMT, Darragh Conway wrote:
> Refactored extract method to encapsulate Windows specific test logic
Thanks for the suggestion, I'll create a separate ticket for that junit
conversion...
-
PR Comment: https://git.openjdk.org/jdk/pull/26193#issu
There were a couple of post review comments after the /integrate command was
submitted. This issue will address those comments. Also created constants for
hardcoded values and tests. Fixed some typos.
-
Commit messages:
- 8363720: Follow up to JDK-8360411 with post review comments
On Tue, 8 Jul 2025 16:10:17 GMT, Darragh Conway wrote:
> Refactored extract method to encapsulate Windows specific test logic
@AlanBateman thanks for the comments I'll address those in the following issue:
https://bugs.openjdk.org/browse/JDK-8363720 if that's ok with you. As I&#x
On Wed, 23 Jul 2025 14:07:25 GMT, Darragh Conway wrote:
> There were a couple of post review comments for PR:
> https://github.com/openjdk/jdk/pull/26193 after the /integrate command was
> submitted. This issue will address those comments. Also created constants for
> hardcode
> There were a couple of post review comments for PR:
> https://github.com/openjdk/jdk/pull/26193 after the /integrate command was
> submitted. This issue will address those comments. Also created constants for
> hardcoded values and tests. Fixed some typos.
Darragh Conway has upda
On Thu, 31 Jul 2025 22:08:09 GMT, Brian Burkhalter wrote:
>> Darragh Conway has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented Brian's suggestion
>
> test/jdk/java/io/File/MaxPathLength.jav
> There were a couple of post review comments after the /integrate command was
> submitted. This issue will address those comments. Also created constants for
> hardcoded values and tests. Fixed some typos.
Darragh Conway has updated the pull request incrementally with one additiona
On Tue, 29 Jul 2025 18:48:10 GMT, Brian Burkhalter wrote:
>> Darragh Conway has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix remaining indentation errors (From my first commit on this branch)
&
On Thu, 31 Jul 2025 20:50:36 GMT, Darragh Conway wrote:
>> There were a couple of post review comments after the /integrate command was
>> submitted. This issue will address those comments. Also created constants
>> for hardcoded values and tests. Fixed some typos.
>
On Tue, 8 Jul 2025 16:10:17 GMT, Darragh Conway wrote:
> Refactored extract method to encapsulate Windows specific test logic
This pull request has now been integrated.
Changeset: 016694bf
Author:DarraghConway
Committer: Mark Sheppard
URL:
https://git.openjdk.org/jdk/com
> There were a couple of post review comments after the /integrate command was
> submitted. This issue will address those comments. Also created constants for
> hardcoded values and tests. Fixed some typos.
Darragh Conway has updated the pull request incrementally with one additiona
> There were a couple of post review comments after the /integrate command was
> submitted. This issue will address those comments. Also created constants for
> hardcoded values and tests. Fixed some typos.
Darragh Conway has updated the pull request incrementally with one additiona
14 matches
Mail list logo
