Re: RFR: 8315884: New Object to ObjectMonitor mapping [v11]

2024-08-13 Thread Daniel D . Daugherty
On Mon, 12 Aug 2024 15:58:14 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v15]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 14:52:03 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v6]

2024-08-13 Thread Daniel D . Daugherty
On Mon, 15 Jul 2024 00:45:10 GMT, Axel Boldt-Christmas wrote: >> src/hotspot/share/runtime/lightweightSynchronizer.cpp line 401: >> >>> 399: >>> 400: if (inserted) { >>> 401: // Hopefully the performance counters are allocated on distinct >> >> It doesn't look like the counters are on d

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v15]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 14:56:32 GMT, Coleen Phillimore wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove the last OMWorld references >> - Rename omworldtable_work to object_monitor_table_work > > src/h

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v16]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 16:30:12 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v15]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 16:49:42 GMT, Daniel D. Daugherty wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove the last OMWorld references >> - Rename omworldtable_wor

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v16]

2024-08-13 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 16:30:12 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v16]

2024-08-14 Thread Daniel D . Daugherty
On Wed, 14 Aug 2024 09:35:10 GMT, Axel Boldt-Christmas wrote: >> src/hotspot/share/runtime/vframe.cpp line 252: >> >>> 250: if (mark.has_monitor()) { >>> 251: ObjectMonitor* mon = >>> ObjectSynchronizer::read_monitor(current, monitor->owner(), mark); >>> 252:

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v19]

2024-08-14 Thread Daniel D . Daugherty
On Wed, 14 Aug 2024 09:24:34 GMT, Axel Boldt-Christmas wrote: >> When inflating a monitor the `ObjectMonitor*` is written directly over the >> `markWord` and any overwritten data is displaced into a displaced >> `markWord`. This is problematic for concurrent GCs which needs extra care or >> l

Re: RFR: 8315884: New Object to ObjectMonitor mapping [v15]

2024-08-14 Thread Daniel D . Daugherty
On Tue, 13 Aug 2024 17:24:19 GMT, Daniel D. Daugherty wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove the last OMWorld references >> - Rename omworldtable_wor

Re: RFR: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist [v5]

2022-11-23 Thread Daniel D . Daugherty
On Mon, 21 Nov 2022 16:35:46 GMT, Weibing Xiao wrote: >> print warning message for java.io.tmpdir when it is set through the command >> line and the value is not good for creating file folder. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the las

Integrated: 8298214: ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java

2022-12-06 Thread Daniel D . Daugherty
On Tue, 6 Dec 2022 21:38:45 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 4 different tests: > [JDK-8298214](https://bugs.openjdk.org/browse/JDK-8298214) ProblemList > java/util/concurrent/forkjoin/AsyncShutdownNow.java > [JDK-8298218](https://bugs.openjdk.or

[jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Daniel D . Daugherty
A batch a trivial fixes to ProblemList tests: [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 [JDK-8298977](https://bugs.openjdk.org/browse/JDK-8298977) ProblemList vmTestbase/nsk/stress/strace/strace002.

Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Daniel D . Daugherty
On Fri, 16 Dec 2022 21:13:56 GMT, Kim Barrett wrote: >> A batch a trivial fixes to ProblemList tests: >> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList >> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 >> [JDK-8298977](https://bugs.openjdk.org/brows

[jdk20] Integrated: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Daniel D . Daugherty
On Fri, 16 Dec 2022 21:02:21 GMT, Daniel D. Daugherty wrote: > A batch a trivial fixes to ProblemList tests: > [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList > java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 > [JDK-8298977](https://bugs

Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-16 Thread Daniel D . Daugherty
On Fri, 16 Dec 2022 21:16:38 GMT, Iris Clark wrote: >> A batch a trivial fixes to ProblemList tests: >> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList >> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 >> [JDK-8298977](https://bugs.openjdk.org/browse

Re: [jdk20] RFR: 8298976: ProblemList java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64

2022-12-17 Thread Daniel D . Daugherty
On Sat, 17 Dec 2022 08:05:08 GMT, Alan Bateman wrote: >> A batch a trivial fixes to ProblemList tests: >> [JDK-8298976](https://bugs.openjdk.org/browse/JDK-8298976) ProblemList >> java/util/concurrent/ExecutorService/CloseTest.java on macosx-aarch64 >> [JDK-8298977](https://bugs.openjdk.org/brow

Re: [jdk20] Integrated: 8298987: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64

2022-12-17 Thread Daniel D . Daugherty
On Sat, 17 Dec 2022 16:05:24 GMT, Alexander Zvegintsev wrote: >> A batch of trivial fixes to ProblemList tests: >> [JDK-8298987](https://bugs.openjdk.org/browse/JDK-8298987) ProblemList >> jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64 >> [JDK-8298989](https://bugs.openjdk.org/b

[jdk20] Integrated: 8298987: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64

2022-12-17 Thread Daniel D . Daugherty
A batch of trivial fixes to ProblemList tests: [JDK-8298987](https://bugs.openjdk.org/browse/JDK-8298987) ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64 [JDK-8298989](https://bugs.openjdk.org/browse/JDK-8298989) ProblemList vmTestbase/nsk/jvmti/InterruptThread/intrpthr

[jdk20] Integrated: 8298987: ProblemList jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64

2022-12-17 Thread Daniel D . Daugherty
On Sat, 17 Dec 2022 16:00:32 GMT, Daniel D. Daugherty wrote: > A batch of trivial fixes to ProblemList tests: > [JDK-8298987](https://bugs.openjdk.org/browse/JDK-8298987) ProblemList > jdk/internal/vm/Continuation/Fuzz.java#default with ZGC on X64 > [JDK-8298989](https://bugs

[jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Daniel D . Daugherty
A trivial fix to slightly increase the default timeout so that java/lang/reflect/IllegalArgumentsTest.java passes with slowdebug bits. - Commit messages: - 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits Changes: https://git.openjdk.org/jdk20/pul

Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Daniel D . Daugherty
On Mon, 19 Dec 2022 22:34:00 GMT, Iris Clark wrote: >> A trivial fix to slightly increase the default timeout so that >> java/lang/reflect/IllegalArgumentsTest.java >> passes with slowdebug bits. > > Marked as reviewed by iris (Reviewer). @irisclark - Thanks for the fast review. Do you agree th

Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Daniel D . Daugherty
On Mon, 19 Dec 2022 23:03:54 GMT, Iris Clark wrote: >> A trivial fix to slightly increase the default timeout so that >> java/lang/reflect/IllegalArgumentsTest.java >> passes with slowdebug bits. > > Trivial update approved. @irisclark - Thanks! - PR: https://git.openjdk.org/jdk20

[jdk20] Integrated: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Daniel D . Daugherty
On Mon, 19 Dec 2022 22:20:08 GMT, Daniel D. Daugherty wrote: > A trivial fix to slightly increase the default timeout so that > java/lang/reflect/IllegalArgumentsTest.java > passes with slowdebug bits. This pull request has now been integrated. Changeset: f07acfc1 Author:

[jdk20] Integrated: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC

2023-01-13 Thread Daniel D . Daugherty
Trivial fixes to ProblemList some tests: [JDK-8300141](https://bugs.openjdk.org/browse/JDK-8300141) ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC [JDK-8300144](https://bugs.openjdk.org/browse/JDK-8300144) ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain007/chain007.j

Re: [jdk20] Integrated: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC

2023-01-13 Thread Daniel D . Daugherty
On Fri, 13 Jan 2023 22:43:09 GMT, Mikael Vidstedt wrote: >> Trivial fixes to ProblemList some tests: >> [JDK-8300141](https://bugs.openjdk.org/browse/JDK-8300141) ProblemList >> java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC >> [JDK-8300144](https://bugs.openjdk.org/browse/JDK-8300144)

[jdk20] Integrated: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC

2023-01-13 Thread Daniel D . Daugherty
On Fri, 13 Jan 2023 21:25:54 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList some tests: > [JDK-8300141](https://bugs.openjdk.org/browse/JDK-8300141) ProblemList > java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC > [JDK-8300144](https://bugs.openjdk.org/browse

Re: RFR: 8301306: java/net/httpclient/* fail with -Xcomp: java.io.IOException: HTTP/1.1 header parser received no bytes

2023-01-30 Thread Daniel D . Daugherty
On Mon, 30 Jan 2023 07:16:17 GMT, SUN Guoyun wrote: > Hi all, > I think `BackgroundCompilation` should not be set to false when `-Xcomp` be > used, which causes the java thread to block for longer, then causing the > following tests failed frequently on the AArch64 and LoongArch64 architecture.

Re: RFR: 8303133: Update ProcessTols.startProcess(...) to exit early if process exit before linePredicate is printed.

2023-02-24 Thread Daniel D . Daugherty
On Fri, 24 Feb 2023 22:15:18 GMT, Leonid Mesnik wrote: > The solution proposed by Stefan K > > The startProcess() might wait forever for the expected line if the process > exits (failed to start). It makes sense to just fail earlier in such cases. > > The fix also move > 'output = new OutputAn

Re: RFR: JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library [v2]

2023-03-20 Thread Daniel D . Daugherty
On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung wrote: >> `ModuleInfoWriter` is not used by the runtime. Move it to the test library >> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the >> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module` >>

Re: Integrated: 8305602: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java

2023-04-04 Thread Daniel D . Daugherty
On Tue, 4 Apr 2023 18:58:12 GMT, Mandy Chung wrote: > This gives time to investigate JDK-8305600 and understand why the test didn't > fail on my testing before the push. Thumbs up. This is a trivial fix. - Marked as reviewed by dcubed (Reviewer). PR Review: https://git.openjdk.or

Integrated: 8305678: ProblemList serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp

2023-04-05 Thread Daniel D . Daugherty
Trivial fixes to ProblemList a couple of tests: [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp [JDK-8305679](https://bugs.openjdk.org/browse/JDK-8305679) ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java

Re: Integrated: 8305678: ProblemList serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp

2023-04-05 Thread Daniel D . Daugherty
On Wed, 5 Apr 2023 21:18:28 GMT, Mikael Vidstedt wrote: >> Trivial fixes to ProblemList a couple of tests: >> [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList >> serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp >> [JDK-8305679](https://bugs.openjdk.org/browse/JD

Integrated: 8305678: ProblemList serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp

2023-04-05 Thread Daniel D . Daugherty
On Wed, 5 Apr 2023 21:12:14 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList a couple of tests: > [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList > serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp > [JDK-8305679](https://bugs.openjd

Integrated: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp

2023-04-24 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp. - Commit messages: - 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp Changes: https://git.openjdk.org/jdk/pull/13627/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=

Re: Integrated: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp

2023-04-24 Thread Daniel D . Daugherty
On Mon, 24 Apr 2023 19:34:01 GMT, Joe Darcy wrote: >> A trivial fix to ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in >> Xcomp. > > Marked as reviewed by darcy (Reviewer). @jddarcy - Thanks for the fast review! - PR Comment: https://git.openjdk.org/jdk/pull/13627#issue

Integrated: 8306780: ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in Xcomp

2023-04-24 Thread Daniel D . Daugherty
On Mon, 24 Apr 2023 19:28:41 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/Thread/virtual/HoldsLock.java#id0 in > Xcomp. This pull request has now been integrated. Changeset: 328e512d Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/

Re: RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time

2023-04-25 Thread Daniel D . Daugherty
On Tue, 25 Apr 2023 04:05:05 GMT, Leonid Mesnik wrote: >> test/lib/jdk/test/lib/process/ProcessTools.java line 792: >> >>> 790: @Override >>> 791: public InputStream getInputStream() { >>> 792: return out; >> >> This is a little bit confusing that the `getInputStream

Re: RFR: 8306946: jdk/test/lib/process/ProcessToolsStartProcessTest.java fails with "wrong number of lines in OutputAnalyzer output" [v3]

2023-04-27 Thread Daniel D . Daugherty
On Thu, 27 Apr 2023 16:35:59 GMT, Leonid Mesnik wrote: >> The ProcessTools.startProcess (...) has been updated to completely read >> streams after process has been completed. >> The test was updated to run 5 times with different number of lines and line >> sizes. > > Leonid Mesnik has updated t

RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
Trivial fixes to ProblemList a few tests: - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-8307490) ProblemList sun/security/pkcs11/Cipher/TestKATForGCM.java on linux

Re: RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
On Thu, 4 May 2023 21:21:38 GMT, Joe Darcy wrote: >> Trivial fixes to ProblemList a few tests: >> - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList >> jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 >> - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-8307490) Pro

Integrated: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
On Thu, 4 May 2023 20:49:26 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList a few tests: > - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList > jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 > - [JDK-8307490](https://bugs.openjdk.or

RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64. - Commit messages: - 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64 Changes: https://git.openjdk.org/jdk/pull/13946/files Webrev: https://webrevs.openjdk.or

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
On Fri, 12 May 2023 00:09:12 GMT, Chris Plummer wrote: >> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java >> on linux-x64. > > Maybe linux-all would be better. @plummercj - Thanks for the review. 'linux-all' would make it apply to linux versions that we don't have. I

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
On Fri, 12 May 2023 00:15:25 GMT, Leonid Mesnik wrote: >> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java >> on linux-x64. > > Might be this failure is platform agnostic and should be generic all. We just > don't run this combination on macosx so often. ( @lmesnik -

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64 [v2]

2023-05-11 Thread Daniel D . Daugherty
> A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > on linux-x64. Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision: plummercj CR - use linux-all instead - Changes: - all:

Re: RFR: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
On Fri, 12 May 2023 00:05:21 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > on linux-x64. I've switched to using 'linux-all' instead of enumeration of the platforms. - PR Comment: https://git

Integrated: 8307966: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java on linux-x64

2023-05-11 Thread Daniel D . Daugherty
On Fri, 12 May 2023 00:05:21 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java > on linux-x64. This pull request has now been integrated. Changeset: 9a7b4431 Author:Daniel D. Daugherty URL: https://git.openjdk.o

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-24 Thread Daniel D . Daugherty
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a

Integrated: 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2022-06-24 Thread Daniel D . Daugherty
A trivial fix to ProblemList tools/jlink/plugins/CompressorPluginTest.java. - Commit messages: - 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java Changes: https://git.openjdk.org/jdk/pull/9285/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9285&range=00

Re: Integrated: 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2022-06-24 Thread Daniel D . Daugherty
On Fri, 24 Jun 2022 18:54:42 GMT, Leonid Mesnik wrote: >> A trivial fix to ProblemList tools/jlink/plugins/CompressorPluginTest.java. > > Marked as reviewed by lmesnik (Reviewer). @lmesnik and @bplb - Thanks for the lightning fast reviews! - PR: https://git.openjdk.org/jdk/pull/928

Integrated: 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java

2022-06-24 Thread Daniel D . Daugherty
On Fri, 24 Jun 2022 18:51:40 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList tools/jlink/plugins/CompressorPluginTest.java. This pull request has now been integrated. Changeset: 08288819 Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk/com

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-24 Thread Daniel D . Daugherty
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a

[jdk19] RFR: 8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode

2022-06-27 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode. - Commit messages: - 8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode Changes: https://git.openjdk.org/jdk19/pull/78/files Web

Re: [jdk19] RFR: 8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode

2022-06-27 Thread Daniel D . Daugherty
On Mon, 27 Jun 2022 18:38:09 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList >> java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode. > > Marked as reviewed by bpb (Reviewer). @bplb and @naotoj - Thanks for the fast reviews! - PR: https://git.o

[jdk19] Integrated: 8289240: ProblemList java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode

2022-06-27 Thread Daniel D . Daugherty
On Mon, 27 Jun 2022 18:35:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/lang/reflect/callerCache/ReflectionCallerCacheTest.java in -Xcomp mode. This pull request has now been integrated. Changeset: caa6b74b Author:Daniel D. Daugherty URL:

[jdk19] Integrated: 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java

2022-06-27 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java. - Commit messages: - 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java Changes: https://git.openjdk.org/jdk19/pull/80/files Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=80&range=00 Issue: h

[jdk19] Integrated: 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java

2022-06-27 Thread Daniel D . Daugherty
On Mon, 27 Jun 2022 21:16:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java. This pull request has now been integrated. Changeset: 2efa89a8 Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk19/com

Re: [jdk19] Integrated: 8289251: ProblemList java/lang/ref/OOMEInReferenceHandler.java

2022-06-27 Thread Daniel D . Daugherty
On Mon, 27 Jun 2022 21:17:40 GMT, David Holmes wrote: >> A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java. > > Marked as reviewed by dholmes (Reviewer). @dholmes-ora - Thanks for the lightning fast review! - PR: https://git.openjdk.org/jdk19/pull/80

Re: RFR: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Daniel D . Daugherty
On Thu, 7 Jul 2022 20:36:43 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. Thumbs up. I didn't realize that other test dirs already had the mechanism in place to is

Re: [jdk19] Integrated: 8278469: Test java/nio/channels/FileChannel/LargeGatheringWrite.java times out

2022-07-08 Thread Daniel D . Daugherty
On Thu, 7 Jul 2022 22:25:10 GMT, Brian Burkhalter wrote: > Modify test directives so that `LargeGatheringWrite` and `MapTest` in > `java/nio/channels/FileChannel` are not run concurrently with other tests. > > Redirected from https://github.com/openjdk/jdk/pull/9416. Thumbs up. This is a trivi

Re: RFR: 8290264 : java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0" [v2]

2022-07-14 Thread Daniel D . Daugherty
On Thu, 14 Jul 2022 16:15:48 GMT, Doug Lea wrote: >> This test now conforms to jtreg rules about not using System.exit to cover >> untested OutOfMemoryErrors > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > try/lock() style Th

RFR: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
Merge jdk19 -> jdk20. - Commit messages: - Merge - 8290625: Test jdk/javadoc/tool/CheckManPageOptions.java after manpage update - 8278274: Update nroff pages in JDK 19 before RC - 8287916: Address the inconsistency between the constant array and pool size - 8285407: Improve Xalan

Re: RFR: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. Mach5 Tier1 passed. - PR: https://git.openjdk.org/jdk/pull/9578

Integrated: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. This pull request has now been integrated. Changeset: 9c19d89c Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/9c19d89c9c564e436732c5f7851f4960fb5d783c Stats: 504 li

Re: RFR: 8290489: Initial nroff manpage generation for JDK 20

2022-07-20 Thread Daniel D . Daugherty
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote: > The version will be 20-ea and the copyright year 2023 (for March 2023 release > date). > > Thanks. Thumbs up. This is a trivial change. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.org/jdk/pull/9581

Re: RFR: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload

2022-07-22 Thread Daniel D . Daugherty
On Fri, 22 Jul 2022 19:48:45 GMT, Roger Riggs wrote: > java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java should be > ProblemListed until the cause can be found. This test might only be failing with -Xcomp. Let me check... - PR: https://git.openjdk.org/jdk/pull/9617

Re: RFR: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload [v2]

2022-07-22 Thread Daniel D . Daugherty
On Fri, 22 Jul 2022 20:06:00 GMT, Roger Riggs wrote: >> java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload.java should be >> ProblemListed until the cause can be found. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all

2022-08-04 Thread Daniel D . Daugherty
On Thu, 4 Aug 2022 22:28:20 GMT, David Holmes wrote: >> A trivial fix to ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java >> on linux-all. > > Marked as reviewed by dholmes (Reviewer). @dholmes-ora - Thanks for the lightning fast review. - PR: https://git.openjdk.org/jdk/

Integrated: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all

2022-08-04 Thread Daniel D . Daugherty
On Thu, 4 Aug 2022 22:23:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on > linux-all. This pull request has now been integrated. Changeset: 6e6c64c6 Author:Daniel D. Daugherty URL: https://git.openjdk.o

RFR: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all

2022-08-04 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all. - Commit messages: - 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all Changes: https://git.openjdk.org/jdk/pull/9757/files Webrev: https://webrevs.openjdk.org/?

Re: RFR: 8292132: ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java

2022-08-09 Thread Daniel D . Daugherty
On Tue, 9 Aug 2022 19:19:00 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList >> jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java. > > Marked as reviewed by bpb (Reviewer). @bplb - Thanks for the fast review! - PR: https://git.openjdk.org/jdk/pul

RFR: 8292132: ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java

2022-08-09 Thread Daniel D . Daugherty
A trivial fix to ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java. - Commit messages: - 8292132: ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java Changes: https://git.openjdk.org/jdk/pull/9812/files Webrev: h

Integrated: 8292132: ProblemList jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java

2022-08-09 Thread Daniel D . Daugherty
On Tue, 9 Aug 2022 19:16:04 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java. This pull request has now been integrated. Changeset: 57e0da15 Author:Daniel D. Daugherty URL:

RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"

2022-08-11 Thread Daniel D . Daugherty
A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG setting when waiting for a compilation to finish. - Commit messages: - 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms" Ch

RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

2022-08-11 Thread Daniel D . Daugherty
Split the java/util/stream/SpinedBufferTest.java test into two parts: - java/util/stream/SpinedBufferTest1.java has the first 6 test cases - java/util/stream/SpinedBufferTes2.java has the second 6 test cases I couldn't figure out a way to set a larger timeout value for the entirety of java/util/st

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms"

2022-08-12 Thread Daniel D . Daugherty
On Fri, 12 Aug 2022 03:43:46 GMT, Leonid Mesnik wrote: >> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG >> setting >> when waiting for a compilation to finish. >> >> This fix is being tested in my jdk-20+10 stress testing run. >> >> The usual Mach5 timeoutFactor i

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms"

2022-08-12 Thread Daniel D . Daugherty
On Thu, 11 Aug 2022 20:02:06 GMT, Daniel D. Daugherty wrote: > A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG > setting > when waiting for a compilation to finish. > > This fix is being tested in my jdk-20+10 stress testing run. > > The usua

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms"

2022-08-12 Thread Daniel D . Daugherty
On Fri, 12 Aug 2022 04:05:47 GMT, Jie Fu wrote: >> test/jdk/jdk/internal/vm/Continuation/Fuzz.java line 81: >> >>> 79: static final boolean VERBOSE = false; >>> 80: >>> 81: static float timeoutFactor = >>> Float.parseFloat(System.getProperty("test.timeout.factor", "1.0")); >> >> How a

RFR: 8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows

2022-08-16 Thread Daniel D . Daugherty
Trivial fixes to ProblemList two different tests. - Commit messages: - 8292510: ProblemList runtime/cds/appcds/cacheObject/ArchivedEnumTest.java - 8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows Changes: https://git.openjdk.org/jdk/pull/9894/fi

Re: RFR: 8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows

2022-08-16 Thread Daniel D . Daugherty
On Tue, 16 Aug 2022 22:47:12 GMT, Joe Darcy wrote: >> Trivial fixes to ProblemList two different tests. > > Marked as reviewed by darcy (Reviewer). @jddarcy - Thanks for the fast review. I'm now waiting for the bots to catch up... - PR: https://git.openjdk.org/jdk/pull/9894

Integrated: 8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows

2022-08-16 Thread Daniel D . Daugherty
On Tue, 16 Aug 2022 22:43:39 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList two different tests. This pull request has now been integrated. Changeset: da477b13 Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk/com

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms" [v2]

2022-08-19 Thread Daniel D . Daugherty
> timeoutFactor > of 10.0. In my stress testing, I use release-bits: 4.0, fastdebug-bits: 6.0 > and slowdebug-bits: 12.0. Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision: Scale the original COMPILATION_TIMEOUT value

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms" [v2]

2022-08-19 Thread Daniel D . Daugherty
On Fri, 19 Aug 2022 19:48:24 GMT, Daniel D. Daugherty wrote: >> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG >> setting >> when waiting for a compilation to finish. >> >> This fix is being tested in my jdk-20+10 stress testi

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

2022-08-19 Thread Daniel D . Daugherty
On Tue, 16 Aug 2022 16:45:03 GMT, Paul Sandoz wrote: >> Split the java/util/stream/SpinedBufferTest.java test into two parts: >> - java/util/stream/SpinedBufferTest1.java has the first 6 test cases >> - java/util/stream/SpinedBufferTes2.java has the second 6 test cases >> >> I couldn't figure ou

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

2022-08-19 Thread Daniel D . Daugherty
On Fri, 19 Aug 2022 12:57:38 GMT, Aleksey Shipilev wrote: >> Split the java/util/stream/SpinedBufferTest.java test into two parts: >> - java/util/stream/SpinedBufferTest1.java has the first 6 test cases >> - java/util/stream/SpinedBufferTes2.java has the second 6 test cases >> >> I couldn't figu

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms"

2022-08-19 Thread Daniel D . Daugherty
On Fri, 12 Aug 2022 23:44:26 GMT, Jie Fu wrote: >> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG >> setting >> when waiting for a compilation to finish. >> >> This fix is being tested in my jdk-20+10 stress testing run. >> >> The usual Mach5 timeoutFactor is 4.0 w

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug [v2]

2022-08-19 Thread Daniel D . Daugherty
or the entirety > of java/util/stream/SpinedBufferTest.java and I saw that other folks solved > this problem with testng tests by splitting the test into more parts. > > This fix is being tested in my jdk-20+10 stress testing run. Daniel D. Daugherty has updated the pull request in

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug [v2]

2022-08-22 Thread Daniel D . Daugherty
On Mon, 22 Aug 2022 07:42:06 GMT, Aleksey Shipilev wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor SpinedBufferTest.java by type. > > Looks much better, I have

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug [v2]

2022-08-22 Thread Daniel D . Daugherty
On Mon, 22 Aug 2022 07:35:28 GMT, Aleksey Shipilev wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor SpinedBufferTest.java by type. > > test/jdk/java/util/stream/boott

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug [v3]

2022-08-22 Thread Daniel D . Daugherty
or the entirety > of java/util/stream/SpinedBufferTest.java and I saw that other folks solved > this problem with testng tests by splitting the test into more parts. > > This fix is being tested in my jdk-20+10 stress testing run. Daniel D. Daugherty has updated the pull request in

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug [v3]

2022-08-22 Thread Daniel D . Daugherty
On Mon, 22 Aug 2022 18:04:30 GMT, Aleksey Shipilev wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> shipilev CR changes > > I am good with this version, thanks. @shipilev

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug [v3]

2022-08-22 Thread Daniel D . Daugherty
On Mon, 22 Aug 2022 18:59:33 GMT, Roger Riggs wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> shipilev CR changes > > LGTM @RogerRiggs - Thanks for the re-rev

Integrated: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"

2022-08-22 Thread Daniel D . Daugherty
On Thu, 11 Aug 2022 20:02:06 GMT, Daniel D. Daugherty wrote: > A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG > setting > when waiting for a compilation to finish. > > This fix is being tested in my jdk-20+10 stress testing run. > > The usua

Integrated: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug

2022-08-22 Thread Daniel D . Daugherty
On Thu, 11 Aug 2022 20:09:06 GMT, Daniel D. Daugherty wrote: > Split the java/util/stream/SpinedBufferTest.java test into two parts: > - java/util/stream/SpinedBufferTest1.java has the first 6 test cases > - java/util/stream/SpinedBufferTes2.java has the second 6 test cases >

Re: RFR: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int, int) in 5000ms" [v2]

2022-08-22 Thread Daniel D . Daugherty
On Fri, 19 Aug 2022 19:48:24 GMT, Daniel D. Daugherty wrote: >> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG >> setting >> when waiting for a compilation to finish. >> >> This fix is being tested in my jdk-20+10 stress testi

Re: RFR: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug [v3]

2022-08-22 Thread Daniel D . Daugherty
On Mon, 22 Aug 2022 18:03:21 GMT, Daniel D. Daugherty wrote: >> Split the java/util/stream/SpinedBufferTest.java test into two parts: >> - java/util/stream/SpinedBufferTest1.java has the first 6 test cases >> - java/util/stream/SpinedBufferTes2.java has the second 6 test cases

Integrated: 8293496: ProblemList runtime/os/TestTracePageSizes.java on linux-x64

2022-09-07 Thread Daniel D . Daugherty
On Wed, 7 Sep 2022 15:18:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList runtime/os/TestTracePageSizes.java on linux-x64. This pull request has now been integrated. Changeset: d36abbe8 Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk/com

Re: RFR: 8293496: ProblemList runtime/os/TestTracePageSizes.java on linux-x64

2022-09-07 Thread Daniel D . Daugherty
On Wed, 7 Sep 2022 15:20:54 GMT, Alexander Zvegintsev wrote: >> A trivial fix to ProblemList runtime/os/TestTracePageSizes.java on linux-x64. > > Marked as reviewed by azvegint (Reviewer). @azvegint - Thanks for your review also. (Just caught up on the email thread). - PR: https:/

Re: RFR: 8293540: [Metrics] Incorrectly detected ressource limits with additional cgroup fs mounts

2022-09-14 Thread Daniel D . Daugherty
On Tue, 13 Sep 2022 13:06:10 GMT, Severin Gehwolf wrote: > Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more comm

  1   2   >