Re: RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v6]

2024-05-23 Thread Bhavana Kilambi
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote: >> Moving array construction within BigInteger.implMultiplyToLen intrinsic >> candidate to its caller simplifies the intrinsic implementation in JIT >> compiler. > > Yudi Zheng has updated the pull request incrementally with one additional >

Re: RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v6]

2024-05-23 Thread Bhavana Kilambi
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote: >> Moving array construction within BigInteger.implMultiplyToLen intrinsic >> candidate to its caller simplifies the intrinsic implementation in JIT >> compiler. > > Yudi Zheng has updated the pull request incrementally with one additional >

Re: RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v6]

2024-05-23 Thread Bhavana Kilambi
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote: >> Moving array construction within BigInteger.implMultiplyToLen intrinsic >> candidate to its caller simplifies the intrinsic implementation in JIT >> compiler. > > Yudi Zheng has updated the pull request incrementally with one additional >

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v4]

2024-08-20 Thread Bhavana Kilambi
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD: Saturating signed addition. >>

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v4]

2024-08-20 Thread Bhavana Kilambi
On Mon, 19 Aug 2024 07:19:30 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SUADD : Saturating unsigned addition. >> . SADD: Saturating signed addition. >>

Re: RFR: 8289552: Make intrinsic conversions between bit representations of half precision values and floats [v11]

2022-09-30 Thread Bhavana Kilambi
On Wed, 28 Sep 2022 17:40:36 GMT, Smita Kamath wrote: >> 8289552: Make intrinsic conversions between bit representations of half >> precision values and floats > > Smita Kamath has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed revi

Re: RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v3]

2024-05-20 Thread Bhavana Kilambi
On Wed, 17 Apr 2024 12:37:01 GMT, Yudi Zheng wrote: >> `multiply_to_len` seems to be used by `generate_squareToLen` as well for >> aarch64 and riscv but `zlen` is still passed in a register. >> >> https://github.com/openjdk/jdk/blob/870a6127cf54264c691f7322d775b202705c3bfa/src/hotspot/cpu/aarch

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations

2024-11-19 Thread Bhavana Kilambi
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote: > Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of vario

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations

2024-11-19 Thread Bhavana Kilambi
could you also include the idealization tests here - >> test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and >> ConvF2HFIdealizationTests.java in this PR? > > Hi @Bhavana-Kilambi , > I am in process of refining existing patch, tests and benchmark, will updat

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations

2024-11-19 Thread Bhavana Kilambi
On Wed, 16 Oct 2024 14:19:40 GMT, Bhavana Kilambi wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations

2024-11-20 Thread Bhavana Kilambi
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote: > Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of vario

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations

2024-11-20 Thread Bhavana Kilambi
On Wed, 20 Nov 2024 14:57:11 GMT, Jatin Bhateja wrote: >> test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorConvChain.java >> line 44: >> >>> 42: @Test >>> 43: @IR(applyIfCPUFeatureAnd = {"avx512_fp16", "false", "avx512vl", >>> "true"}, counts = {IRNode.VECTOR_CAST_HF2F, IRNod

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations

2024-11-21 Thread Bhavana Kilambi
On Thu, 21 Nov 2024 02:41:47 GMT, Hao Sun wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection of var

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations

2024-11-21 Thread Bhavana Kilambi
(\d+(\s){2}(AddVHF.*)+(\s){2}===.*)" >>... > >> Hi @shqking , thanks for your review. I am currently working on adding the >> aarch64 port for these operations. It's being done here - >> [jatin-bhateja#6](https://github.c

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v3]

2024-11-26 Thread Bhavana Kilambi
On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v3]

2024-11-26 Thread Bhavana Kilambi
On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v3]

2024-11-26 Thread Bhavana Kilambi
On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations [v3]

2024-11-26 Thread Bhavana Kilambi
On Mon, 25 Nov 2024 20:04:09 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection

Re: RFR: 8342103: C2 compiler support for Float16 type and associated operations

2024-11-21 Thread Bhavana Kilambi
On Mon, 14 Oct 2024 11:40:01 GMT, Jatin Bhateja wrote: > Hi All, > > This patch adds C2 compiler support for various Float16 operations added by > [PR#22128](https://github.com/openjdk/jdk/pull/22128) > > Following is the summary of changes included with this patch:- > > 1. Detection of vario

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors [v3]

2025-07-07 Thread Bhavana Kilambi
On Mon, 7 Jul 2025 06:59:20 GMT, Xiaohong Gong wrote: >> Have you measured the performance of this micro-benchmark on NEON machine? >> https://github.com/openjdk/jdk/blob/f2d2eef988c57cc9f6194a8fd5b2b422035ee68f/test/micro/org/openjdk/bench/vm/compiler/TypeVectorOperations.java#L251-L256 >> >> W

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors [v3]

2025-07-08 Thread Bhavana Kilambi
On Tue, 8 Jul 2025 09:07:00 GMT, Xiaohong Gong wrote: > > > > Hi @XiaohongGong, is there any way we can implement 2HF -> 2S and 2S -> > > > > 2HF in these match rules ? > > > > https://github.com/openjdk/jdk/blob/f2d2eef988c57cc9f6194a8fd5b2b422035ee68f/src/hotspot/cpu/aarch64/aarch64_vector.ad#

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors [v3]

2025-07-08 Thread Bhavana Kilambi
On Tue, 8 Jul 2025 01:55:55 GMT, Xiaohong Gong wrote: >>> > https://github.com/openjdk/jdk/blob/f2d2eef988c57cc9f6194a8fd5b2b422035ee68f/test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.java#L388-L392 >>> >>> Actually I didn't change the min vector size for `char` vectors in

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors [v4]

2025-07-09 Thread Bhavana Kilambi
On Wed, 9 Jul 2025 01:23:43 GMT, Xiaohong Gong wrote: >> ### Background >> On AArch64, the minimum vector length supported is 64-bit for basic types, >> except for `byte` and `boolean` (32-bit and 16-bit respectively to match >> special Vector API features). This limitation prevents intrinsific

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F

2025-08-04 Thread Bhavana Kilambi
On Mon, 4 Aug 2025 15:51:59 GMT, Galder Zamarreño wrote: >> test/micro/org/openjdk/bench/java/lang/VectorBitConversion.java line 67: >> >>> 65: >>> 66: @Benchmark >>> 67: public long[] doubleToLongBits() { >> >> Would something like this be more concise (and maybe more readable as well

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F

2025-08-01 Thread Bhavana Kilambi
On Thu, 24 Jul 2025 10:29:15 GMT, Galder Zamarreño wrote: > I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and `MoveI2F` > nodes. The implementation follows a similar pattern to what is done with > conversion (`Conv*`) nodes. The tests in `TestCompatibleUseDefTypeSize` have >

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F

2025-08-01 Thread Bhavana Kilambi
On Thu, 24 Jul 2025 10:29:15 GMT, Galder Zamarreño wrote: > I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and `MoveI2F` > nodes. The implementation follows a similar pattern to what is done with > conversion (`Conv*`) nodes. The tests in `TestCompatibleUseDefTypeSize` have >

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F

2025-08-01 Thread Bhavana Kilambi
On Thu, 24 Jul 2025 10:29:15 GMT, Galder Zamarreño wrote: > I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and `MoveI2F` > nodes. The implementation follows a similar pattern to what is done with > conversion (`Conv*`) nodes. The tests in `TestCompatibleUseDefTypeSize` have >

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F

2025-08-01 Thread Bhavana Kilambi
On Thu, 24 Jul 2025 10:29:15 GMT, Galder Zamarreño wrote: > I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and `MoveI2F` > nodes. The implementation follows a similar pattern to what is done with > conversion (`Conv*`) nodes. The tests in `TestCompatibleUseDefTypeSize` have >

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F

2025-08-01 Thread Bhavana Kilambi
On Thu, 24 Jul 2025 10:29:15 GMT, Galder Zamarreño wrote: > I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and `MoveI2F` > nodes. The implementation follows a similar pattern to what is done with > conversion (`Conv*`) nodes. The tests in `TestCompatibleUseDefTypeSize` have >