Re: RFR: 8077587: BigInteger Roots [v23]

2025-07-24 Thread Raffaello Giulietti
On Wed, 23 Jul 2025 23:19:49 GMT, Raffaello Giulietti wrote: >> @rgiulietti >>> The Brent & Zimmermann paper assumes an initial estimate u ≥ ⌊ x 1 / n ⌋ , >>> probably for a (unstated) reason. >> >> The reason is the condition to stop the loop, since it terminates when the >> estimate does no

Re: RFR: 8364007: Add overload without arguments to codePointCount in String etc.

2025-07-24 Thread Mikhail Yankelevich
On Thu, 24 Jul 2025 14:50:07 GMT, Tatsunori Uchino wrote: > Adds `codePointCount()` overloads to `String`, `Character`, > `(Abstract)StringBuilder`, and `StringBuffer` to make it possible to > conveniently retrieve the length of a string as code points without extra > boundary checks. > > >

Re: RFR: 8364007: Add overload without arguments to codePointCount in String etc.

2025-07-24 Thread Mikhail Yankelevich
On Thu, 24 Jul 2025 14:50:07 GMT, Tatsunori Uchino wrote: > Adds `codePointCount()` overloads to `String`, `Character`, > `(Abstract)StringBuilder`, and `StringBuffer` to make it possible to > conveniently retrieve the length of a string as code points without extra > boundary checks. > > >

RFR: 8364089: JDK 25 RDP2 L10n resource files update

2025-07-24 Thread Alisen Chung
This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop. - Commit messages: - update l10n Changes: https://git.openjdk.org/jdk/pull/26467/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26467&range

Re: RFR: 8077587: BigInteger Roots [v41]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Added pow() -nthRoot() roundtrip tests - Changes: - all: https://git.openjdk.org/jdk/pull/2

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory [v8]

2025-07-24 Thread Raffaello Giulietti
On Fri, 27 Jun 2025 01:04:32 GMT, Shaojin Wen wrote: >> In BufferedReader.readLine and other similar scenarios, we need to use >> StringBuilder.append(char[]) to build the string. >> >> For these scenarios, we can Unsafe.copyMemory instead of the character copy >> of the char-by-char loop to i

Re: RFR: 8362882: Update SubmissionPublisher() specification to reflect use of ForkJoinPool.asyncCommonPool()

2025-07-24 Thread Doug Lea
On Tue, 22 Jul 2025 13:13:41 GMT, Alan Bateman wrote: > The changes in JDK-8319447 to improve the performance of delayed task > handling updated CompletableFuture and SubmissionPublisher to use the > ForkJoinPool commonPool in all cases. These APIs previously created a Thread > for each task w

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory [v8]

2025-07-24 Thread Chen Liang
On Thu, 24 Jul 2025 13:18:03 GMT, Raffaello Giulietti wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/java.base/share/classes/java/lang/StringUTF16.java >> >> Co-authored-by: Chen Liang > > src/jav

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory [v8]

2025-07-24 Thread Roger Riggs
On Thu, 24 Jul 2025 14:20:48 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/StringUTF16.java line 1490: >> >>> 1488: val, >>> 1489: Unsafe.ARRAY_BYTE_BASE_OFFSET + ((long) index << 1), >>> 1490: (long) (end - off) << 1); >> >> The

RFR: 8364007: Add overload without arguments to codePointCount in String etc.

2025-07-24 Thread Tatsunori Uchino
Adds `codePointCount()` overloads to `String`, `Character`, `(Abstract)StringBuilder`, and `StringBuffer` to make it possible to conveniently retrieve the length of a string as code points without extra boundary checks. if (superTremendouslyLongExpressionYieldingAString().codePointCount() > li

Re: RFR: 8077587: BigInteger Roots [v42]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Use checkResult() in pow-nthRoot roundtrip tests - Changes: - all: https://git.openjdk.org/

Re: RFR: 8364007: Add overload without arguments to codePointCount in String etc.

2025-07-24 Thread Roger Riggs
On Thu, 24 Jul 2025 14:50:07 GMT, Tatsunori Uchino wrote: > Adds `codePointCount()` overloads to `String`, `Character`, > `(Abstract)StringBuilder`, and `StringBuffer` to make it possible to > conveniently retrieve the length of a string as code points without extra > boundary checks. > > >

Re: RFR: 8077587: BigInteger Roots [v43]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Update BigIntegerTest.java Adjust pow-nthRoot roundtrip tests to handle negative base with even expone

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-07-24 Thread Daniel Jeliński
On Tue, 8 Jul 2025 14:04:56 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory [v8]

2025-07-24 Thread Raffaello Giulietti
On Fri, 27 Jun 2025 01:04:32 GMT, Shaojin Wen wrote: >> In BufferedReader.readLine and other similar scenarios, we need to use >> StringBuilder.append(char[]) to build the string. >> >> For these scenarios, we can Unsafe.copyMemory instead of the character copy >> of the char-by-char loop to i

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-07-24 Thread Daniel Jeliński
On Tue, 8 Jul 2025 14:04:56 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-07-24 Thread Daniel Jeliński
On Tue, 8 Jul 2025 14:04:56 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Re: RFR: 8363720: Follow up to JDK-8360411 with post review comments [v3]

2025-07-24 Thread Darragh Conway
> There were a couple of post review comments after the /integrate command was > submitted. This issue will address those comments. Also created constants for > hardcoded values and tests. Fixed some typos. Darragh Conway has updated the pull request incrementally with one additional commit sin

Re: RFR: 8361842: Move input validation checks to Java for java.lang.StringCoding intrinsics [v12]

2025-07-24 Thread Roger Riggs
On Wed, 23 Jul 2025 12:54:00 GMT, Volkan Yazici wrote: >> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve >> their documentation, enhance the checks in the associated IR or assembly >> code, and adapt them to cause VM crash on invalid input. >> >> ## Implementation

Re: RFR: 8077587: BigInteger Roots [v45]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Round up to do less iterations With the 1st iteration outside the loop, it is more convenient rounding

Re: RFR: 8077587: BigInteger Roots [v44]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Code simplification - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files - new:

Re: RFR: 8364007: Add overload without arguments to codePointCount in String etc.

2025-07-24 Thread Chen Liang
On Thu, 24 Jul 2025 14:50:07 GMT, Tatsunori Uchino wrote: > Adds `codePointCount()` overloads to `String`, `Character`, > `(Abstract)StringBuilder`, and `StringBuffer` to make it possible to > conveniently retrieve the length of a string as code points without extra > boundary checks. > > >

Re: String.charAt vs StringBuilder.charAt performance

2025-07-24 Thread Johannes Döbler
Hi Brett, I ran your benchmark on a Windows11 Pro 24H2 / ARM64 / JDK 21 system  and can reproduce your findings that CharSequenceCharAtBenchmark.testString has weaker performance. I also added these benchmarks:     @Benchmark     public int testStringBuilderAsCS() {     return test(this.st

Re: [jdk25] RFR: 8315131: Clarify VarHandle set/get access on 32-bit platforms

2025-07-24 Thread Chen Liang
On Wed, 23 Jul 2025 04:04:46 GMT, Chen Liang wrote: > JDK-8315131 addresses a doc-only mistake present on release 25. Since this is > doc-only, this is eligible for backport, and its CSR is approved for release > 25 too. See #26258 for the original PR review. Thanks for the reviews! -

[jdk25] Integrated: 8315131: Clarify VarHandle set/get access on 32-bit platforms

2025-07-24 Thread Chen Liang
On Wed, 23 Jul 2025 04:04:46 GMT, Chen Liang wrote: > JDK-8315131 addresses a doc-only mistake present on release 25. Since this is > doc-only, this is eligible for backport, and its CSR is approved for release > 25 too. See #26258 for the original PR review. This pull request has now been int

Re: RFR: 8363720: Follow up to JDK-8360411 with post review comments [v2]

2025-07-24 Thread Darragh Conway
> There were a couple of post review comments after the /integrate command was > submitted. This issue will address those comments. Also created constants for > hardcoded values and tests. Fixed some typos. Darragh Conway has updated the pull request incrementally with one additional commit sin

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory [v8]

2025-07-24 Thread Shaojin Wen
On Tue, 22 Jul 2025 04:03:20 GMT, Chen Liang wrote: > I just noticed there is `LibraryCallKit::inline_string_getCharsU` that is for > byte -> char conversion. I wonder if we can slightly update it for char -> > byte conversion. If the performance is the same, the current proposal to use Unsafe

Re: RFR: 8077587: BigInteger Roots [v40]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Ensure an initial overestimate of the root Ensure an initial overestimate of the root by doing 1st ite

RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F

2025-07-24 Thread Galder Zamarreño
I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and `MoveI2F` nodes. The implementation follows a similar pattern to what is done with conversion (`Conv*`) nodes. The tests in `TestCompatibleUseDefTypeSize` have been updated with the new expectations. Also added a JMH benchmark

Re: String.charAt vs StringBuilder.charAt performance

2025-07-24 Thread Chen Liang
Thanks Johannes for another test case! Hotspot compiler investigation concludes this is due to inlining limits; an issue https://bugs.openjdk.org/browse/JDK-8364043 has been created. The guess for now is that limits are reached on different platforms inconsistently. _

Re: RFR: 8360163: Replace hard-coded checks with AOTRuntimeSetup and AOTSafeClassInitializer [v12]

2025-07-24 Thread Chen Liang
> I have updated this patch to avoid a redundant `runtimeSetup` annotation - we > have agreed that the requirement for setup is a side effect of > initialization, and such methods in AOTCI classes must be automatically > recognized. This latest revision implements that model. > > I intentionall

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory [v8]

2025-07-24 Thread Roger Riggs
On Fri, 27 Jun 2025 01:04:32 GMT, Shaojin Wen wrote: >> In BufferedReader.readLine and other similar scenarios, we need to use >> StringBuilder.append(char[]) to build the string. >> >> For these scenarios, we can Unsafe.copyMemory instead of the character copy >> of the char-by-char loop to i