Re: RFR: 8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close() [v4]

2025-06-12 Thread Thomas Stuefe
> Hi, please consider the following patch. > > This patch replaces the existing close-file-descriptors-logic we follow > before exec'ing a target binary: instead of explicitly closing the file > descriptors, we mark them as CLOEXEC. That simplifies the logic: it gets rid > of the awkward tiptoe

Re: RFR: 8338140: (str) Add notes to String.trim and String.isEmpty pointing to newer APIs [v4]

2025-06-12 Thread Stuart Marks
On Thu, 12 Jun 2025 23:39:44 GMT, Stuart Marks wrote: >> Add a note to String.trim pointing to the String.strip family of methods. >> >> Add notes cross-linking String.isBlank and String.isEmpty. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8358729: jdk/internal/loader/URLClassPath/ClassnameCharTest.java depends on Applet [v4]

2025-06-12 Thread Jaikiran Pai
On Thu, 12 Jun 2025 18:05:04 GMT, Justin Lu wrote: >> Please review this PR which finishes Applet removal for the test: >> jdk/internal/loader/URLClassPath/ClassnameCharTest.java. >> >> `testclasses.jar` is updated such that the two classes no longer extend >> Applet. >> >> >> $ javap fo\ o.

Re: RFR: 8359123: Misleading examples in jmod man page

2025-06-12 Thread Christian Stein
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote: > Please review my PR. This PR includes the following: > > - [x] Fix a small typo in a word and copyright. > - [x] Enhance description for `--target-platform`. > - [x] Rearrange `jmod create` example from basic to complex. Marked as

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements [v10]

2025-06-12 Thread Viktor Klang
On Wed, 11 Jun 2025 19:44:20 GMT, kabutz wrote: >> We logged several bugs on the LinkedBlockingDeque. This aggregates them into >> a single bug report and PR. >> >> 1. LinkedBlockingDeque does not immediately throw InterruptedException in >> put/take >> >> The LinkedBlockingDeque does not beh

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-06-12 Thread Viktor Klang
On Thu, 12 Jun 2025 09:54:57 GMT, kabutz wrote: >>> About a month or so. >> >> Perfect, thanks @viktorklang-ora. I've marked the other issues as closed - >> duplicates, and referenced this single umbrella PR. > >> Great work, @kabutz — this is now ready to integrate. > > What are the next step

Integrated: 8355726: LinkedBlockingDeque fixes and improvements

2025-06-12 Thread kabutz
On Mon, 28 Apr 2025 15:23:18 GMT, kabutz wrote: > We logged several bugs on the LinkedBlockingDeque. This aggregates them into > a single bug report and PR. > > 1. LinkedBlockingDeque does not immediately throw InterruptedException in > put/take > > The LinkedBlockingDeque does not behave con

Re: RFR: 8358880: Performance of parsing with DecimalFormat can be improved [v3]

2025-06-12 Thread Justin Lu
On Thu, 12 Jun 2025 15:26:55 GMT, Johannes Graham wrote: >> src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1841: >> >>> 1839: >>> 1840: static ASCIIToBinaryConverter readDoubleSignlessDigits(int >>> decExp, char[] digits, int length) { >>> 1841: if (decExp

Re: RFR: 8338140: (str) Add notes to String.trim and String.isEmpty pointing to newer APIs [v3]

2025-06-12 Thread Stuart Marks
On Thu, 12 Jun 2025 01:54:40 GMT, Naoto Sato wrote: >> Oh yeah, that should be "an ASCII" >> >> But maybe we should change the wording per @naotoj's comment. I don't want >> to repeat the specification above, but rather I want to describe it in terms >> of what the thinking was at the time

Re: RFR: 8338140: (str) Add notes to String.trim and String.isEmpty pointing to newer APIs [v3]

2025-06-12 Thread Stuart Marks
> Add a note to String.trim pointing to the String.strip family of methods. > > Add notes cross-linking String.isBlank and String.isEmpty. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: Update wording per suggestion. -

Re: RFR: 8338140: (str) Add notes to String.trim and String.isEmpty pointing to newer APIs [v4]

2025-06-12 Thread Stuart Marks
On Thu, 12 Jun 2025 23:21:15 GMT, Stuart Marks wrote: >>> I'd describe this as "space plus ASCII control characters." Would something >>> like that make more sense? >> >> Yeah, I think so > > OK, I've updated the wording. Let me know if this is OK and I'll update the > CSR accordingly. Made a

Re: RFR: 8338140: (str) Add notes to String.trim and String.isEmpty pointing to newer APIs [v4]

2025-06-12 Thread Stuart Marks
> Add a note to String.trim pointing to the String.strip family of methods. > > Add notes cross-linking String.isBlank and String.isEmpty. Stuart Marks has updated the pull request incrementally with one additional commit since the last revision: More wording updates. - Changes:

Re: RFR: 8358729: jdk/internal/loader/URLClassPath/ClassnameCharTest.java depends on Applet [v4]

2025-06-12 Thread Justin Lu
> Please review this PR which finishes Applet removal for the test: > jdk/internal/loader/URLClassPath/ClassnameCharTest.java. > > `testclasses.jar` is updated such that the two classes no longer extend > Applet. > > > $ javap fo\ o.class > public class fo o { > } > $ javap æ$'\302\211'$'\302

Integrated: 8358819: The first year is not displayed correctly in Japanese Calendar

2025-06-12 Thread Naoto Sato
On Tue, 10 Jun 2025 18:36:15 GMT, Naoto Sato wrote: > This regression was introduced by the removal of the COMPAT locale provider, > which partially broke support for the first year in the Japanese calendar. In > the Japanese calendar system, the first year of an era should be formatted > usin

Re: RFR: 8358819: The first year is not displayed correctly in Japanese Calendar

2025-06-12 Thread Naoto Sato
On Tue, 10 Jun 2025 18:36:15 GMT, Naoto Sato wrote: > This regression was introduced by the removal of the COMPAT locale provider, > which partially broke support for the first year in the Japanese calendar. In > the Japanese calendar system, the first year of an era should be formatted > usin

Re: RFR: 8358729: jdk/internal/loader/URLClassPath/ClassnameCharTest.java depends on Applet [v2]

2025-06-12 Thread Justin Lu
On Thu, 12 Jun 2025 15:14:37 GMT, Jaikiran Pai wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Jai's review - dynamically create jar file > > test/jdk/jdk/internal/loader/URLClassPath/ClassnameCharTest.java line 46: >

Re: RFR: 8358729: jdk/internal/loader/URLClassPath/ClassnameCharTest.java depends on Applet [v3]

2025-06-12 Thread Justin Lu
> Please review this PR which finishes Applet removal for the test: > jdk/internal/loader/URLClassPath/ClassnameCharTest.java. > > `testclasses.jar` is updated such that the two classes no longer extend > Applet. > > > $ javap fo\ o.class > public class fo o { > } > $ javap æ$'\302\211'$'\302

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v8]

2025-06-12 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP > Client API](https://openjdk.org/jeps/517). > > The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP > Client API](https://bugs.openjdk.org/browse/JDK-8350588) > > This JEP propose

Re: RFR: 8357995: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner [core] [v6]

2025-06-12 Thread Naoto Sato
On Wed, 11 Jun 2025 10:43:47 GMT, Volkan Yazici wrote: >> Passes the `Charset` read from the `stdin.encoding` system property while >> creating `InputStreamReader` or `Scanner` instances for `System.in`. >> >> `stdin.encoding` is a recently added property for Java 25 in >> [JDK-8350703](https:

RFR: 8191963: Path.equals() and File.equals() return true for two different files on Windows

2025-06-12 Thread Brian Burkhalter
Replace logic in `java.io.WinNTFileSystems.compare(File,File)` with that from `sun.nio.fs.WindowsPath.compareTo(Path)`. - Commit messages: - 8191963: Path.equals() and File.equals() return true for two different files on Windows Changes: https://git.openjdk.org/jdk/pull/25788/file

Re: RFR: 8338140: (str) Add notes to String.trim and String.isEmpty pointing to newer APIs [v4]

2025-06-12 Thread Naoto Sato
On Thu, 12 Jun 2025 23:39:44 GMT, Stuart Marks wrote: >> Add a note to String.trim pointing to the String.strip family of methods. >> >> Add notes cross-linking String.isBlank and String.isEmpty. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8338140: (str) Add notes to String.trim and String.isEmpty pointing to newer APIs [v4]

2025-06-12 Thread Brian Burkhalter
On Thu, 12 Jun 2025 23:39:44 GMT, Stuart Marks wrote: >> Add a note to String.trim pointing to the String.strip family of methods. >> >> Add notes cross-linking String.isBlank and String.isEmpty. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-06-12 Thread Viktor Klang
On Thu, 12 Jun 2025 09:54:57 GMT, kabutz wrote: >>> About a month or so. >> >> Perfect, thanks @viktorklang-ora. I've marked the other issues as closed - >> duplicates, and referenced this single umbrella PR. > >> Great work, @kabutz — this is now ready to integrate. > > What are the next step

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-06-12 Thread kabutz
On Tue, 13 May 2025 13:16:45 GMT, kabutz wrote: >>> > @kabutz I think @AlanBateman might be able to have a look as well. >>> > As for timing, it seems to me most reasonable if this PR (if it is to be >>> > integrated) to go in _after_ JDK25 has been forked, to give enough time >>> > for JDK26 e

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements

2025-06-12 Thread Viktor Klang
On Thu, 12 Jun 2025 09:54:57 GMT, kabutz wrote: >>> About a month or so. >> >> Perfect, thanks @viktorklang-ora. I've marked the other issues as closed - >> duplicates, and referenced this single umbrella PR. > >> Great work, @kabutz — this is now ready to integrate. > > What are the next step

Re: RFR: 8358729: jdk/internal/loader/URLClassPath/ClassnameCharTest.java depends on Applet [v2]

2025-06-12 Thread Jaikiran Pai
On Wed, 11 Jun 2025 22:40:43 GMT, Justin Lu wrote: >> Please review this PR which finishes Applet removal for the test: >> jdk/internal/loader/URLClassPath/ClassnameCharTest.java. >> >> `testclasses.jar` is updated such that the two classes no longer extend >> Applet. >> >> >> $ javap fo\ o.

Re: RFR: 8358729: jdk/internal/loader/URLClassPath/ClassnameCharTest.java depends on Applet [v2]

2025-06-12 Thread Jaikiran Pai
On Wed, 11 Jun 2025 22:40:43 GMT, Justin Lu wrote: >> Please review this PR which finishes Applet removal for the test: >> jdk/internal/loader/URLClassPath/ClassnameCharTest.java. >> >> `testclasses.jar` is updated such that the two classes no longer extend >> Applet. >> >> >> $ javap fo\ o.

Re: RFR: 8358880: Performance of parsing with DecimalFormat can be improved [v4]

2025-06-12 Thread Johannes Graham
> This PR replaces construction of intermediate strings to be parsed with more > direct manipulation of numbers. It also has a more streamlined mechanism of > handling `Long.MIN_VALUE` when parsing longs by using `Long.parseUnsignedLong` > > As a small side-effect it also eliminates the use of a

Re: RFR: 8358880: Performance of parsing with DecimalFormat can be improved [v3]

2025-06-12 Thread Johannes Graham
On Wed, 11 Jun 2025 23:47:01 GMT, Justin Lu wrote: >> Johannes Graham has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1841: > >> 1839:

Re: RFR: 8358729: jdk/internal/loader/URLClassPath/ClassnameCharTest.java depends on Applet [v2]

2025-06-12 Thread Jaikiran Pai
On Wed, 11 Jun 2025 22:40:43 GMT, Justin Lu wrote: >> Please review this PR which finishes Applet removal for the test: >> jdk/internal/loader/URLClassPath/ClassnameCharTest.java. >> >> `testclasses.jar` is updated such that the two classes no longer extend >> Applet. >> >> >> $ javap fo\ o.

Re: RFR: 8359123: Misleading examples in jmod man page

2025-06-12 Thread Christian Stein
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote: > Please review my PR. This PR includes the following: > > - [ ] Fix a small typo in a word and copyright src/jdk.jlink/share/man/jmod.md line 183: > 181: `--target-platform` *platform* > 182: : Specifies the target platform. The

RFR: 8357089: Remove VFORK launch mechanism from Process implementation (linux)

2025-06-12 Thread Thomas Stuefe
(for JDK 26) Note: This PR is a continuation of the old PR here: https://github.com/openjdk/jdk/pull/25260; had to close the old one since I had Skara problems after the JDK25 split-off. See the companion CSR (https://bugs.openjdk.org/browse/JDK-8357090) for the ratio behind this removal. Pat

Integrated: 8359182: Use @requires instead of SkippedException for MaxPath.java

2025-06-12 Thread SendaoYan
On Wed, 11 Jun 2025 07:15:43 GMT, SendaoYan wrote: > Hi all, > > I think use `@requires (os.family == "windows")` is more elegant than thow > jtreg.SkippedException in test java/io/File/MaxPath.java. > > On linux before this PR, run this test jtreg report: > > > TEST: java/io/File/MaxPath.ja

Re: RFR: 8359182: Use @requires instead of SkippedException for MaxPath.java

2025-06-12 Thread SendaoYan
On Wed, 11 Jun 2025 22:37:53 GMT, Brent Christian wrote: >> Hi all, >> >> I think use `@requires (os.family == "windows")` is more elegant than thow >> jtreg.SkippedException in test java/io/File/MaxPath.java. >> >> On linux before this PR, run this test jtreg report: >> >> >> TEST: java/io/

RFR: 8359123: Misleading examples in jmod man page

2025-06-12 Thread Ana Maria Mihalceanu
Please review my PR. This PR includes the following: - [ ] Fix a small typo in a word and copyright - Commit messages: - Attempt to fix whitespaces - Apply suggestions from code review - Update jmod create examples - Update copyright text - Fix a small typo Changes: https://git

Withdrawn: 8349944: [JMH] sun.misc.UnsafeOps cannot access class jdk.internal.misc.Unsafe

2025-06-12 Thread duke
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote: > The UnsafeOps JMH benchmark fails with the following error: > > ``` > java.lang.IllegalAccessError: class > org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot > access class jdk.internal.misc.Unsafe (in m

Re: RFR: 8355726: LinkedBlockingDeque fixes and improvements [v10]

2025-06-12 Thread Viktor Klang
On Wed, 11 Jun 2025 19:44:20 GMT, kabutz wrote: >> We logged several bugs on the LinkedBlockingDeque. This aggregates them into >> a single bug report and PR. >> >> 1. LinkedBlockingDeque does not immediately throw InterruptedException in >> put/take >> >> The LinkedBlockingDeque does not beh