Re: Namespace Prefix Issue in XML to XSL Transformation

2025-05-01 Thread Joe Wang
Hi Hempushpa, You may want to talk to Christoph on JDK-8168664, he might have temped a fix at the time. Otherwise, feel free to create a new bug and PR, and we can start from there. Thanks, Joe On 4/23/25 7:03 AM, Hempushpa Sahu wrote: Problem Description : XSLT transformation creating

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v9]

2025-05-01 Thread Jan Lahoda
> This is a PR that implements JEP: Compact Source Files and Instance Main > Methods. Changes include: > - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()` > to implement the methods (thanks to @stuart-marks) > - `java. ... .IO` is no longer automatically imported in an

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v9]

2025-05-01 Thread Chen Liang
On Fri, 2 May 2025 00:54:24 GMT, Jan Lahoda wrote: >> This is a PR that implements JEP: Compact Source Files and Instance Main >> Methods. Changes include: >> - `java.io.IO` moved to `java.lang.IO`, and no longer uses >> `System.console()` to implement the methods (thanks to @stuart-marks) >> -

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v8]

2025-05-01 Thread Stuart Marks
On Thu, 1 May 2025 18:43:57 GMT, Chen Liang wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updating copyright year. > > src/java.base/share/classes/java/lang/IO.java line 157: > >> 155: * >> 156: * Write

RFR: 8356050: Problemlist jdk & langtools tier1 tests requiring runtime usages of /bin/tools for static-jdk

2025-05-01 Thread Jiangli Zhou
Please review this PR to problemlist jdk & langtools tier1 tests requiring runtime usages of /bin/tools, for testing on static-jdk. The affected tests using following tools at runtime: - javac - javadoc - jar - jarsigner - jimage - jps - Commit messages: - Merge branch 'openjdk:ma

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Maurizio Cimadamore
On Thu, 1 May 2025 09:04:00 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve on comments > > src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 81: > >> 79:

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Maurizio Cimadamore
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote: >> This PR is based on the work of @mernst-github and aims to implement an >> _internal_ thread-local 'stack' allocator, which works like a dynamically >> sized arena, but with reset functionality to reset the allocated size back >> to a cer

Re: JavaDoc fix in java.util.Date

2025-05-01 Thread Steffen Nießing
Thanks for all these helpful responses. So I guess there's nothing to do here except we want to integrate the change proposed by Chen to update the expression to use Long.hashCode. Cheers, Steffen Ursprüngliche Nachricht Am 30.04.25 23:25 schrieb Roger Riggs : > Hi Steffen, >

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Maurizio Cimadamore
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote: >> This PR is based on the work of @mernst-github and aims to implement an >> _internal_ thread-local 'stack' allocator, which works like a dynamically >> sized arena, but with reset functionality to reset the allocated size back >> to a cer

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Maurizio Cimadamore
On Thu, 1 May 2025 09:22:57 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve on comments > > src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 163: > >> 161:

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Maurizio Cimadamore
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote: >> This PR is based on the work of @mernst-github and aims to implement an >> _internal_ thread-local 'stack' allocator, which works like a dynamically >> sized arena, but with reset functionality to reset the allocated size back >> to a cer

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v11]

2025-05-01 Thread Chen Liang
On Thu, 1 May 2025 08:45:06 GMT, Markus KARG wrote: >> This Pull Request proposes an implementation for >> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new >> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int >> dstBegin)` to the `CharSequence` in

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods

2025-05-01 Thread Chen Liang
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote: > Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 315: > 313: * WARNING: The caller of

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v11]

2025-05-01 Thread Markus KARG
On Thu, 1 May 2025 12:56:42 GMT, Chen Liang wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Applied proposal by Daniel: If there's no change to this file the >> copyright year update could be reverted? > > src/java

Re: RFR: 8355954: File.delete removes read-only files (win)

2025-05-01 Thread Alan Bateman
On Wed, 30 Apr 2025 23:38:02 GMT, Brian Burkhalter wrote: > This change proposes to modify `java.io.File.delete()` so that regular files > on Windows will not be deleted by default if their read-only attribute is > set. A boolean-valued system compatibility property > `jdk.io.File.deleteReadOn

Re: RFR: 8356021: Use Double::hashCode in java.util.Locale::hashCode

2025-05-01 Thread Naoto Sato
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote: > Similar to #24959, java.util.Locale.hashCode can also make the same > improvement. > > Replace manual bitwise operations in hashCode implementations of > java.util.Locale with Double::hashCode. Thanks for the fix. Even though the fix is t

Re: RFR: 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe [v3]

2025-05-01 Thread Chen Liang
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set. Chen Liang has updated the pull request incrementally with one additional commit since the last revision: Review suggestions - Changes: - all: https://git.openjdk.org/jdk/pull/23757/files - new: https://gi

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v14]

2025-05-01 Thread Stuart Marks
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Fix readAllChars gaffe in Reader returned by

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v7]

2025-05-01 Thread Jan Lahoda
> This is a PR that implements JEP: Compact Source Files and Instance Main > Methods. Changes include: > - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()` > to implement the methods (thanks to @stuart-marks) > - `java. ... .IO` is no longer automatically imported in an

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v8]

2025-05-01 Thread Jan Lahoda
> This is a PR that implements JEP: Compact Source Files and Instance Main > Methods. Changes include: > - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()` > to implement the methods (thanks to @stuart-marks) > - `java. ... .IO` is no longer automatically imported in an

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v14]

2025-05-01 Thread Stuart Marks
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Fix readAllChars gaffe in Reader returned by

Re: RFR: 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe [v3]

2025-05-01 Thread Chen Liang
On Thu, 1 May 2025 16:34:14 GMT, Chen Liang wrote: >> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Review suggestions Thanks for the reviews. On baselin

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v3]

2025-05-01 Thread erifan
On Tue, 29 Apr 2025 10:22:22 GMT, Emanuel Peter wrote: >> erifan has updated the pull request with a new target base due to a merge or >> a rebase. The incremental webrev excludes the unrelated changes brought in >> by the merge/rebase. The pull request contains four additional commits since >

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v7]

2025-05-01 Thread Chen Liang
On Wed, 30 Apr 2025 22:12:20 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. This is useful for clients like javap to report the correct >> undefined flags for different class file versions. >> >> A preparatory patch for javap

Re: RFR: 8355954: File.delete removes read-only files (win)

2025-05-01 Thread Brian Burkhalter
On Thu, 1 May 2025 15:03:02 GMT, Jason Mehrens wrote: > Will the new property will also change behavior of java.io.File.deleteOnExit() Yes, as that calls `File.delete`. > and java.nio.file.StandardOpenOption.DELETE_ON_CLOSE? No. - PR Comment: https://git.openjdk.org/jdk/pull/2497

Integrated: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version

2025-05-01 Thread Chen Liang
On Fri, 18 Apr 2025 20:33:27 GMT, Chen Liang wrote: > Take the class file version to reject flags not yet defined, redefined, or > obsoleted. This is useful for clients like javap to report the correct > undefined flags for different class file versions. > > A preparatory patch for javap to pa

Re: RFR: 8355954: File.delete removes read-only files (win)

2025-05-01 Thread Jason Mehrens
On Wed, 30 Apr 2025 23:38:02 GMT, Brian Burkhalter wrote: > This change proposes to modify `java.io.File.delete()` so that regular files > on Windows will not be deleted by default if their read-only attribute is > set. A boolean-valued system compatibility property > `jdk.io.File.deleteReadOn

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v10]

2025-05-01 Thread Markus KARG
> This Pull Request proposes an implementation for > [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new > method `public void getChars(int srcBegin, int srcEnd, char[] dst, int > dstBegin)` to the `CharSequence` interface, providing a **bulk-read** > facility including a

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v9]

2025-05-01 Thread Markus KARG
On Wed, 30 Apr 2025 21:57:07 GMT, Joe Darcy wrote: >> Unfortunately the same happens. 🙁 > > The following javadoc for String's getChars method has, I believe, the > desired effect: > > > /** > * {@inheritDoc CharSequence} > * @param srcBegin {@inheritDoc CharSequence} > * @p

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v4]

2025-05-01 Thread erifan
> This patch optimizes the following patterns: > For integer types: > > (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1)) > => (VectorMaskCmp src1 src2 ncond) > (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1)) > => (VectorMaskCmp src1 src2 ncond) > > cond can be eq, ne, le, ge, l

Re: RFR: 8353888: Implement JEP 510: Key Derivation Function API [v5]

2025-05-01 Thread Weijun Wang
> Finalize the KDF API. Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - merge - add a positive debug log and update exception message - enhancing exception messages and debug outputs - update @since tags

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API

2025-05-01 Thread Vicente Romero
On Fri, 18 Apr 2025 02:32:06 GMT, Chen Liang wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or cons

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API

2025-05-01 Thread Chen Liang
On Fri, 18 Apr 2025 00:06:26 GMT, Vicente Romero wrote: > This PR is defining a new internal annotation, > `@jdk.internal.RequiresIdentity`, with target types PARAMETER and > TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation > that an argument to a given method or cons

Re: RFR: 8355698: JDK not supporting sleef could cause exception at runtime after JDK-8353786

2025-05-01 Thread Hamlin Li
On Wed, 30 Apr 2025 19:41:52 GMT, Vladimir Ivanov wrote: > Overall, it still looks like a JDK build issue to me. Hiding problems > occurred during the build is not good. If some toolchains can't successfully > build the library, the library shouldn't be included in JDK. No, in riscv case (poss

Integrated: 8344708: Implement JEP 511: Module Import Declarations

2025-05-01 Thread Jan Lahoda
On Wed, 26 Feb 2025 13:50:52 GMT, Jan Lahoda wrote: > This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 This pull request has now been integrated. Changeset: 0a697f6f Author:Jan Lahoda URL: https://git.openjdk.org/jdk/c

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Maurizio Cimadamore
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote: >> This PR is based on the work of @mernst-github and aims to implement an >> _internal_ thread-local 'stack' allocator, which works like a dynamically >> sized arena, but with reset functionality to reset the allocated size back >> to a cer

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v7]

2025-05-01 Thread Roger Riggs
On Wed, 30 Apr 2025 22:12:20 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. This is useful for clients like javap to report the correct >> undefined flags for different class file versions. >> >> A preparatory patch for javap

Re: RFR: 8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset [v7]

2025-05-01 Thread Lance Andersen
On Thu, 1 May 2025 01:15:26 GMT, Jaikiran Pai wrote: > > I think throwing the SkippedException is the right way to go long term but > > I assume this shows as a reported failure in Mach5 and in the case of > > assumeTrue it does not result in a failure being reported? > > That is correct, use

Re: RFR: 8356021: Use Double::hashCode in java.util.Locale::hashCode

2025-05-01 Thread Roger Riggs
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote: > Similar to #24959, java.util.Locale.hashCode can also make the same > improvement. > > Replace manual bitwise operations in hashCode implementations of > java.util.Locale with Double::hashCode. lgltm - Marked as reviewed by

Re: RFR: 8356021: Use Double::hashCode in java.util.Locale::hashCode

2025-05-01 Thread Chen Liang
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote: > Similar to #24959, java.util.Locale.hashCode can also make the same > improvement. > > Replace manual bitwise operations in hashCode implementations of > java.util.Locale with Double::hashCode. Thanks for this cleanup, indeed equivalent.

Re: RFR: 8354334: Remove @ValueBased from ProcessHandle

2025-05-01 Thread Chen Liang
On Thu, 1 May 2025 13:36:13 GMT, Roger Riggs wrote: > Remove internal ValueBased annotation from the ProcessHandle interface > declaration. > The implementation remains value based as described in the javadoc. > Remove unnecessary "public" keyword in interfaces and cleanup javadoc. Good cleanu

Re: RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java

2025-05-01 Thread Oleksii Sylichenko
On Thu, 6 Mar 2025 13:34:07 GMT, Oleksii Sylichenko wrote: > This PR proposes three improvements to the `Basic.java` test: > > 1. Increase Timeout >- The current timeout is insufficient when running the test in IntelliJ > IDEA. >- I propose increasing it by one minute. >- The timeou

Re: RFR: 8355954: File.delete removes read-only files (win) [v2]

2025-05-01 Thread Brian Burkhalter
> This change proposes to modify `java.io.File.delete()` so that regular files > on Windows will not be deleted by default if their read-only attribute is > set. A boolean-valued system compatibility property > `jdk.io.File.deleteReadOnly` is defined to reinstate legacy behavior if > desired.

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v14]

2025-05-01 Thread Stuart Marks
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Fix readAllChars gaffe in Reader returned by

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v5]

2025-05-01 Thread Naoto Sato
On Thu, 1 May 2025 16:55:06 GMT, Stuart Marks wrote: >> `stdin.encoding` seems to work as intended in Windows for Japanese. (I >> managed to get the Windows binary of my PR) No need to change. (I wish the >> constructors of `InputStreamReader` and `Scanner` used `stdin.encoding` >> instead of

Re: RFR: 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe [v2]

2025-05-01 Thread Jaikiran Pai
On Wed, 30 Apr 2025 23:02:24 GMT, Chen Liang wrote: >> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the

Re: RFR: 8355954: File.delete removes read-only files (win)

2025-05-01 Thread Brian Burkhalter
On Thu, 1 May 2025 12:40:41 GMT, Alan Bateman wrote: > It will need a release note too. The issue is already so labelled. - PR Comment: https://git.openjdk.org/jdk/pull/24977#issuecomment-2845119678

Integrated: 8356021: Use Double::hashCode in java.util.Locale::hashCode

2025-05-01 Thread Shaojin Wen
On Wed, 30 Apr 2025 18:01:08 GMT, Shaojin Wen wrote: > Similar to #24959, java.util.Locale.hashCode can also make the same > improvement. > > Replace manual bitwise operations in hashCode implementations of > java.util.Locale with Double::hashCode. This pull request has now been integrated.

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v5]

2025-05-01 Thread Tatsunori Uchino
On Sun, 27 Apr 2025 14:23:50 GMT, Tatsunori Uchino wrote: >> I misunderstood that I have tested `stdin.encoding`. >> I cannot confirm that `stdin.encoding` is changed in Windows to proper ones >> because it has not been included in the latest EA build (20) and I cannot >> build master for Windo

RFR: 8354334: Remove @ValueBased from ProcessHandle

2025-05-01 Thread Roger Riggs
Remove internal ValueBased annotation from the ProcessHandle interface declaration. The implementation remains value based as described in the javadoc. Remove unnecessary "public" keyword in interfaces and cleanup javadoc. - Commit messages: - 8354334: Remove @ValueBased from Proce

Re: RFR: 8355954: File.delete removes read-only files (win)

2025-05-01 Thread Brian Burkhalter
On Thu, 1 May 2025 16:16:22 GMT, Alan Bateman wrote: > [...] we will need to find everything that might be accidentally depending on > the behavior. So far I found only `SetAccess` but there is more testing to do, as well as code scanning. - PR Comment: https://git.openjdk.org/jd

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Jorn Vernee
On Thu, 1 May 2025 10:20:44 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 163: >> >>> 161: lock.unlock(); >>> 162: } >>> 163: Reference.reachabilityFence(arena); >> >> I'm not sure t

Integrated: 8354084: Streamline XPath API's extension function control

2025-05-01 Thread Joe Wang
On Fri, 11 Apr 2025 23:05:51 GMT, Joe Wang wrote: > Streamline the extension function control in the XPath API by relying solely > on > [XPathFunctionResolver](https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/xpath/XPathFunctionResolver.html), > which provides a secure and

Re: RFR: 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe [v3]

2025-05-01 Thread Jorn Vernee
On Thu, 1 May 2025 16:34:14 GMT, Chen Liang wrote: >> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Review suggestions Changes look good. Thanks! --

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v11]

2025-05-01 Thread Markus KARG
On Thu, 1 May 2025 16:23:13 GMT, Joe Darcy wrote: >> I can open a bug report, but I think text parity makes no sense: There are >> lots of other places in OpenJDK where the short form is used already, so >> there will not be any benefit of text parity with just one other code >> location, but

Re: RFR: 8354424: java/util/logging/LoggingDeadlock5.java fails intermittently in tier6 [v2]

2025-05-01 Thread Joe Darcy
On Thu, 24 Apr 2025 16:24:53 GMT, Stuart Marks wrote: >> Hi Joe, yes `adjustTimeout` will scale based on the jtreg timeout factor. I >> believe the behaviour is to multiply whatever hardcoded timeout is passed by >> the timeout factor. >> On lower tiers, in our CI, I beleive it means the test w

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Maurizio Cimadamore
On Thu, 1 May 2025 09:05:58 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 81: >> >>> 79: @Override >>> 80: public int hashCode() { >>> 81: return System.identityHashCode(this); >> >> What's the value in these overloads

Re: RFR: 8349146: [REDO] Implement a better allocator for downcalls [v6]

2025-05-01 Thread Maurizio Cimadamore
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote: >> This PR is based on the work of @mernst-github and aims to implement an >> _internal_ thread-local 'stack' allocator, which works like a dynamically >> sized arena, but with reset functionality to reset the allocated size back >> to a cer

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v4]

2025-05-01 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for > the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). > > The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client > API](https://bugs.openjdk.org/browse/JDK-8350588) > > Th

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v11]

2025-05-01 Thread Markus KARG
> This Pull Request proposes an implementation for > [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new > method `public void getChars(int srcBegin, int srcEnd, char[] dst, int > dstBegin)` to the `CharSequence` interface, providing a **bulk-read** > facility including a

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v8]

2025-05-01 Thread Markus KARG
On Mon, 28 Apr 2025 13:29:06 GMT, Daniel Fuchs wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Applied changes proposed in response to Joe's CSR comments: 'understood >> for CharBuffer; I was thinking more of Strin

Re: RFR: 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe [v2]

2025-05-01 Thread Chen Liang
On Wed, 30 Apr 2025 23:02:24 GMT, Chen Liang wrote: >> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the

RFR: 8354556: Expand value-based class warnings to java.lang.ref API

2025-05-01 Thread Vicente Romero
This PR is defining a new internal annotation, `@jdk.internal.RequiresIdentity`, with target types PARAMETER and TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation that an argument to a given method or constructor parameter will be an object with a unique identity, not a

Re: RFR: 8355954: File.delete removes read-only files (win)

2025-05-01 Thread Alan Bateman
On Thu, 1 May 2025 15:54:39 GMT, Brian Burkhalter wrote: > > Will the new property will also change behavior of > > java.io.File.deleteOnExit() > > Yes, as that calls `File.delete`. Jason's message is a reminder that we will need to find everything that might be accidentally depending on the

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v11]

2025-05-01 Thread Joe Darcy
On Thu, 1 May 2025 13:03:47 GMT, Markus KARG wrote: >> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 488: >> >>> 486: /** >>> 487: * {@inheritDoc CharSequence} >>> 488: */ >> >> Suggestion: >> >> * {@inheritDoc CharSequence} >> * @param srcBegin

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v5]

2025-05-01 Thread Stuart Marks
On Thu, 1 May 2025 09:51:41 GMT, Tatsunori Uchino wrote: >> Anyway you need to merge master first to test `stdin.encoding`. > > `stdin.encoding` seems to work as intended in Windows for Japanese. (I > managed to get the Windows binary of my PR) No need to change. (I wish the > constructors of `

Re: RFR: 8351443: Improve robustness of StringBuilder

2025-05-01 Thread Hendrik Schick
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote: > Refactor AbstractStringBuilder to maintain consistency among count, coder, > and value buffers while the buffer capacity is being expanded and/or inflated > from Latin1 to UTF16 representations. > The refactoring pattern is to read and wri

Re: RFR: 8354890: AOT-initialize j.l.i.MethodHandleImpl and inner classes

2025-05-01 Thread Andrew Dinn
On Tue, 29 Apr 2025 22:59:29 GMT, Ioi Lam wrote: > This is a general fix for all the "points to a static field that may hold a > different value" failures related to `java/lang/invoke/MethodHandleImpl`. > E.g., [JDK-8354840](https://bugs.openjdk.org/browse/JDK-8354840), > [JDK-8353330](https:/

Re: RFR: 8355954: File.delete removes read-only files (win) [v2]

2025-05-01 Thread Brian Burkhalter
On Thu, 1 May 2025 12:40:02 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8355954: Address comments on naming in the PR > > src/java.base/windows/classes/java/io/WinNTFileSystem.java line 45

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v8]

2025-05-01 Thread Vicente Romero
On Thu, 1 May 2025 17:48:22 GMT, Jan Lahoda wrote: >> This is a PR that implements JEP: Compact Source Files and Instance Main >> Methods. Changes include: >> - `java.io.IO` moved to `java.lang.IO`, and no longer uses >> `System.console()` to implement the methods (thanks to @stuart-marks) >> -

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v11]

2025-05-01 Thread Roger Riggs
On Tue, 22 Apr 2025 16:51:05 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8354724: Add Reader.readAllLines; test not yet updated > > src/java.base/share/classes/java/io/Reader.java line 403

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v5]

2025-05-01 Thread Tatsunori Uchino
On Thu, 1 May 2025 17:40:56 GMT, Naoto Sato wrote: >> Hello @tats-u , there is no bother, I appreciate you looking at this. >> >> The addition of `stdin.encoding` in >> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703) (#24738) happened >> very quickly. I worked with @naotoj and @Alan

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via UTF16::compress & Unsafe::copyMemory [v4]

2025-05-01 Thread Markus KARG
On Fri, 2 May 2025 03:49:39 GMT, Shaojin Wen wrote: >> In BufferedReader.readLine and other similar scenarios, we need to use >> StringBuilder.append(char[]) to build the string. >> >> For these scenarios, we can use the intrinsic method StringUTF16.compress >> and Unsafe.copyMemory instead of

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via UTF16::compress & Unsafe::copyMemory [v4]

2025-05-01 Thread Shaojin Wen
On Fri, 2 May 2025 03:49:39 GMT, Shaojin Wen wrote: >> In BufferedReader.readLine and other similar scenarios, we need to use >> StringBuilder.append(char[]) to build the string. >> >> For these scenarios, we can use the intrinsic method StringUTF16.compress >> and Unsafe.copyMemory instead of

Re: RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java

2025-05-01 Thread Roger Riggs
On Thu, 6 Mar 2025 13:34:07 GMT, Oleksii Sylichenko wrote: > This PR proposes three improvements to the `Basic.java` test: > > 1. Increase Timeout >- The current timeout is insufficient when running the test in IntelliJ > IDEA. >- I propose increasing it by one minute. >- The timeou

Re: RFR: 8355698: JDK not supporting sleef could cause exception at runtime after JDK-8353786

2025-05-01 Thread Vladimir Ivanov
On Mon, 28 Apr 2025 10:34:49 GMT, Hamlin Li wrote: > Hi, > Can you help to review this patch? > > Before [JDK-8353786](https://bugs.openjdk.org/browse/JDK-8353786), when a > released jdk not supportting sleef (for any reason, e.g. low gcc version, > intrinsic not supported, rvv not supported,

Re: RFR: 8351443: Improve robustness of StringBuilder [v2]

2025-05-01 Thread Roger Riggs
> Refactor AbstractStringBuilder to maintain consistency among count, coder, > and value buffers while the buffer capacity is being expanded and/or inflated > from Latin1 to UTF16 representations. > The refactoring pattern is to read and write AbstractStringBuilder fields > once using locals fo

Re: RFR: 8356021: Use Double::hashCode in java.util.Locale::hashCode

2025-05-01 Thread Shaojin Wen
On Thu, 1 May 2025 16:27:17 GMT, Naoto Sato wrote: >> Similar to #24959, java.util.Locale.hashCode can also make the same >> improvement. >> >> Replace manual bitwise operations in hashCode implementations of >> java.util.Locale with Double::hashCode. > > Thanks for the fix. Even though the fi

Re: RFR: 8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" [v9]

2025-05-01 Thread Brent Christian
> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear > up the intermittent failures: > > * run with `othervm`: this test blocks the (global) finalizer thread, and > also requires the (global) finalizer thread to enter the test's `finalize()` > method > * The test uses `

Re: RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java

2025-05-01 Thread Roger Riggs
On Thu, 1 May 2025 20:27:01 GMT, Oleksii Sylichenko wrote: >> test/jdk/java/lang/ProcessBuilder/Basic.java line 1843: >> >>> 1841: >>> // >>> 1842: try { >>> 1843: String[] cmdp = Windows.is() ? new Stri

Re: RFR: 8354424: java/util/logging/LoggingDeadlock5.java fails intermittently in tier6 [v2]

2025-05-01 Thread Daniel Fuchs
On Thu, 1 May 2025 17:26:48 GMT, Joe Darcy wrote: >> Note, the timeout factor also adjusts the jtreg timeout for the entire test. >> The adjustTimeout() method allows internal test timeouts to scale along with >> the jtreg timeout. > >> Hi Joe, yes `adjustTimeout` will scale based on the jtreg

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v13]

2025-05-01 Thread Kim Barrett
On Tue, 18 Feb 2025 14:33:16 GMT, Aleksey Shipilev wrote: >> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` >> implementation. That implementation carries a doubly-linked list, and so >> makes DBB suffer from the same issue fixed for generic >> `java.lang.ref.Cleaner` users w

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v5]

2025-05-01 Thread Tatsunori Uchino
On Thu, 1 May 2025 23:33:00 GMT, Tatsunori Uchino wrote: >> `InputStreamReader` and `Scanner` taking `stdin.encoding` is an interesting >> idea, but would introduce compatiblity concerns. It would have been simpler >> if we had `stdin/out/err.encoding` system properties prior to JEP 400. >> As

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v12]

2025-05-01 Thread Shaojin Wen
On Thu, 7 Sep 2023 19:27:14 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per fra

Re: RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java

2025-05-01 Thread Oleksii Sylichenko
On Thu, 1 May 2025 19:24:13 GMT, Roger Riggs wrote: >> This PR proposes three improvements to the `Basic.java` test: >> >> 1. Increase Timeout >>- The current timeout is insufficient when running the test in IntelliJ >> IDEA. >>- I propose increasing it by one minute. >>- The timeou

Re: RFR: 8352480: Don't follow symlinks in additional content for app images

2025-05-01 Thread Mikhail Yankelevich
On Wed, 30 Apr 2025 20:17:57 GMT, Alexander Matveev wrote: > - Symbolic links will not be followed for `--app-content` on all platforms. > - Added test to cover this case. > - `MacHelper` updated to use "cp -R" instead of "cp -r" when unpacking DMG, > since "cp -r" on macOS is not documented op

Re: RFR: 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe [v4]

2025-05-01 Thread Chen Liang
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set. Chen Liang has updated the pull request incrementally with one additional commit since the last revision: Missed bug id - Changes: - all: https://git.openjdk.org/jdk/pull/23757/files - new: https://git.ope

Re: RFR: 8347009: Speed ​​up parseInt and parseLong [v21]

2025-05-01 Thread Shaojin Wen
> This is an optimization for decimal Integer.parseInt and Long.parseLong, > which improves performance by about 10%. The optimization includes: > 1. Improve performance by parsing 2 numbers at a time, which has performance > improvements for numbers with length >= 3. > 2. It uses charAt(0) for t

Re: RFR: 8349176: Speed up Integer/Long.toString via StringConcatHelper::newArray [v3]

2025-05-01 Thread Shaojin Wen
> The byte[] allocated in Integer/Long.toString is fully filled, so we can use > StringConcatHelper::newArray to create byte[] to improve performance. Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merg

Re: RFR: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods [v8]

2025-05-01 Thread Chen Liang
On Thu, 1 May 2025 17:48:22 GMT, Jan Lahoda wrote: >> This is a PR that implements JEP: Compact Source Files and Instance Main >> Methods. Changes include: >> - `java.io.IO` moved to `java.lang.IO`, and no longer uses >> `System.console()` to implement the methods (thanks to @stuart-marks) >> -

Re: RFR: 8353489: Increase timeout and improve Windows compatibility in test/jdk/java/lang/ProcessBuilder/Basic.java

2025-05-01 Thread Oleksii Sylichenko
On Thu, 1 May 2025 21:30:30 GMT, Roger Riggs wrote: >> In Windows CMD, the `echo` command, when called without arguments, displays >> the current state of the command echoing mode — either enabled (`ON`) or >> disabled (`OFF`). For the case when this test is run from IntelliJ IDEA. >> >> And t

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v14]

2025-05-01 Thread Roger Riggs
On Thu, 1 May 2025 17:51:53 GMT, Stuart Marks wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8354724: Fix readAllChars gaffe in Reader returned by Readed.of and >> account for it in test > > src/java.base/sha

Re: RFR: 8351443: Improve robustness of StringBuilder [v2]

2025-05-01 Thread Shaojin Wen
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8351443: Improve robustness of StringBuilder [v2]

2025-05-01 Thread Shaojin Wen
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Integrated: 8344706: Implement JEP 512: Compact Source Files and Instance Main Methods

2025-05-01 Thread Jan Lahoda
On Fri, 4 Apr 2025 07:20:23 GMT, Jan Lahoda wrote: > This is a PR that implements JEP: Compact Source Files and Instance Main > Methods. Changes include: > - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()` > to implement the methods (thanks to @stuart-marks) > - `jav

Re: RFR: 8351443: Improve robustness of StringBuilder [v2]

2025-05-01 Thread Shaojin Wen
On Thu, 1 May 2025 21:08:29 GMT, Roger Riggs wrote: >> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via UTF16::compress & Unsafe::copyMemory

2025-05-01 Thread Markus KARG
On Mon, 21 Apr 2025 15:19:40 GMT, Chen Liang wrote: > This might be helpful combined with #21730. That implies creating a copy of the chars: private final void appendChars(CharSequence s, int off, int end) { if (isLatin1()) { byte[] val = this.value; // - Begin of Expe

Re: RFR: 8354242: VectorAPI: combine vector not operation with compare [v4]

2025-05-01 Thread Emanuel Peter
On Fri, 2 May 2025 06:14:19 GMT, Emanuel Peter wrote: >> erifan has updated the pull request with a new target base due to a merge or >> a rebase. The incremental webrev excludes the unrelated changes brought in >> by the merge/rebase. The pull request contains six additional commits since >>

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v12]

2025-05-01 Thread Shaojin Wen
On Thu, 7 Sep 2023 19:27:14 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per fra

Re: RFR: 8355177: Speed up StringBuilder::append(char[]) via UTF16::compress & Unsafe::copyMemory [v4]

2025-05-01 Thread Shaojin Wen
> In BufferedReader.readLine and other similar scenarios, we need to use > StringBuilder.append(char[]) to build the string. > > For these scenarios, we can use the intrinsic method StringUTF16.compress and > Unsafe.copyMemory instead of the character copy of the char-by-char loop to > improve

  1   2   >