On Wed, 26 Mar 2025 17:31:47 GMT, Aleksey Shipilev wrote:
>> When jspawnhelper fails for whatever reason, but more prominently due to
>> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
>> the errors into stdout, but not to the relevant `IOException`. So, if the
>> ap
On Wed, 30 Apr 2025 10:19:54 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Wed, 30 Apr 2025 14:29:45 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 353:
>>
>>> 351: for (ReferenceKey key : map.keySet()) {
>>> 352: Object referent = key.get();
>>> 353: if (referent == null) {
>>
>> S
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote:
> Replace manual bitwise operations in `hashCode` implementations of
> `java.time` with `Long::hashCode`.
lgtm
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24959#pullrequestreview-280
On Sun, 23 Mar 2025 08:55:33 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 384:
>>
>>> 382: * @param fallback the fallback ZipCoder to return if the entry
>>> doesn't require UTF-8
>>> 383: */
>>> 384: private static ZipCoder zipCoderFor
On Wed, 30 Apr 2025 10:55:41 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cer
On Wed, 30 Apr 2025 14:14:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote:
> Replace manual bitwise operations in `hashCode` implementations of
> `java.time` with `Long::hashCode`.
Looks fine! Thanks for this cleanup.
-
Marked as reviewed by pminborg (Reviewer).
PR Review: https://git.openjdk.org/jd
On Mon, 28 Apr 2025 14:36:33 GMT, Chen Liang wrote:
>> Perf numbers for simple main:
>> Linking of `Class::forName0` down from ~152 to ~83
>>
>> For calling little color management system
>> https://bugs.openjdk.org/browse/JDK-8313344:
>> JNI: ~45
>> baseline panama: ~164
>> patch: ~103
>>
>>
> Hi, for you to consider.
>
> These tests constantly fails in qemu-user.
> Either the require host to be same arch explicit or implicit (sysroot).
> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not implemented'"
> for SA tests.
>
> From bug:
>> qemu-user/rv64 sets uarch to "qemu"
On Mon, 31 Mar 2025 10:45:54 GMT, Robbin Ehn wrote:
>> Hi, for you to consider.
>>
>> These tests constantly fails in qemu-user.
>> Either the require host to be same arch explicit or implicit (sysroot).
>> E.g. "ptrace(PTRACE_ATTACH, ..) failed for 405157: Function not
>> implemented'" for SA
On Wed, 30 Apr 2025 09:14:20 GMT, Viktor Klang wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 17 additional
>> commits sin
> Can I please get a review of this change which proposes to fix an issue
> `java.util.zip.ZipFile` which would cause failures when multiple instances of
> `ZipFile` using non-UTF8 `Charset` were operating against the same underlying
> ZIP file? This addresses https://bugs.openjdk.org/browse/JDK
> Improve StringBuilder getChar and putChar robustness with racy updates to
> StringBuilder.
> Test racing threads with append, insert, and reading characters.
Roger Riggs has updated the pull request incrementally with one additional
commit since the last revision:
Test cleanup
---
On Mon, 24 Feb 2025 23:47:02 GMT, Chen Liang wrote:
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
The changes look okay. I agree with Jaikiran that adding a stress test for this
would be good.
-
PR Review: https://git.openjdk.org/jdk/pull/23757#pullrequest
On Wed, 30 Apr 2025 12:20:39 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplified the formula for detecting overflows
>
> src/java.base/share/classes/java/math/BigInteger.java line 2
On Wed, 30 Apr 2025 13:46:57 GMT, Jorn Vernee wrote:
>> When LambdaForms are interpreted, so are field lambda forms. When this
>> happens, we may get into an infinite recursion due to field lambda forms
>> using `MethodHandleStatics.UNSAFE` via field lambda form.
>>
>> I think the best solutio
On Wed, 30 Apr 2025 13:13:30 GMT, Roger Riggs wrote:
>> Improve StringBuilder getChar and putChar robustness with racy updates to
>> StringBuilder.
>> Test racing threads with append, insert, and reading characters.
>
> Roger Riggs has updated the pull request incrementally with one additional
On Wed, 30 Apr 2025 13:13:30 GMT, Roger Riggs wrote:
>> Improve StringBuilder getChar and putChar robustness with racy updates to
>> StringBuilder.
>> Test racing threads with append, insert, and reading characters.
>
> Roger Riggs has updated the pull request incrementally with one additional
On Wed, 30 Apr 2025 13:04:18 GMT, Matthias Baesken wrote:
> Seems the currently used ATTRIBUTE_NO_UBSAN does not handle the exclusion of
> float divisions by zero.
> At least this is the case on AIX.
>
> (seen in the jtreg test java/lang/Math/PowTests.java )
LGTM
-
Marked as revi
On Wed, 30 Apr 2025 00:56:19 GMT, Ioi Lam wrote:
>> This PR contains 2 parts
>>
>> - Upstream of Soft/Weak Reference support authored by @macarte from [the
>> Leyden
>> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5)
>> - New C++ class `AOTReferenceObjS
On Wed, 30 Apr 2025 12:20:39 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplified the formula for detecting overflows
>
> src/java.base/share/classes/java/math/BigInteger.java line 2
On Wed, 23 Apr 2025 22:39:40 GMT, Chen Liang wrote:
> When LambdaForms are interpreted, so are field lambda forms. When this
> happens, we may get into an infinite recursion due to field lambda forms
> using `MethodHandleStatics.UNSAFE` via field lambda form.
>
> I think the best solution here
On Tue, 29 Apr 2025 14:10:30 GMT, Roger Riggs wrote:
> Improve StringBuilder getChar and putChar robustness with racy updates to
> StringBuilder.
> Test racing threads with append, insert, and reading characters.
This pull request has now been integrated.
Changeset: 4c695fa8
Author:Roger
On Tue, 29 Apr 2025 14:10:30 GMT, Roger Riggs wrote:
> Improve StringBuilder getChar and putChar robustness with racy updates to
> StringBuilder.
> Test racing threads with append, insert, and reading characters.
test/jdk/java/lang/StringBuilder/RacingSBThreads.java line 61:
> 59: // Cons
On Wed, 30 Apr 2025 00:56:19 GMT, Ioi Lam wrote:
>> This PR contains 2 parts
>>
>> - Upstream of Soft/Weak Reference support authored by @macarte from [the
>> Leyden
>> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5)
>> - New C++ class `AOTReferenceObjS
> This PR is based on the work of @mernst-github and aims to implement an
> _internal_ thread-local 'stack' allocator, which works like a dynamically
> sized arena, but with reset functionality to reset the allocated size back to
> a certain level. The underlying memory could stay around between
> This PR is based on the work of @mernst-github and aims to implement an
> _internal_ thread-local 'stack' allocator, which works like a dynamically
> sized arena, but with reset functionality to reset the allocated size back to
> a certain level. The underlying memory could stay around between
On Wed, 26 Mar 2025 17:31:47 GMT, Aleksey Shipilev wrote:
>> When jspawnhelper fails for whatever reason, but more prominently due to
>> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
>> the errors into stdout, but not to the relevant `IOException`. So, if the
>> ap
On Mon, 28 Apr 2025 14:36:33 GMT, Chen Liang wrote:
>> Perf numbers for simple main:
>> Linking of `Class::forName0` down from ~152 to ~83
>>
>> For calling little color management system
>> https://bugs.openjdk.org/browse/JDK-8313344:
>> JNI: ~45
>> baseline panama: ~164
>> patch: ~103
>>
>>
On Thu, 24 Apr 2025 10:37:59 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make public constuctor private
The other comments I had were
> This PR is based on the work of @mernst-github and aims to implement an
> _internal_ thread-local 'stack' allocator, which works like a dynamically
> sized arena, but with reset functionality to reset the allocated size back to
> a certain level. The underlying memory could stay around between
> Can I please get a review of this change which proposes to fix an issue
> `java.util.zip.ZipFile` which would cause failures when multiple instances of
> `ZipFile` using non-UTF8 `Charset` were operating against the same underlying
> ZIP file? This addresses https://bugs.openjdk.org/browse/JDK
On Wed, 30 Apr 2025 13:14:28 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 21 additional
>> commits
On Wed, 30 Apr 2025 00:56:19 GMT, Ioi Lam wrote:
>> This PR contains 2 parts
>>
>> - Upstream of Soft/Weak Reference support authored by @macarte from [the
>> Leyden
>> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5)
>> - New C++ class `AOTReferenceObjS
On Wed, 30 Apr 2025 10:55:41 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cer
On Wed, 30 Apr 2025 13:12:37 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 21 additional
>> commits
Refactor AbstractStringBuilder to maintain consistency among count, coder, and
value buffers while the buffer capacity is being expanded and/or inflated from
Latin1 to UTF16 representations.
The refactoring pattern is to read and write AbstractStringBuilder fields once
using locals for all inte
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
On Wed, 30 Apr 2025 14:00:10 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/BigInteger.java line 2737:
>>
>>> 2735: }
>>> 2736:
>>> 2737: return pow;
>>
>> Is there a reason this cannot simply be the traditional "repeated square"
>> method?
>> Why this compl
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
Seems the currently used ATTRIBUTE_NO_UBSAN does not handle the exclusion of
float divisions by zero.
At least this is the case on AIX.
(seen in the jtreg test java/lang/Math/PowTests.java )
-
Commit messages:
- JDK-8355979
Changes: https://git.openjdk.org/jdk/pull/24963/files
W
On Wed, 30 Apr 2025 13:13:30 GMT, Roger Riggs wrote:
>> Improve StringBuilder getChar and putChar robustness with racy updates to
>> StringBuilder.
>> Test racing threads with append, insert, and reading characters.
>
> Roger Riggs has updated the pull request incrementally with one additional
On Wed, 30 Apr 2025 12:02:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Wed, 30 Apr 2025 14:16:27 GMT, Kim Barrett wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed the internal field ReferenceQueue.NULL to NULL_QUEUE to avoid
>> failing hotspot/jtreg/sources/TestNoNULL.java
>
> s
> This Pull Request proposes an implementation for
> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
> dstBegin)` to the `CharSequence` interface, providing a **bulk-read**
> facility including a
> This PR is based on the work of @mernst-github and aims to implement an
> _internal_ thread-local 'stack' allocator, which works like a dynamically
> sized arena, but with reset functionality to reset the allocated size back to
> a certain level. The underlying memory could stay around between
> This PR is based on the work of @mernst-github and aims to implement an
> _internal_ thread-local 'stack' allocator, which works like a dynamically
> sized arena, but with reset functionality to reset the allocated size back to
> a certain level. The underlying memory could stay around between
On Wed, 30 Apr 2025 15:33:37 GMT, Markus KARG wrote:
>> This Pull Request proposes an implementation for
>> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
>> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
>> dstBegin)` to the `CharSequence` i
On Wed, 30 Apr 2025 13:43:28 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed the internal field ReferenceQueue.NULL to NULL_QUEUE to avoid
>> failing hotspot/jtreg/sources/TestNoNULL.java
>
>
On Wed, 30 Apr 2025 06:08:30 GMT, Alan Bateman wrote:
>> Comment simplified in 4cee3c2.
>
> Okay, just a bit puzzled as to why it doesn't run on Linux. The VM uses
> setrlimit(RLIMIT_NOFILE) to set the limit to the hard limit (rlim_max). So is
> the issue here that the hard limit less than 2050
On Wed, 30 Apr 2025 15:34:33 GMT, Markus KARG wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Applied changes proposed by Joe and Jaikiran: Using @inheritDoc to get
>> JavaDocs without @since.
>
> src/java.base/sha
The private key encoding formats of ML-KEM and ML-DSA are updated to match the
latest IERTF drafts at:
https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-08
and
https://datatracker.ietf.org/doc/html/draft-ietf-lamps-kyber-certificates-10.
New security/system properti
On Wed, 23 Apr 2025 14:12:29 GMT, Chen Liang wrote:
>> In offline discussion, we noted that the documentation on this annotation
>> does not recommend minimizing the intrinsified section and moving whatever
>> can be done in Java to Java; thus I prepared this documentation update, to
>> shrink
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cer
> This PR optimizes `BigInteger.pow(int)` method. The primary enhancement in
> `pow()` is not concerned most on execution time, but rather in memory
> optimization, because the PR implementation does the "shift of the exponent"
> squaring the result rather than the base, so the base is not squar
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote:
> Replace manual bitwise operations in `hashCode` implementations of
> `java.time` with `Long::hashCode`.
LGTM. Thanks for the refactoring
-
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/
On Mon, 10 Mar 2025 18:11:23 GMT, Per Minborg wrote:
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
This pull request has now been integrated.
Changeset: fbc4691b
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/fbc4691bfa11f31601fd89d05da63e689343e214
Stats:
On Fri, 25 Apr 2025 09:57:38 GMT, Gautham Krishnan wrote:
> MET timezone entry in TimeZoneNames.java and TimeZoneNames_*.java needs to be
> updated as MET is alias to Europe/Brussels as per 2024b tzdata changes.
>
> Also Bug4848242.java needs to be removed as the test expects all euro locale
>
On Mon, 28 Apr 2025 14:36:33 GMT, Chen Liang wrote:
>> Perf numbers for simple main:
>> Linking of `Class::forName0` down from ~152 to ~83
>>
>> For calling little color management system
>> https://bugs.openjdk.org/browse/JDK-8313344:
>> JNI: ~45
>> baseline panama: ~164
>> patch: ~103
>>
>>
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
On Tue, 29 Apr 2025 19:48:01 GMT, Chen Liang wrote:
>> Take the class file version to reject flags not yet defined, redefined, or
>> obsoleted. This is useful for clients like javap to report the correct
>> undefined flags for different class file versions.
>>
>> A preparatory patch for javap
> Take the class file version to reject flags not yet defined, redefined, or
> obsoleted. This is useful for clients like javap to report the correct
> undefined flags for different class file versions.
>
> A preparatory patch for javap to pass around the ClassFileFormatVersion to
> parse flags
On Wed, 30 Apr 2025 17:45:04 GMT, Ioi Lam wrote:
>> This PR contains 2 parts
>>
>> - Upstream of Soft/Weak Reference support authored by @macarte from [the
>> Leyden
>> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5)
>> - New C++ class `AOTReferenceObjS
On Tue, 29 Apr 2025 22:22:19 GMT, Vladimir Ivanov wrote:
> Can you point me, please, to the relevant parts of the discussions? I wasn't
> part of them.
Sorry, I can not find out this specific answer for you, as there were too long
discussion there, the whole process took several months.
> Bot
On Wed, 30 Apr 2025 11:00:04 GMT, Hamlin Li wrote:
> It's arguable if missing entries is a bug, please check
> [JDK-8355656](https://bugs.openjdk.org/browse/JDK-8355656) for example
Personally, I'm surprised SVML is affected in a similar way because stubs are
provided in assembly form, so they
Hi,
Can you help to review this patch?
Before [JDK-8353786](https://bugs.openjdk.org/browse/JDK-8353786), when a
released jdk not supportting sleef (for any reason, e.g. low gcc version,
intrinsic not supported, rvv not supported, and so on) runs on machine support
vector operation (e.g. on ris
On Mon, 28 Apr 2025 10:34:49 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
>
> Before [JDK-8353786](https://bugs.openjdk.org/browse/JDK-8353786), when a
> released jdk not supportting sleef (for any reason, e.g. low gcc version,
> intrinsic not supported, rvv not supported,
On Mon, 28 Apr 2025 10:34:49 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
>
> Before [JDK-8353786](https://bugs.openjdk.org/browse/JDK-8353786), when a
> released jdk not supportting sleef (for any reason, e.g. low gcc version,
> intrinsic not supported, rvv not supported,
On Tue, 29 Apr 2025 02:40:01 GMT, SendaoYan wrote:
>> Hi,
>> Can you help to review this patch?
>>
>> Before [JDK-8353786](https://bugs.openjdk.org/browse/JDK-8353786), when a
>> released jdk not supportting sleef (for any reason, e.g. low gcc version,
>> intrinsic not supported, rvv not suppo
On Tue, 29 Apr 2025 09:16:39 GMT, Hamlin Li wrote:
> This behavour was decided in previous PRs
> https://github.com/openjdk/jdk/pull/20781,
> https://github.com/openjdk/jdk/pull/21083,
> https://github.com/openjdk/jdk/pull/21502, and some other uncommited PRs
> prior to these ones.
Can you p
Unsigned right shift is non-existent?
"The operators << (left shift), >> (signed right shift), and >>>
(unsigned right shift) are called the shift operators. The left-hand
operand of a shift operator is the value to be shifted; the right-hand
operand specifies the shift distance. "
https://d
Hello,
I'm new to the OpenJDK community and plan to make my first change.
I've found a small mistake in the documentation of java.util.Date#hashCode().
The documentation provides a Java expression of the returned value, which uses
a non-existent operator '>>>'.
Now I'm searching for a sponsor
Indeed, Joe is right. Unsigned right shift does not appear often and is
equivalent to signed right shift if the sign bit is 0.
However, this piece of quote can get an upgrade - it can become
`Long.hashCode(this.getTime())`.
*
Chen
From: core-libs-dev on beh
> This PR contains 2 parts
>
> - Upstream of Soft/Weak Reference support authored by @macarte from [the
> Leyden
> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5)
> - New C++ class `AOTReferenceObjSupport` and new Java method
> `ReferencedKeyMap::prepare
On Wed, 30 Apr 2025 08:47:59 GMT, Axel Boldt-Christmas
wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed the internal field ReferenceQueue.NULL to NULL_QUEUE to avoid
>> failing hotspot/jtreg/sources/TestNoNULL.
On Wed, 30 Apr 2025 15:40:35 GMT, Ioi Lam wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 313:
>>
>>> 311: }
>>> 312:
>>> 313: private static void runtimeSetup() {
>>
>> I don't know if you are planning an annotation or something to mark these
>> "runtimeSetup"
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote:
> Replace manual bitwise operations in `hashCode` implementations of
> `java.time` with `Long::hashCode`.
@vy
Your change (at version 891d9ada7ce6860ea8e1253021f04053cc27090a) is now ready
to be sponsored by a Committer.
-
P
On Wed, 30 Apr 2025 15:01:08 GMT, Roger Riggs wrote:
>> Replace manual bitwise operations in `hashCode` implementations of
>> `java.time` with `Long::hashCode`.
>
> lgtm
@RogerRiggs, @minborg, @naotoj, thanks for the reviews. I've attached
successful `tier1,2` results to the ticket. I'd apprec
On Wed, 30 Apr 2025 17:45:04 GMT, Ioi Lam wrote:
>> This PR contains 2 parts
>>
>> - Upstream of Soft/Weak Reference support authored by @macarte from [the
>> Leyden
>> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5)
>> - New C++ class `AOTReferenceObjS
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote:
> Replace manual bitwise operations in `hashCode` implementations of
> `java.time` with `Long::hashCode`.
This pull request has now been integrated.
Changeset: 18983b63
Author:Volkan Yazici
Committer: Naoto Sato
URL:
https://g
On Wed, 30 Apr 2025 14:20:37 GMT, Jaikiran Pai wrote:
>> test/jdk/java/util/zip/ZipFile/ZipFileCharsetTest.java line 68:
>>
>>> 66: // ISO-8859-15 is not a standard charset in Java. We skip this
>>> test
>>> 67: // when it is unavailable
>>> 68:
>>> assumeTrue(Charset.a
On Wed, 30 Apr 2025 16:07:56 GMT, Aleksey Shipilev wrote:
>> When jspawnhelper fails for whatever reason, but more prominently due to
>> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
>> the errors into stdout, but not to the relevant `IOException`. So, if the
>> ap
On Wed, 30 Apr 2025 14:50:03 GMT, Roger Riggs wrote:
> Please add the test number 8352533 to the @bug tag in Basic.java.
Thanks, added!
-
PR Comment: https://git.openjdk.org/jdk/pull/24149#issuecomment-2842494196
> When jspawnhelper fails for whatever reason, but more prominently due to
> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
> the errors into stdout, but not to the relevant `IOException`. So, if the
> application is configured to only capture the exception logs (e.g.
On Tue, 29 Apr 2025 19:03:08 GMT, Chen Liang wrote:
>> The recent patch #23866 makes calling `ClassValue::remove()` from
>> `ClassValue::computeValue()` end up in infinite loops while fixing the stale
>> value risk from the method.
>>
>> The proposed fix is to preserve the stale value risk fix
On Wed, 30 Apr 2025 09:15:49 GMT, Viktor Klang wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 17 additional
>> commits sin
> Use the `@requires` tag instead of obtaining the operating system name from
> the `os.name` property and then exiting if the test is not run on that
> operating system.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8355444:
On Tue, 29 Apr 2025 18:31:37 GMT, Brian Burkhalter wrote:
>> Use the `@requires` tag instead of obtaining the operating system name from
>> the `os.name` property and then exiting if the test is not run on that
>> operating system.
>
> Brian Burkhalter has updated the pull request incrementally
On Wed, 30 Apr 2025 15:33:52 GMT, Per Minborg wrote:
>> This PR is based on the work of @mernst-github and aims to implement an
>> _internal_ thread-local 'stack' allocator, which works like a dynamically
>> sized arena, but with reset functionality to reset the allocated size back
>> to a cer
> A prerequisite to #24760; this was part of it, but was split out to simplify
> the review of the addition of `maskToAccessFlags(int, Location, CFFV)` by
> minimizing the changes in javap. That patch will only need to update
> `BasicWriter` as a result.
>
> Testing: langtools/tools/javap, tier
On Wed, 30 Apr 2025 15:47:32 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/String.java line 1739:
>>
>>> 1737:
>>> 1738: /**
>>> 1739: * {@inheritDoc CharSequence}
>>
>> @jaikiran @jddarcy Sorry for bothering, but I do need your kind help here to
>> get the code to
On Fri, 18 Apr 2025 18:31:05 GMT, Ioi Lam wrote:
> This PR contains 2 parts
>
> - Upstream of Soft/Weak Reference support authored by @macarte from [the
> Leyden
> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5)
> - New C++ class `AOTReferenceObjSupport
On Wed, 30 Apr 2025 18:17:27 GMT, Chen Liang wrote:
>> Take the class file version to reject flags not yet defined, redefined, or
>> obsoleted. This is useful for clients like javap to report the correct
>> undefined flags for different class file versions.
>>
>> A preparatory patch for javap
On Thu, 24 Apr 2025 10:37:59 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make public constuctor private
Congratulations! With the int
On Wed, 30 Apr 2025 14:12:36 GMT, Roger Riggs wrote:
> Refactor AbstractStringBuilder to maintain consistency among count, coder,
> and value buffers while the buffer capacity is being expanded and/or inflated
> from Latin1 to UTF16 representations.
> The refactoring pattern is to read and wri
On Wed, 30 Apr 2025 16:11:14 GMT, Aleksey Shipilev wrote:
>> When jspawnhelper fails for whatever reason, but more prominently due to
>> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
>> the errors into stdout, but not to the relevant `IOException`. So, if the
>> ap
On Wed, 30 Apr 2025 16:11:14 GMT, Aleksey Shipilev wrote:
>> When jspawnhelper fails for whatever reason, but more prominently due to
>> [JDK-8325621](https://bugs.openjdk.org/browse/JDK-8325621), it will report
>> the errors into stdout, but not to the relevant `IOException`. So, if the
>> ap
On Wed, 30 Apr 2025 06:46:07 GMT, Volkan Yazici wrote:
> Replace manual bitwise operations in `hashCode` implementations of
> `java.time` with `Long::hashCode`.
There is a place in java.util.Locale::hashCode that can also be changed
Current version
long bitsWeight = Double.doubleToLongBits(wei
Interestingly, the implementation of Date.hashCode() does use the signed
right shift ">>".
Naoto
On 4/30/25 1:06 PM, Chen Liang wrote:
Indeed, Joe is right. Unsigned right shift does not appear often and is
equivalent to signed right shift if the sign bit is 0.
However, this piece of quote c
1 - 100 of 160 matches
Mail list logo
