Re: RFR: 8339574: Behavior of File.is{Directory,File,Hidden} is not documented with respect to symlinks [v6]

2024-09-14 Thread Alan Bateman
On Fri, 13 Sep 2024 22:05:40 GMT, Brian Burkhalter wrote: >> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and >> `isHidden` behave when the `File` represents a symbolic link. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit si

Re: RFR: 8339574: Behavior of File.is{Directory,File,Hidden} is not documented with respect to symlinks [v6]

2024-09-14 Thread Alan Bateman
On Fri, 13 Sep 2024 22:05:40 GMT, Brian Burkhalter wrote: >> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and >> `isHidden` behave when the `File` represents a symbolic link. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit si

Re: RFR: 8340131: Refactor internal makeHiddenClassDefiner to take ClassOption ... instead of Set [v4]

2024-09-14 Thread ExE Boss
On Fri, 13 Sep 2024 23:51:23 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2223: >> >>> 2221: } >>> : >>> 2223: return makeHiddenClassDefiner(bytes.clone(), false, >>> options.clone()) >> >> Why do we need to clo

Re: RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v11]

2024-09-14 Thread Jatin Bhateja
> Hi All, > > As per the discussion on panama-dev mailing list[1], patch adds the support > following new vector operators. > > > . SUADD : Saturating unsigned addition. > . SADD: Saturating signed addition. > . SUSUB : Saturating unsigned subtraction. > . SSUB:

Re: RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v12]

2024-09-14 Thread Jatin Bhateja
> Hi All, > > As per the discussion on panama-dev mailing list[1], patch adds the support > following new vector operators. > > > . SUADD : Saturating unsigned addition. > . SADD: Saturating signed addition. > . SUSUB : Saturating unsigned subtraction. > . SSUB:

Re: RFR: 8340079: Modify rearrange/selectFrom Vector API methods to perform wrapIndexes instead of checkIndexes [v2]

2024-09-14 Thread Jatin Bhateja
On Fri, 13 Sep 2024 19:14:29 GMT, Sandhya Viswanathan wrote: >> Hi @sviswa7, I was suggesting emitting toShuffle() + toVector() only if it's >> needed under a target specific hook, since indexes are anyways passed though >> vector. Please let me know if you find blow explanation too constraini

Re: RFR: 8340073: Support "%z" time zone abbreviation format in TZ files [v2]

2024-09-14 Thread Justin Lu
On Fri, 13 Sep 2024 18:39:42 GMT, Naoto Sato wrote: >> Yet another preparation for upgrading the time zone data to 2024b, which >> introduced a new abbreviation format "%z". The update includes: >> ... >> The main source files' time zone abbreviations now use %z, >> supported by zic

Re: RFR: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher [v2]

2024-09-14 Thread Jaikiran Pai
> Can I please get a review for this change which cleans up the `java` launcher > to remove checks/support for outdated options? > > As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have > been outdated and unsupported for several releases now. 2 of them even throw > an

Re: RFR: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher [v3]

2024-09-14 Thread Jaikiran Pai
> Can I please get a review for this change which cleans up the `java` launcher > to remove checks/support for outdated options? > > As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have > been outdated and unsupported for several releases now. 2 of them even throw > an

Re: RFR: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher [v3]

2024-09-14 Thread Bernd
On Sat, 14 Sep 2024 13:14:35 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which cleans up the `java` >> launcher to remove checks/support for outdated options? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options >> have been outdated and unsu

Re: RFR: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher [v3]

2024-09-14 Thread Bernd
On Sat, 14 Sep 2024 13:14:35 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which cleans up the `java` >> launcher to remove checks/support for outdated options? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options >> have been outdated and unsu

Re: RFR: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher [v3]

2024-09-14 Thread Bernd
On Sat, 14 Sep 2024 13:14:35 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which cleans up the `java` >> launcher to remove checks/support for outdated options? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options >> have been outdated and unsu

Re: RFR: 8340131: Refactor internal makeHiddenClassDefiner to take ClassOption ... instead of Set [v4]

2024-09-14 Thread Chen Liang
On Sat, 14 Sep 2024 07:50:22 GMT, ExE Boss wrote: >> I started out adding the .clone() as a standard precaution, analyzed to make >> sure it wasn't needed then removed it in one out of two places. Now both >> removed. > > The public methods used to throw `IllegalArgumentException` when duplicat

Re: RFR: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher [v3]

2024-09-14 Thread David Holmes
On Sat, 14 Sep 2024 16:08:00 GMT, Bernd wrote: > What about `-Xdebug` it’s deprecated for remove. It’s not yet moved to the > obsolete section of the manual. And we could also remove it from the -X > command line help. If it is deprecated then it goes in the Deprecated section. The obsoleted

Re: RFR: 8340131: Refactor internal makeHiddenClassDefiner to take ClassOption ... instead of Set [v4]

2024-09-14 Thread Chen Liang
On Sat, 14 Sep 2024 01:12:47 GMT, Claes Redestad wrote: >> Simple internal refactor to load a few classes less on startup. Arguably >> cleaner. > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Unused import src/java.base