On Tue, 2 Jul 2024 02:13:50 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
There are two similarly names tests.
Recently:
JDK-8335124: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed
with CPU time out of expected range
...made a simple change to try and avoid noisy test failures. The same fix
should be applied here to ThreadCpuTime.java.
Also removing a
On Thu, 4 Jul 2024 06:22:31 GMT, Hannes Greule wrote:
>> Similar to how `MethodHandle#invoke(Exact)` methods are already handled,
>> this change adds special casing for `VarHandle.{access-mode}` methods.
>>
>> The exception message is less exact, but I think that's acceptable.
>
> Hannes Greule
On Tue, 2 Jul 2024 14:04:52 GMT, Shaojin Wen wrote:
>> We need a String format solution with good performance. String Template was
>> once expected, but it has been removed. j.u.Formatter is powerful, but its
>> performance is not good enough.
>>
>> This PR implements a subset of j.u.Formatter
On Mon, 3 Jun 2024 17:26:52 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change? The motivation is that javac
> does not recognize `package.html` files.
>
> The conversion was simple, I used a script to rename the files, append "*" on
> the left and remove some HTML tag
On Thu, 27 Jun 2024 17:28:36 GMT, fabioromano1 wrote:
>> Thanks. That's a very nice performance improvement, on my Windows machine
>> the `testHuge...` test is about 2-3x faster, and the other 2 are slightly
>> faster too.
>>
>> This needs a proper review for correctness, which might take a wh
On Thu, 4 Jul 2024 12:51:47 GMT, Raffaello Giulietti
wrote:
>> @djelinski I also improved the `BigDecimal.sqrt()` algorithm exploiting
>> `BigInteger.sqrtAndRemainder()`.
>
> @fabioromano1 I'll review your contribution starting sometimes next week.
> Please stabilize your code until then.
@rgi
On Wed, 3 Jul 2024 16:45:51 GMT, Alexey Semenyuk wrote:
>> Vanitha B P has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8325525 Addressed review comments
>
> test/jdk/tools/jpackage/apps/ThirdPartyAppLauncher.java line 34:
>
>> 32:
On Wed, 3 Jul 2024 16:47:02 GMT, Alexey Semenyuk wrote:
>> Vanitha B P has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8325525 Addressed review comments
>
> test/jdk/tools/jpackage/share/JpackageTest.java line 59:
>
>> 57: @Test
>>
On Fri, 28 Jun 2024 11:11:51 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
On Fri, 28 Jun 2024 11:11:51 GMT, Nizar Benalla wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are
On Wed, 3 Jul 2024 16:57:49 GMT, Alexey Semenyuk wrote:
>> Vanitha B P has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8325525 Addressed review comments
>
> test/jdk/tools/jpackage/share/JpackageTest.java line 79:
>
>> 77: /
On Mon, 1 Jul 2024 14:43:58 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> cg
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are nee
Please review this simple doc only change.
Some methods in ClassFile API were renamed recently as part of
[JDK-8335290](https://bugs.openjdk.org/browse/JDK-8335290) and
[JDK-8335110](https://bugs.openjdk.org/browse/JDK-8335110) and need to have
`@since 24`, as they are essentially new methods.
On Thu, 6 Jun 2024 18:48:58 GMT, Chen Liang wrote:
>> Core reflection's generic signature parsing uses an ancient library with
>> outdated visitor pattern on a tree model and contains unnecessary
>> boilerplates. This is a duplication of ClassFile API's signature model. We
>> should just move
On Thu, 4 Jul 2024 18:04:27 GMT, Nizar Benalla wrote:
> Please review this simple doc only change.
> Some methods in ClassFile API were renamed recently as part of
> [JDK-8335290](https://bugs.openjdk.org/browse/JDK-8335290) and
> [JDK-8335110](https://bugs.openjdk.org/browse/JDK-8335110) and n
On Thu, 4 Jul 2024 18:04:27 GMT, Nizar Benalla wrote:
> Please review this simple doc only change.
> Some methods in ClassFile API were renamed recently as part of
> [JDK-8335290](https://bugs.openjdk.org/browse/JDK-8335290) and
> [JDK-8335110](https://bugs.openjdk.org/browse/JDK-8335110) and n
On Wed, 27 Mar 2024 10:24:51 GMT, Jan Lahoda wrote:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The curr
19 matches
Mail list logo
