The current mailing list, core-libs-dev, is the correct one.
Cheers,
David
On 14/12/2023 9:37 am, Valeh Hajiyev wrote:
Hi Pavel,
Thanks for the reply. If I understand correctly, I need this change to
be discussed in one of the mailing lists there, so that someone would
sponsor me to create a
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
Serge
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
On Mon, 23 Oct 2023 16:12:45 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
On Wed, 13 Dec 2023 23:10:05 GMT, Naoto Sato wrote:
> Small document correction on a return description.
src/java.base/share/classes/java/time/zone/ZoneRules.java line 831:
> 829: * and {@link #getStandardOffset(java.time.Instant) standard}
> offsets.
> 830: *
> 831: * @param in
On Tue, 12 Dec 2023 09:01:08 GMT, Stefan Karlsson wrote:
>> There is some logging printed when tests spawns processes. This logging is
>> triggered from calls to `OutputAnalyzer`, when it delegates calls to
>> `LazyOutputBuffer`.
>>
>> If we write code like this:
>>
>> ProcessBuilder pb = Pro
Like David said earlier, this is the correct list. However, given the festive
season, expect some delays in communication.
> On 13 Dec 2023, at 23:37, Valeh Hajiyev wrote:
>
> Hi Pavel,
>
> Thanks for the reply. If I understand correctly, I need this change to be
> discussed in one of the mai
You might want to use this older, unresolved, duplicated bug for your PR:
https://bugs.openjdk.org/browse/JDK-6356745
> On 13 Dec 2023, at 23:37, Valeh Hajiyev wrote:
>
> Hi Pavel,
>
> Thanks for the reply. If I understand correctly, I need this change to be
> discussed in one of the mailing
On Wed, 13 Dec 2023 21:38:43 GMT, Roger Riggs wrote:
> The test java/lang/String/CompactString/MaxSizeUTF16String.java fails when
> run with -Xcomp.
>
> Both the java implementation and the intrinsic for StringUTF16.toBytes()
> allocate memory for a copy of the string.
> The java implementatio
On Tue, 7 Nov 2023 07:58:40 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-yet
> This PR adds an internal method to calculate hash code from the provided
> integer array, offset and length into that array, and the initial hash code
> value.
>
> Current options for calculating a hash code for int[] are inflexible. It's
> either ArraysSupport.vectorizedHashCode with an offs
On Fri, 8 Dec 2023 20:28:20 GMT, Eirik Bjorsnos wrote:
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be
> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for BigInteger. If you have any performance
> concerns, please raise them.
>
> This PR is cherry-picked from a bigger, not-yet-published PR, to test the
> waters. That latter PR will b
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
I presume that the precondition to have the original collection be pre-ordered
according to the supplied Comparator can be verified by checking before adding
each element in the collection to the PQ that it compareTo equal-or-greater to
the previous one?
Cheers,
√
Viktor Klang
Software Archi
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/
Aggelos Biboudis has updated the pull request with a new target base due to a
merge or a rebase. The pull request now cont
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
Marked as reviewed by cstein (Committer).
German translations read OK.
Nit: some layouts get lost in translated files - it would be great to have
similar usage of `\n` and `` in the translated files.
For
On Thu, 14 Dec 2023 10:13:31 GMT, Eirik Bjorsnos wrote:
> The scope of this PR has now expanded to removing uses of the `input.zip` and
> `input.jar` files, updating any test using them to produce their own test
> vectors, and convert affected tests to JUnit.
>
> I'm marking the PR ready for r
On Wed, 13 Dec 2023 11:39:19 GMT, Aleksei Voitylov
wrote:
>> Since JDK-8311906, if CompactStrings is not enabled, index is not considered
>> when calling extractCodepoints from StringUTF16.toBytes(). Because of that
>> the last elements of the source codepoints array are stripped from the
>>
On Tue, 12 Dec 2023 23:42:07 GMT, Leonid Mesnik wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: (1) rename notifyJvmti method; (2) add try-final statements to
>> VirtualThread methods
>
> src/java.base/
On Fri, 8 Dec 2023 11:54:40 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`, `interrupt()
On Tue, 12 Dec 2023 23:54:43 GMT, Leonid Mesnik wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: (1) rename notifyJvmti method; (2) add try-final statements to
>> VirtualThread methods
>
> src/hotspot/sh
On Thu, 14 Dec 2023 12:06:41 GMT, Serguei Spitsyn wrote:
> Carrier thread also can be suspended when executing the "critical code". Why
> do you think it can't be a problem? Do you think the deadlocking scenario
> described in the bug report is not possible?
It's a different scenario. When mou
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
On Thu, 14 Dec 2023 11:39:22 GMT, Lance Andersen wrote:
>> The scope of this PR has now expanded to removing uses of the `input.zip`
>> and `input.jar` files, updating any test using them to produce their own
>> test vectors, and convert affected tests to JUnit.
>>
>> I'm marking the PR ready
On Thu, 14 Dec 2023 09:17:05 GMT, Pavel Rappo wrote:
> Thanks for doing this, David. I only note that the changes for JDK-8321384
> were published in [JDK-8308715](https://bugs.openjdk.org/browse/JDK-8308715),
> which was integrated in the mainline before JDK 22 RDP 1. So they are already
> pr
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
On Thu, 14 Dec 2023 09:01:17 GMT, Alan Bateman wrote:
> Initially I wondered if JDK-8309981 should be separated but include keeps
> things in sync so I think okay.
Thanks for the review @AlanBateman .
Yeah I was in two minds there myself. I started fixing
[JDK-8309981](https://bugs.openjdk.or
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs.openjdk.org/browse/JDK-8290702) (javadoc) (JDK
> 23 ba
On Mon, 4 Dec 2023 10:39:05 GMT, Darragh Clarke wrote:
> Updated tests to use vm.flagless as they already ignore Vm flags
This pull request has now been integrated.
Changeset: 62b7c5ea
Author:Darragh Clarke
URL:
https://git.openjdk.org/jdk/commit/62b7c5eaed1e6ffd6f2c8371eb4cf01dd9d5
Hi core libs team,
I think I found a rather inconsequential and esoteric bug, though the term
is somewhat less objectively defined when the problem exists solely in how
complete some method’s javadoc is.
Two questions: Is there a plausible argument that the javadoc as is,
shouldn’t be updated? If
On Thu, 14 Dec 2023 11:39:22 GMT, Lance Andersen wrote:
> (though CopyZipFile could use a junit conversion ;-)
Agreed, I have included that conversion in this PR :-) This test can make good
use of `assertThrows` and splitting different concerns into separate test
methods.
-
PR Co
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
On Mon, 11 Dec 2023 13:48:18 GMT, Aleksei Voitylov
wrote:
> Since JDK-8311906, if CompactStrings is not enabled, index is not considered
> when calling extractCodepoints from StringUTF16.toBytes(). Because of that
> the last elements of the source codepoints array are stripped from the
> resu
On Thu, 14 Dec 2023 12:03:11 GMT, Aleksei Voitylov
wrote:
> Thank you, Roger. Yes, I'll work on the 22 backport.
See https://wiki.openjdk.org/display/SKARA/Backports
Once the mainline is integrated, find the commit and add a "/backport jdk21"
comment.
Skara should do the rest (but read the di
> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
> `ZipFile/input.jar`.
>
> Binary test vectors are harder to analyze, and sharing test vectors across
> unrelated tests increases maintenance burden. It would be better to have each
> test produce its own test vectors
On Wed, 13 Dec 2023 17:38:27 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7ece9e90](https://github.com/openjdk/jdk/commit/7ece9e90c0198f92cdf8d620e346c4a9832724cd)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Wed, 13 Dec 2023 17:38:27 GMT, Jorn Vernee wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7ece9e90](https://github.com/openjdk/jdk/commit/7ece9e90c0198f92cdf8d620e346c4a9832724cd)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bein
On Thu, 14 Dec 2023 14:55:08 GMT, Eirik Bjorsnos wrote:
>> This PR suggests we retire the binary test vectors `ZipFile/input.zip` and
>> `ZipFile/input.jar`.
>>
>> Binary test vectors are harder to analyze, and sharing test vectors across
>> unrelated tests increases maintenance burden. It wo
On Thu, Dec 14, 2023 at 4:56 AM Viktor Klang
wrote:
> I presume that the precondition to have the original collection be
> pre-ordered according to the supplied Comparator can be verified by
> checking before adding each element in the collection to the PQ that it
> compareTo equal-or-greater to
On Thu, 14 Dec 2023 12:11:42 GMT, Serguei Spitsyn wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 1164:
>>
>>> 1162:
>>> 1163: @IntrinsicCandidate
>>> 1164: private native void notifyJvmtiCriticalLock(boolean enter);
>>
>> The name is confusing to me, the Critic
On Thu, 14 Dec 2023 09:32:23 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Corrected @param description
>
> src/java.base/share/classes/java/time/zone/ZoneRules.java line 831:
>
>> 829: * an
> Small document correction on a return description.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Corrected @param description
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17098/files
- new: https://git.openjd
On Thu, 14 Dec 2023 16:57:25 GMT, Serguei Spitsyn wrote:
> Implemented this renaming suggestion. Let's wait if Alan ia okay with it.
Are you planning to drop the changes to mount/unmount too? They shouldn't be
needed.
notifyJvmtiCriticalLock(boolean) is okay for now but needs to be called befo
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`, `toString()`)
On Thu, 14 Dec 2023 17:06:05 GMT, Alan Bateman wrote:
>> Implemented this renaming suggestion. Let's wait if Alan ia okay with it.
>
>> Implemented this renaming suggestion. Let's wait if Alan ia okay with it.
>
> Are you planning to drop the changes to mount/unmount too? They shouldn't be
> ne
On Thu, 14 Dec 2023 12:19:43 GMT, Alan Bateman wrote:
> Okay. What about the Leonid's suggestion to name it
> `notifyJvmtiDisableSuspend()` ?
Okay with me. We'll need to move the notifyJvmtiDisableSuspend(true) to before
the try in all cases, I've pointed out the cases that we missed.
---
On Thu, 14 Dec 2023 17:30:54 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`, `interrupt(
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`, `toString()`)
On Thu, 14 Dec 2023 18:04:02 GMT, Alan Bateman wrote:
> Okay with me. We'll need to move the notifyJvmtiDisableSuspend(true) to
> before the try in all cases, I've pointed out the cases that we missed.
Thank you, Alan. Fixed now.
-
PR Comment: https://git.openjdk.org/jdk/pull/1701
On Thu, 14 Dec 2023 18:03:00 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: 1) replace CriticalLock with DisableSuspend; 2) minor tweaks
>
> src/java.base/share/classes/java/lang/Virtu
On Thu, 14 Dec 2023 12:16:34 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/runtime/javaThread.hpp line 320:
>>
>>> 318: bool _is_in_VTMS_transition; // thread is
>>> in virtual thread mount state transition
>>> 319: bool _is_in_tmp_VTMS_transiti
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
line 331:
> 329:
> 330: # Implementation Property DTD
> 331: JDK_DTD_DENY = JAXP00010008: DOCTYPE is
Hello. This is my first time posting here so I apologize if this is the
wrong forum. I wanted to bring up an issue in the GZipInputStream which
was first identified in 2011, confirmed as a bug, and then never resolved.
When reading certain GZIP files from certain types of InputStreams the
GZIPIn
On Wed, 13 Dec 2023 21:25:19 GMT, Archie Cobbs wrote:
> After filing this PR, I had some second thoughts and added them to the
> summary but by then it was too late for the `core-libs-dev` email, so I'll
> repeat here in case anyone has some comments:
>
> > It's worth considering if there is a
On Thu, 14 Dec 2023 06:12:40 GMT, Vladimir Sitnikov
wrote:
> What do you think?
I think that you are looking at an obsolete repository:
https://github.com/openjdk/jdk/blob/c328f9589ddc3a981a2c63801bd991f8e593e69f/src/java.base/share/classes/java/io/InputStream.java#L802
-
PR Revi
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties
line 111:
> 109: doclet.Factory=ファクトリ:
> 110: doclet.UnknownTag=不明なタグ。未登録のカスタム・タグ?
> 111: doclet.UnknownTag
In the java libraries there are many methods that operate on byte arrays
that do not allow you to specify offset and length for the relevant data
instead forcing you to copy the relevant part to new arrays before using
the methods reducing performance - I am for instance struggling with this
in jav
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
All around LGTM. From a skim I don't see any of the typical l10n related file
mode issues, line ending issues, or values that should not be changed (like
_WixLocalization Culture_). Might be worth filing a
On Thu, 14 Dec 2023 18:24:16 GMT, Serguei Spitsyn wrote:
> Thank you, Alan. Fixed now. I believe, all your suggestions have been
> addressed now.
Thanks, it looks much better now.
-
PR Comment: https://git.openjdk.org/jdk/pull/17011#issuecomment-1856485757
On Thu, 14 Dec 2023 18:26:55 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`, `interrupt(
> On 14 Dec 2023, at 06:10, Magnus wrote:
>
> In the java libraries there are many methods that operate on byte arrays that
> do not allow you to specify offset and length for the relevant data instead
> forcing you to copy the relevant part to new arrays before using the methods
> reducing
On Wed, 13 Dec 2023 20:06:03 GMT, Archie Cobbs wrote:
> One of the three `XMLStreamException` constructors that takes a `Throwable`
> fails to pass it to the superclass constructor.
>
> This simple patch fixes that omission.
>
> It's worth considering if there is any code out there that is wor
Hi Louis,
On first glance this looks easy to fix. I've filed a draft PR here (pending
tests) https://github.com/openjdk/jdk/pull/17113
-Archie
On Thu, Dec 14, 2023 at 1:10 PM Louis Bergelson
wrote:
> Hello. This is my first time posting here so I apologize if this is the
> wrong forum. I wan
On Thu, 14 Dec 2023 19:22:18 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/SequenceInputStream.java line 249:
>>
>>> 247: transferred = Math.addExact(transferred,
>>> in.transferTo(out));
>>> 248: } catch (ArithmeticException ign
Upon a closer look, switching to ByteBuffer would only get you 50% towards
where you want to be: the resulting ByteBuffer, whether encoded or decoded, is
*allocated* by the respective methods and then returned as a result rather than
accepted by those methods as a parameter.
> On 14 Dec 2023, a
This commit addresses the current limitation in the `PriorityQueue`
implementation, which lacks a constructor to efficiently create a priority
queue with a custom comparator and an existing collection. In order to create
such a queue, we currently need to initialize a new queue with custom
comp
> This commit addresses the current limitation in the `PriorityQueue`
> implementation, which lacks a constructor to efficiently create a priority
> queue with a custom comparator and an existing collection. In order to create
> such a queue, we currently need to initialize a new queue with cust
Yes, there's no such precondition. Thanks for having a look, I updated the
javadoc as you suggested, and linked it to the old existing ticket. It's
now ready for review.
I would appreciate if you could have a look again.
Cheers,
Valeh
On Thu, Dec 14, 2023 at 4:22 PM Archie Cobbs wrote:
> On Th
Looks great - thanks (I'm not an official reviewer so I can't approve it
though).
-Archie
On Thu, Dec 14, 2023 at 2:37 PM Valeh Hajiyev
wrote:
> Yes, there's no such precondition. Thanks for having a look, I updated the
> javadoc as you suggested, and linked it to the old existing ticket. It's
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
Marked as reviewed by asemenyuk (Reviewer).
jpackage changes look good
-
PR Review: https://git.openjdk.org/jdk/pull/17096#pullrequestreview-1782697421
PR Comment: https://git.openjdk.org/jdk/p
`GZIPInputStream`, when looking for a concatenated stream, relies on what the
underlying `InputStream` says is how many bytes are `available()`. But this is
inappropriate because `InputStream.available()` is just an estimate and is
allowed (for example) to always return zero.
The fix is to igno
Yes, overloads that accepted both source and destination ByteBuffer were there
at some point, but then were removed:
commit 591834e28d482ea6a375ab215958e1635a7b111d
Author: Xueming Shen
Date: Tue Dec 3 17:44:31 2013 -0800
8028397: Undo the lenient MIME BASE64 decoder support change (JDK-8
One more request – Current PR cannot be merged without CRS. Could someone
please help me to create a CSR request for the issue below?
https://bugs.openjdk.org/browse/JDK-6356745
Unfortunately, I don't have permission to create a CSR request.
-Valeh
On Thu, Dec 14, 2023 at 9:40 PM Archie Cobbs
On Thu, 14 Dec 2023 20:15:39 GMT, Archie Cobbs wrote:
> `GZIPInputStream`, when looking for a concatenated stream, relies on what the
> underlying `InputStream` says is how many bytes are `available()`. But this
> is inappropriate because `InputStream.available()` is just an estimate and is
>
On Thu, 14 Dec 2023 20:15:39 GMT, Archie Cobbs wrote:
> `GZIPInputStream`, when looking for a concatenated stream, relies on what the
> underlying `InputStream` says is how many bytes are `available()`. But this
> is inappropriate because `InputStream.available()` is just an estimate and is
>
On Thu, 7 Dec 2023 19:43:14 GMT, Justin Lu wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 176 Update.
> As the replacement of `ANG` to `XCG` won't occur until 2025, this change does
> not need to go into JDK22. `HR` was also updated to remove the past cutover
> dates.
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
On Wed, 13 Dec 2023 19:00:52 GMT, Naoto Sato wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the early days of Java,
>> but h
> This is a doc change to clarify what the `Default Locale` is, and how it is
> established during the system startup using the system properties. Those
> locale-related system properties have existed since the early days of Java,
> but have never been publicly documented before. It is also the
On Thu, 14 Dec 2023 21:27:06 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/util/Locale.java line 264:
>
>> 262: * Default Locale
>> 2
On Thu, 14 Dec 2023 20:21:10 GMT, Vladimir Sitnikov
wrote:
>>> What do you think?
>>
>> I think that you are looking at an obsolete repository:
>>
>> https://github.com/openjdk/jdk/blob/c328f9589ddc3a981a2c63801bd991f8e593e69f/src/java.base/share/classes/java/io/InputStream.java#L802
>
> I mea
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
mach5 looks green
-
PR Comment: https://git.openjdk.org/jdk/pull/17096#issuecomment-1856733375
> Translation drop for JDK22 RDP1
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
removed quotes around Ablehnen
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17096/files
- new: https://git.openjdk.org/jdk/pull/
On Thu, 14 Dec 2023 20:36:50 GMT, Valeh Hajiyev wrote:
>> This commit addresses the current limitation in the `PriorityQueue`
>> implementation, which lacks a constructor to efficiently create a priority
>> queue with a custom comparator and an existing collection. In order to
>> create such a
On Thu, 14 Dec 2023 19:50:00 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: moved notifyJvmtiDisableSuspend(true) out of try-block
>
> src/java.base/share/classes/java/lang/VirtualThre
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`, `toString()`)
On Thu, 14 Dec 2023 22:35:18 GMT, Serguei Spitsyn wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 1043:
>>
>>> 1041: notifyJvmtiDisableSuspend(true);
>>> 1042: try {
>>> 1043: // include the carrier thread state and name when
>>> m
On Thu, 14 Dec 2023 08:47:03 GMT, Sergey Tsypanov wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1b
On Mon, 11 Dec 2023 16:37:38 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 14 Dec 2023 21:54:53 GMT, Markus KARG wrote:
>> I mean SequenceInputStream, not the base class:
>> https://github.com/openjdk/jdk/blob/c328f9589ddc3a981a2c63801bd991f8e593e69f/src/java.base/share/classes/java/io/SequenceInputStream.java#L249
>>
>> Could you please double-check?
>
> IMHO
On Thu, 14 Dec 2023 19:01:22 GMT, Joe Wang wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed quotes around Ablehnen
>
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.pr
On Thu, 14 Dec 2023 22:18:35 GMT, Valeh Hajiyev wrote:
> @AlanBateman thanks for having a look. would you be able to create a CRS
> request as I don't have permission to do so?
You may not be able to create one, but you sure can look at some. If you do so,
you'll see that obtaining a permissio
Thanks for the good suggestion Pavel - will look into that - for large
arrays absolutely less costly than copying!
In the general case I would still prefer if the libraries generally
provided offset & length for byte array arguments to allow for "garbage
free" code (i.e. avoiding to frequently cre
On Thu, 14 Dec 2023 17:08:02 GMT, Naoto Sato wrote:
>> Small document correction on a return description.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Corrected @param description
Thank you for the update Naoto. The curre
ConcurrentHashMap's copy constructor calls `putAll()` -> `tryPresize()` ->
`transfer()`. When coming from the copy constructor, the Map is empty, so there
is nothing to transfer. But `transfer()` will still copy all the empty nodes
from the old table to the new table.
This patch avoids this wor
> `GZIPInputStream`, when looking for a concatenated stream, relies on what the
> underlying `InputStream` says is how many bytes are `available()`. But this
> is inappropriate because `InputStream.available()` is just an estimate and is
> allowed (for example) to always return zero.
>
> The fi
On Thu, 14 Dec 2023 21:14:33 GMT, Eirik Bjorsnos wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments.
>
> test/jdk/java/util/zip/GZIP/GZIPInputStreamAvailable.java line 37:
>
>> 35: public
1 - 100 of 102 matches
Mail list logo
