On Tue, 28 Nov 2023 13:03:48 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1404:
>>
>>> (failed to retrieve contents of file, check the PR for context)
>> Is there a more scalable way to express the major class version? The current
>> approach me
On Tue, 28 Nov 2023 08:51:17 GMT, Alan Bateman wrote:
> Update the jtreg test group configuration in the jdk test tree so that the
> jpackage tests run in tier3 rather than tier2.
>
> At this time, the jpackage tests run in jdk:tier2, more specifically
> jdk:tier2_part2 as part of the core_too
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
Marked as reviewed by shade (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1754814207
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1755023783
It looks like we can skip copying of `byte[]` in
`BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
`java.io`.
See comment by @vlsi in
https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78697ecca66947c395adda0d9c49a85bf696e677ecbd977af1R612
-
Co
On Thu, 23 Nov 2023 16:32:28 GMT, Jorn Vernee wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comments from Jorn
>
> LGTM
Thanks for the reviews @JornVernee @pchilano and @mcimadamore!
-
PR Comment
On Thu, 23 Nov 2023 11:14:29 GMT, Erik Österlund wrote:
> The current logic for closing memory in panama today is susceptible to live
> lock if we have a closing thread that wants to close the memory in a loop
> that keeps failing, and a bunch of accessing threads that want to perform
> access
Hello,
Last Friday, I decided to look if there were some classes that did
unneeded array assignments (e.g. to 0 / 0.0f / null / false) in the JDK.
I've found a few places and in particular 2 places where it's done in big
for loops (looping more than 500 times). So I thought you might be
interes
On Wed, 29 Nov 2023 11:57:37 GMT, Sergey Tsypanov wrote:
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78
On Fri, 24 Nov 2023 13:25:35 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>> is
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
On Wed, 29 Nov 2023 14:30:50 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - S
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1755813777
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
This pull request has now been integrated.
Changeset: d783aa31
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/d783aa31a9c20f5ac2ee52c55bdc9be2388b1705
Stats: 1 line i
On Wed, 15 Nov 2023 22:46:03 GMT, Jorn Vernee wrote:
> See the JBS issue for an extended problem description.
>
> This patch changes the specification and implementation of
> `MethodHandles::byteArrayViewVarHandle`,
> `MethodHandles::byteBufferViewVarHandle`, `ByteBuffer::alignedSlice`, and
>
On Wed, 29 Nov 2023 15:01:32 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
> Time to start making preparations for JDK 23.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains seven commits:
- Merge branch 'master' into JDK-8319413
- Add symbol files for JDK 22 build 25.
- Merge branch 'master' into
On Thu, 23 Nov 2023 00:26:43 GMT, Justin Lu wrote:
> Please review this PR which converts the shell test,
> _java/util/currency/PropertiesTest.sh_ to a normal java test.
>
> This test is a test runner that launches test methods from
> _PropertiesTest.java_. It tests both the ways to supersede
On Wed, 29 Nov 2023 13:56:34 GMT, Vladimir Sitnikov
wrote:
> What do you think of passing the buffer as is?
No, it should only do for trusted targets. BAIS has an issue in that area that
should be fixed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16879#discussion_r1409
On Wed, 29 Nov 2023 11:57:37 GMT, Sergey Tsypanov wrote:
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78
On Sun, 26 Nov 2023 18:18:10 GMT, Alan Bateman wrote:
> This is update to the specification of the j.l.module.ResolvedModule.reads
> method to clarify that the set of resolved modules returned does not include
> itself. There is a small implementation change to align with the
> specification a
On Wed, 29 Nov 2023 15:25:15 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - S
On Wed, 29 Nov 2023 19:55:09 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/BufferedInputStream.java line 653:
>>
>>> 651: byte[] buffer = Arrays.copyOfRange(getBufIfOpen(),
>>> pos, count);
>>> 652: out.write(buffer);
>>> 653:
On Wed, 29 Nov 2023 15:25:15 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - S
On Wed, 29 Nov 2023 20:07:37 GMT, Vladimir Sitnikov
wrote:
> The buffer in question is protected, so any subclass can directly access it.
> In other words, untrusted code can easily acoess the buffer, and it does not
> sound fair to add extra overhead to the method which was created for the
>
On Tue, 28 Nov 2023 15:00:43 GMT, Jim Laskey wrote:
>> test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35:
>>
>>> 33: import java.lang.reflect.Modifier;
>>> 34:
>>> 35: public class TestImplicitClass {
>>
>> The test looks to be testing core reflection behavior (i.e. runti
Hi Anthony,
Go ahead a file a single bug (for the two cases).
That code may have been written before Arrays.fill(...).
Regards, Roger
On 11/29/23 7:54 AM, Anthony Goubard wrote:
Hello,
Last Friday, I decided to look if there were some classes that did
unneeded array assignments (e.g. to 0 /
Thanks for the answers.
I've created an issue in bugreport.java.com with internal review ID :
9076287
Hope that helps,
Anthony
Le mer. 29 nov. 2023 à 21:55, Roger Riggs a écrit :
> Hi Anthony,
>
> Go ahead a file a single bug (for the two cases).
> That code may have been written before Arrays.
On Wed, 29 Nov 2023 20:07:37 GMT, Vladimir Sitnikov
wrote:
>>> What do you think of passing the buffer as is?
>>
>> No, it should only do for trusted targets. BAIS has an issue in that area
>> that should be fixed.
>
> The buffer in question is protected, so any subclass can directly access it
On Wed, 29 Nov 2023 11:57:37 GMT, Sergey Tsypanov wrote:
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78
On Wed, 29 Nov 2023 19:59:03 GMT, Alan Bateman wrote:
>> It looks like we can skip copying of `byte[]` in
>> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
>> `java.io`.
>>
>> See comment by @vlsi in
>> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6e
Please review this PR which updates an incorrect code example in
_java/text/ChoiceFormat_.
ChoiceFormat (and MessageFormat) provide an example of how to produce a pattern
that supports singular and plural forms. The ChoiceFormat example is incorrect,
as recursive MessageFormats produced by a Ch
On Wed, 29 Nov 2023 22:49:17 GMT, Markus KARG wrote:
>> Buffer copy was not there before, and defensive copy was never present in
>> `ByteArrayInputStream` as well:
>> https://github.com/openjdk/jdk/blob/9a6ca233c7e91ffa2ce9451568b3be88ccd04504/src/java.base/share/classes/java/io/ByteArrayInput
On Wed, 29 Nov 2023 05:55:03 GMT, Vladimir Sitnikov
wrote:
>> src/java.base/share/classes/java/io/BufferedInputStream.java line 612:
>>
>>> 610: if (avail > 0) {
>>> 611: // Prevent poisoning and leaking of buf
>>> 612: byte[] buffer = Arrays.copyOfRa
On Wed, 29 Nov 2023 22:49:58 GMT, Markus KARG wrote:
> As Alan pointed out, it is a bug (actually even a security risk), so BAIS
> should get fixed, too.
I am going to file an issue on this.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/10525#discussion_r1409965074
On Wed, 29 Nov 2023 22:41:26 GMT, Justin Lu wrote:
> Please review this PR which updates an incorrect code example in
> _java/text/ChoiceFormat_.
>
> ChoiceFormat (and MessageFormat) provide an example of how to produce a
> pattern that supports singular and plural forms. The ChoiceFormat exam
On Tue, 21 Nov 2023 09:12:49 GMT, Viktor Klang wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Fri, 24 Nov 2023 13:25:35 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>> is
Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
`BAIS.transferTo` only if the target stream is in the `java.io` package.
-
Commit messages:
- 8321053: Use ByteArrayInputStream.buf directly when parameter of
transferTo() is trusted
Changes: https://git.
On Wed, 29 Nov 2023 11:57:37 GMT, Sergey Tsypanov wrote:
> It looks like we can skip copying of `byte[]` in
> `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in
> `java.io`.
>
> See comment by @vlsi in
> https://github.com/openjdk/jdk/pull/10525/files#diff-e19c508d1bb6ee78
On Wed, 29 Nov 2023 23:34:14 GMT, Naoto Sato wrote:
> Do you think it would be helpful if we describe that limitation so that such
> confusion will not arise?
Yes, that's a good point. I didn't initially include one because I wanted to
look into [JDK-4270867](https://bugs.openjdk.org/browse/JD
On Tue, 21 Nov 2023 22:46:32 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 489:
>>
>>> 487: * If this reference was already enqueued (by the garbage
>>> collector, or a
>>> 488: * previous call to {@code enqueue}), this method is not
>>> suc
On Wed, 22 Nov 2023 07:05:21 GMT, Eric Liu wrote:
>> Vector API defines zero-extend operations [1], which are going to be
>> intrinsified and generated to `VectorUCastNode` by C2. This patch adds
>> backend implementation for `VectorUCastNode` on AArch64.
>>
>> The micro benchmark shows signif
On Tue, 28 Nov 2023 20:52:35 GMT, Srinivas Vamsi Parasa
wrote:
>> Thanks Sandhya, will fix this issue.
>
> Thanks Sandhya for suggesting the change to use supports_simd_sort(BasicType
> bt). Please see the updated code upstreamed.
@vamsi-parasa Thanks, your changes look good to me.
--
On Thu, 30 Nov 2023 00:03:21 GMT, Brian Burkhalter wrote:
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
src/java.base/share/classes/java/io/ByteArrayInputStream.java line 211:
> 209:
On Wed, 29 Nov 2023 22:38:59 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/io/BufferedInputStream.java line 647:
>>
>>> 645: if (avail > 0) {
>>> 646: // trust all OutputStreams from java.io
>>> 647: if (out.getClass().getPackageName() ==
> Currently the vector floating-point math APIs like
> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
> which causes large performance gap on AArch64. Note that those APIs are
> optimized by C2 compiler on X86 platforms by calling Intel's SVML code [1].
> To close th
On Thu, 23 Nov 2023 14:05:51 GMT, Magnus Ihse Bursie wrote:
>> Xiaohong Gong has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments in build system
>
> make/autoconf/lib-vmath.m4 line 70:
>
>> 68: if test "x$SYS
50 matches
Mail list logo
