On Tue, 29 Nov 2022 00:56:58 GMT, Brian Burkhalter wrote:
> `java.io.InputStream::transferTo` could conceivably return a negative value
> if the count of bytes transferred overflows a `long`. Modify the method to
> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
Input
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> are backed by native memory that, in turn, can be closed asynchronously
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed by
We hear you Mike :-)
I have logged https://bugs.openjdk.org/browse/JDK-8297755 to update the
links in java.net / java.net.http API documentation.
best regards,
-- daniel
On 29/11/2022 03:14, Michael StJohns wrote:
Hi -
I need to repeat again. Please avoid using www.ietf.org as the URL base
On Tue, 15 Nov 2022 13:53:23 GMT, Aleksey Shipilev wrote:
>> $ java -jar
>> ../build/linux-x86_64-server-release/images/test/micro/benchmarks.jar
>> org.openjdk.bench.javax.tools.Javac.testCompile -f 1 -r 1s -w 1s
>> ...
>>
>> $ ls
>> Apan.class
>> ```
>>
>> Additional testing:
>> - [x] Eye
On Wed, 9 Nov 2022 09:00:14 GMT, Aleksey Shipilev wrote:
> $ java -jar
> ../build/linux-x86_64-server-release/images/test/micro/benchmarks.jar
> org.openjdk.bench.javax.tools.Javac.testCompile -f 1 -r 1s -w 1s
> ...
>
> $ ls
> Apan.class
> ```
>
> Additional testing:
> - [x] Eyeballing CWD
On Thu, 24 Nov 2022 14:05:41 GMT, Andrew Haley wrote:
>> JEP 429 implementation.
>
> Andrew Haley has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Unused variable
src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedVal
On Fri, 25 Nov 2022 18:54:28 GMT, Alan Bateman wrote:
> Another small step in the multi-release/multi-year effort to remove cruft
> from Thread/ThreadGroup.
>
> java.lang.ThreadGroup.allowThreadSuspension(boolean) dates from JDK 1.1 and
> the Classic VM. The method controlled whether threads w
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote:
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10924
- Fix tests that try to run `TestDowncall` which was split into
TestDowncallScope and TestDowncallStack
- Fix use of obsolete system properties to control specilization
- Add test to run TestVarArgs in un-sampled mode.
Testing: Manual runs of TestMatrix.java (it's a manual test) on Windows and
L
Refactor the cast binding to an enum, which clearly enumerates all supported
conversions.
This also fixes a bug where `java/foreign/normalize/TestNormalize` was failing
when running in interpreted mode
(`-Djdk.internal.foreign.DowncallLinker.USE_SPEC=false`), for conversions from
`int` to `byt
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed by
Please review the change to update to using jtreg `7.1`.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the requiredVersion has been updated in the various `TEST.ROOT` files.
This pull requ
On Mon, 28 Nov 2022 22:56:27 GMT, Roger Riggs wrote:
> The accessFlags() methods added (in JDK 20, the current release) to
> java.lang.Class, java.lang.reflect.Executable, and java.lang.reflect.Field
> assume the access flags are from the current/most recent class file format
> version. For cu
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersi
Two (since 19) usages of Unsafe.getAndAddInt to update a static field provide
the Class object as the base instead of the base object returned by
Unsafe.staticFieldBase. This doesn't change anything on the HotSpot VM.
-
Commit messages:
- Initial commit
Changes: https://git.openjd
This test allocates on the native side with `malloc`, and then tries to free
that memory on the Java side. The library that we look up on the Java side is
either ucrtbase.dll, or msvcrt.dll as a fallback if we don't find it. The fact
that we're seeing this crash likely means that the test machin
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed by
On Fri, 25 Nov 2022 14:53:57 GMT, Alan Bateman wrote:
> Two (since 19) usages of Unsafe.getAndAddInt to update a static field provide
> the Class object as the base instead of the base object returned by
> Unsafe.staticFieldBase. This doesn't change anything on the HotSpot VM.
LGTM
--
On Fri, 25 Nov 2022 14:53:57 GMT, Alan Bateman wrote:
> Two (since 19) usages of Unsafe.getAndAddInt to update a static field provide
> the Class object as the base instead of the base object returned by
> Unsafe.staticFieldBase. This doesn't change anything on the HotSpot VM.
LGTM, thank you!
On Tue, 29 Nov 2022 16:26:54 GMT, Bernhard Urban-Forster
wrote:
>> Two (since 19) usages of Unsafe.getAndAddInt to update a static field
>> provide the Class object as the base instead of the base object returned by
>> Unsafe.staticFieldBase. This doesn't change anything on the HotSpot VM.
>
>
On Fri, 25 Nov 2022 18:54:28 GMT, Alan Bateman wrote:
> Another small step in the multi-release/multi-year effort to remove cruft
> from Thread/ThreadGroup.
>
> java.lang.ThreadGroup.allowThreadSuspension(boolean) dates from JDK 1.1 and
> the Classic VM. The method controlled whether threads w
On Wed, 23 Nov 2022 21:36:24 GMT, Kim Barrett wrote:
>> I think the problem here is the friend declaration, which doesn't look like
>> it's needed and could be deleted.
>
> Digging into this some more, the friend declaration exists to provide access
> to the private `os::win32::enum Ept`.
>
>
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote:
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
looks good
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10924
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersi
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed by
> `java.io.InputStream::transferTo` could conceivably return a negative value
> if the count of bytes transferred overflows a `long`. Modify the method to
> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
Brian Burkhalter has updated the pull request incrementally with
On Tue, 29 Nov 2022 00:56:58 GMT, Brian Burkhalter wrote:
> `java.io.InputStream::transferTo` could conceivably return a negative value
> if the count of bytes transferred overflows a `long`. Modify the method to
> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
Modif
On Mon, 28 Nov 2022 17:53:43 GMT, Justin Lu wrote:
> Problem: Javadoc in Locale.lookup is incorrect. Javadoc should match the
> parameter arguments. See lines 3562-3563.
>
> Fix: For `@throws NullPointerException` replace `if priorityList or tags is
> null` with `if priorityList or locales is
On Tue, 29 Nov 2022 18:26:03 GMT, Brian Burkhalter wrote:
>> `java.io.InputStream::transferTo` could conceivably return a negative value
>> if the count of bytes transferred overflows a `long`. Modify the method to
>> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
>
>
On Tue, 29 Nov 2022 18:35:40 GMT, Alan Bateman wrote:
> I assume Reader.transferTo will need similar treatment.
Looks like it. I will re-scan for other places as well.
-
PR: https://git.openjdk.org/jdk/pull/11403
On Tue, 29 Nov 2022 18:26:03 GMT, Brian Burkhalter wrote:
>> `java.io.InputStream::transferTo` could conceivably return a negative value
>> if the count of bytes transferred overflows a `long`. Modify the method to
>> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
>
>
On Tue, 29 Nov 2022 18:47:35 GMT, Alan Bateman wrote:
> I assume this will require adjustments to SequenceInputStream.transferTo
> proposed in pull/11248.
I will scan for all overrides.
-
PR: https://git.openjdk.org/jdk/pull/11403
On Tue, 29 Nov 2022 18:52:23 GMT, Brian Burkhalter wrote:
> > I assume this will require adjustments to SequenceInputStream.transferTo
> > proposed in pull/11248.
>
> I will scan for all overrides.
Correction: yes, that one has the same problem.
-
PR: https://git.openjdk.org/jdk/
On Tue, 29 Nov 2022 15:40:53 GMT, Jorn Vernee wrote:
> This test allocates on the native side with `malloc`, and then tries to free
> that memory on the Java side. The library that we look up on the Java side is
> either ucrtbase.dll, or msvcrt.dll as a fallback if we don't find it. The
> fact
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
> `java.io.InputStream::transferTo` could conceivably return a negative value
> if the count of bytes transferred overflows a `long`. Modify the method to
> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
Brian Burkhalter has updated the pull request incrementally with
On Sun, 20 Nov 2022 09:41:47 GMT, Markus KARG wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption. U
[JDK-8271820](https://bugs.openjdk.org/browse/JDK-8271820) introduced the
`@Stable private Boolean callerSensitive;` cache in `Method`. That field is
essentially a tri-state `Boolean` that relies on its `null` value to serve as
"not initialized" value for `@Stable`.
This works well when the hol
On Tue, 29 Nov 2022 07:39:59 GMT, Andrey Turbanov wrote:
> IDEA now highlights unnecessary `rem.offset=1` assignments, which are above
> modified code. Now we always overwrite it with `0` anyway.
>
> https://github.com/openjdk/jdk/blob/6f06f440bcf8a5db379b80e8765af38a15449356/src/java.base/shar
> Remove redundant code reported in
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Remove whitespace.
-
Changes:
- all: https://git.openjdk.
Hi -
I need to repeat again. Please avoid using www.ietf.org as the URL base
for referencing RFCs. The appropriate location is www.rfc-editor.org
and is going to be more stable in the long run than any reference to an
RFC that runs through the IETF's website. These two websites have
differ
On Tue, 29 Nov 2022 19:39:49 GMT, Brian Burkhalter wrote:
> Please take note of the changes proposed in #11403.
It might make sense to merge *this* PR as-is *first*, but then add the needed
fix to #11403 afterwards? Otherwise it might be confusing for a reader, why
#11403 is not covering SIS w
On Mon, 28 Nov 2022 20:13:35 GMT, Jorn Vernee wrote:
> Refactor the cast binding to an enum, which clearly enumerates all supported
> conversions.
>
> This also fixes a bug where `java/foreign/normalize/TestNormalize` was
> failing when running in interpreted mode
> (`-Djdk.internal.foreign.D
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567):
> "MethodTooLargeException thrown while creating a jlink image".
>
> Java still has a 64kb limit: A method may not be longer than 64kb. The idea
> of the fix is to split up the generated methods in several smaller methods
Oli
On Mon, 28 Nov 2022 21:03:33 GMT, Jorn Vernee wrote:
> - Fix tests that try to run `TestDowncall` which was split into
> TestDowncallScope and TestDowncallStack
> - Fix use of obsolete system properties to control specilization
> - Add test to run TestVarArgs in un-sampled mode.
>
> Testing: Ma
On Tue, 29 Nov 2022 19:39:02 GMT, Aleksey Shipilev wrote:
> [JDK-8271820](https://bugs.openjdk.org/browse/JDK-8271820) introduced the
> `@Stable private Boolean callerSensitive;` cache in `Method`. That field is
> essentially a tri-state `Boolean` that relies on its `null` value to serve as
>
On Tue, 29 Nov 2022 15:33:44 GMT, Roger Riggs wrote:
> Yes, the location information via
> `AccessFlags.locations(ClassFileFormatVersion)` provides the needed
> information. And the tests verify that information. My objective was to make
> the AccessFlags returned for a class reflect the class
On Tue, 29 Nov 2022 21:57:09 GMT, Claes Redestad wrote:
> `java.lang.invoke.LambdaForm.NamedFunction` has an `invoker` field acting as
> a cache, but this field is only used for lambda form interpretation, thus not
> very performance sensitive.
>
> Since the invoker is already cached in the m
On Tue, 29 Nov 2022 19:39:02 GMT, Aleksey Shipilev wrote:
> [JDK-8271820](https://bugs.openjdk.org/browse/JDK-8271820) introduced the
> `@Stable private Boolean callerSensitive;` cache in `Method`. That field is
> essentially a tri-state `Boolean` that relies on its `null` value to serve as
>
On Sun, 20 Nov 2022 09:41:47 GMT, Markus KARG wrote:
>> Since JDK 18 some implementations of InputStream.transferTo, namely
>> FileInputStream and ChannelInputStream, offload work to lower layers using
>> NIO channels. This provides shorter execution time and reduced resource
>> consumption. U
On Mon, 28 Nov 2022 10:02:47 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes the typos in the test
>> packages? @mernst submitted this as a separate PR
>> https://github.com/openjdk/jdk/pull/10029 but given the number of areas and
>> files that other PR touches
On Mon, 28 Nov 2022 08:58:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes the typos in the test
> packages? @mernst submitted this as a separate PR
> https://github.com/openjdk/jdk/pull/10029 but given the number of areas and
> files that other PR touches, th
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
> sequence and immediately terminates the VM. Thus, "threads' current methods
> do not complete normally or abruptly; no finally clause of any me
On Fri, 25 Nov 2022 14:53:57 GMT, Alan Bateman wrote:
> Two (since 19) usages of Unsafe.getAndAddInt to update a static field provide
> the Class object as the base instead of the base object returned by
> Unsafe.staticFieldBase. This doesn't change anything on the HotSpot VM.
The introduction
On Mon, 28 Nov 2022 19:29:08 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Tue, 4 Oct 2022 17:36:56 GMT, Chris Hennick wrote:
>> This PR improves both the performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra
On Tue, 29 Nov 2022 17:07:02 GMT, Julian Waters wrote:
>> Digging into this some more, the friend declaration exists to provide access
>> to the private `os::win32::enum Ept`.
>>
>> One obvious and cheap solution to that would be to make that enum public. I
>> think that would be an improveme
On Wed, 23 Nov 2022 04:58:38 GMT, Kim Barrett wrote:
>> Out of curiosity, is there a way to get the discussion on approving the use
>> of alignas back up? I've read through 8250269 briefly and unlike the issues
>> that come with C++ attributes, alignas looks relatively straightforward to
>> sw
On Tue, 29 Nov 2022 19:39:02 GMT, Aleksey Shipilev wrote:
> [JDK-8271820](https://bugs.openjdk.org/browse/JDK-8271820) introduced the
> `@Stable private Boolean callerSensitive;` cache in `Method`. That field is
> essentially a tri-state `Boolean` that relies on its `null` value to serve as
>
60 matches
Mail list logo
