> This patch removes many unused variables and one unused label reported by the
> compilers when relevant warnings are enabled.
>
> The unused code was found by compiling after removing `unused` from the list
> of disabled warnings for
> [gcc](https://github.com/openjdk/jdk/blob/master/make/au
> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
Maurizio Cimadamore has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains ten commits:
- Merge branch 'master' into memory_session_cleanup
- Fix ambiguity between sessi
On Thu, 30 Jun 2022 16:41:36 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor javad
On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
OpenJDK supports "Japanese EBCDIC - Katakana" and "Korean EBCDIC" SBCS and DBCS
Only charsets.
|Charset|Mix|SBCS|DBCS|
| -- | -- | -- | -- |
| Japanese EBCDIC - Katakana | Cp930 | Cp290 | Cp300 |
| Korean | Cp933 | Cp833 | Cp834 |
But OpenJDK does not supports some of "Japanese EBCDIC - English"
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed missing BufferedInputStream
Please keep this PR open; I will continune work on it s
On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore
wrote:
>> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert implicit vs. heap session ch
On Tue, 5 Jul 2022 22:22:46 GMT, Joe Darcy wrote:
> Update existing examples in java.lang.invoke.{MethodHandle, MethodHandles}
> to use snippets rather than the older markup idiom.
This pull request has now been integrated.
Changeset: a40c17b7
Author:Joe Darcy
URL:
https://git.ope
On Mon, 4 Jul 2022 13:01:34 GMT, Jorn Vernee wrote:
> This PR updates the spec and implementation to throw an
> `IllegalArgumentException` when an attempt is made to convert a Java string
> containing null characters to a C string.
>
> Testing: local run of the `jdk_foreign` test suite.
I've
On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore
wrote:
>> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert implicit vs. heap session ch
On Wed, 6 Jul 2022 17:05:51 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert implicit vs. heap session changes
>
> src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.j
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev
wrote:
> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG
> or PKG otherwise it invalidates signature.
> - .package should be created when app image is generated, so th
On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
On Wed, 6 Jul 2022 00:32:00 GMT, Stuart Marks wrote:
> Simple javadoc fix of an editorial nature.
Thanks for doing this, Stuart. Not only does this PR remove duplication from
the `Map` documentation, but it also ensures that when JDK-6509045 is
integrated, that duplication won't spread to `Con
On Tue, 28 Jun 2022 10:09:36 GMT, Raffaello Giulietti wrote:
> `BigDecimal.morePoint[Left|Right]()` should return the target `this` when the
> argument is 0 _and_ the scale is non-negative.
This pull request has now been integrated.
Changeset: 35387d5c
Author:Raffaello Giulietti
Committer
On Tue, 5 Jul 2022 21:27:16 GMT, Attila Szegedi wrote:
>> Can there be some JMH tests to confirm the performance?
>> The value domain of the keys is pretty limited (7 * 7) max; and I'm not sure
>> that the combination of creating a new record and the hashcode and equals
>> methods would be fast
On Wed, 6 Jul 2022 23:03:42 GMT, Stuart Marks wrote:
>> Simple javadoc fix of an editorial nature.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflow and adjust whitespace per Alan's & Iris' comments.
Reflowed and adju
On Wed, 6 Jul 2022 13:01:02 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: 2a6ec88c
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/2a6ec88cd09adec43df3da1b22653271517b14a8
Stats: 888 lines i
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association property
>> file to allow o
On Tue, 5 Jul 2022 18:43:26 GMT, Ryan Ernst wrote:
>> This is a followup to simplify Shutdown.exit after the removal of
>> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement
>> on the approach has been reached in this PR, a CSR will be filed to
>> propose the spec change to
> This is tracked in JBS as
>
> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741)
>
>> **Remove unused imports from DTDBuilder.java**
>
> Some imports are no more used.
>
> - java.io.FileNotFoundException;
> - java.io.BufferedInputStream;
> - java.io.OutputStream;
> - java.util.BitSet;
On Wed, 6 Jul 2022 14:05:39 GMT, Ichiroh Takiguchi
wrote:
> OpenJDK supports "Japanese EBCDIC - Katakana" and "Korean EBCDIC" SBCS and
> DBCS Only charsets.
> |Charset|Mix|SBCS|DBCS|
> | -- | -- | -- | -- |
> | Japanese EBCDIC - Katakana | Cp930 | Cp290 | Cp300 |
> | Korean | Cp933 | Cp833 | Cp
On Tue, 5 Jul 2022 18:38:57 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR cleans up `VersionProps::print` removing the unused parameter `newln`.
>
> Mach5 tiers1-3 are currently running.
>
> Best,
> Lance
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.org/
On Tue, 5 Jul 2022 04:21:55 GMT, xpbob wrote:
> Container configuration information is useful for troubleshooting
> problems,Exposing information in MBeans is ideal for monitoring, jConsole,
> and other scenarios.
> Results the following
> ![图片](https://user-images.githubusercontent.com/7837910
On Mon, 4 Jul 2022 12:19:27 GMT, David Holmes wrote:
>> Ryan Ernst has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> better clarify multiple threads behavior
>
>> Let's say we've run shutdown so run all the hooks but not halted. Then
>> s
On Tue, 5 Jul 2022 17:27:34 GMT, Jorn Vernee wrote:
>> This patch changes all VaList implementations to throw
>> `NoSuchElementException` when out of bounds reads occur on a VaList that is
>> created using the Java builder API. The docs are updated accordingly.
>>
>> For VaLists that are creat
On Mon, 4 Jul 2022 12:09:46 GMT, David Holmes wrote:
>>> Is "deadlock" accurate?
>>
>> Yes.
>>
>> In the context of the specification, "shutdown hook" means _application_
>> shutdown hook - as far as the specification is concerned, application
>> shutdown hooks are the only kind of hooks. Rig
On Tue, 5 Jul 2022 04:51:50 GMT, Ryan Ernst wrote:
>> YAO (Yet Another Opinion)! But I think we're actually converging.
>>
>> David's wording:
>>>Invocations of this method are serialized such that only one invocation will
>>>actually proceed with the shutdown sequence and terminate the VM wit
On Wed, 6 Jul 2022 03:52:30 GMT, xpbob wrote:
>> Container configuration information is useful for troubleshooting
>> problems,Exposing information in MBeans is ideal for monitoring, jConsole,
>> and other scenarios.
>> Results the following
>>  directly while the attempted shutdown
is in p
On Wed, 6 Jul 2022 00:32:00 GMT, Stuart Marks wrote:
> Simple javadoc fix of an editorial nature.
Marked as reviewed by iris (Reviewer).
src/java.base/share/classes/java/util/Map.java line 740:
> 738: * @param function the function to apply to each entry
> 739: * @throws UnsupportedO
On Wed, 29 Jun 2022 12:29:33 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association property
>> file to allow
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association property
>> file to allow o
On Wed, 1 Jun 2022 16:45:35 GMT, liach wrote:
>> XenoAmess has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> do it as naotoj said
>
> 'the new' fix should be applied to newHashMap etc. too.
@liach
> 'the new' fix should be applied to ne
> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit since the last revision:
Turn non-closeable view back into MemorySession impl
-
Changes:
- all: https://git.openjdk.or
Tests Bug8146568 and Bug8148174 were disabled for high memory consumption, over
17G. This is a task to re-enable these two tests by marking them as manual
tests.
-
Commit messages:
- Marked Bug8146568 and Bug8148174 as manual tests.
Changes: https://git.openjdk.org/jdk/pull/9404/f
On Thu, 30 Jun 2022 18:50:23 GMT, Alexey Semenyuk wrote:
>> Alex Kasko has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> drop pass-all-args property
>
> test/jdk/tools/jpackage/share/FileAssociationsTest.java line 108:
>
>> 106:
On Wed, 6 Jul 2022 18:01:28 GMT, Maurizio Cimadamore
wrote:
>> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
>
> Maurizio Cimadamore has updated the pull request with a new target base due
> to a merge or a rebase. The pull request now contains ten commits:
>
> - Merge b
On Thu, 7 Jul 2022 06:06:42 GMT, Stuart Marks wrote:
> Minor doc wording changes, to be consistent with HashSet.newHashSet et. al.
LGTM
-
Marked as reviewed by chegar (Reviewer).
PR: https://git.openjdk.org/jdk19/pull/118
On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
On Wed, 6 Jul 2022 00:08:04 GMT, liach wrote:
>> Update existing examples in java.lang.invoke.{MethodHandle, MethodHandles}
>> to use snippets rather than the older markup idiom.
>
> src/java.base/share/classes/java/lang/invoke/MethodHandle.java line 272:
>
>> 270: * Here are some examples of
On Wed, 6 Jul 2022 11:09:33 GMT, Jorn Vernee wrote:
>> This PR updates the spec and implementation to throw an
>> `IllegalArgumentException` when an attempt is made to convert a Java string
>> containing null characters to a C string.
>>
>> Testing: local run of the `jdk_foreign` test suite.
>
On Wed, 6 Jul 2022 23:03:42 GMT, Stuart Marks wrote:
>> Simple javadoc fix of an editorial nature.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflow and adjust whitespace per Alan's & Iris' comments.
Marked as reviewe
On Wed, 6 Jul 2022 16:18:08 GMT, Ichiroh Takiguchi
wrote:
> Discussions are available on :
> [JDK-8289834](https://bugs.openjdk.org/browse/JDK-8289834): Add SBCS and DBCS
> Only EBCDIC charsets
Yes, I think this need discussion on whether the JDK really needs to keep
including and adding more
On Tue, 5 Jul 2022 22:22:46 GMT, Joe Darcy wrote:
> Update existing examples in java.lang.invoke.{MethodHandle, MethodHandles}
> to use snippets rather than the older markup idiom.
The code examples in these files were exdented to make it easier to extract
example code and test it, and to mai
On Wed, 6 Jul 2022 17:07:37 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert implicit vs. heap session changes
>
> src/java.base/share/classes/jdk/internal/foreign/abi/aarch64/macos/Ma
On Wed, 29 Jun 2022 21:32:29 GMT, Joe Darcy wrote:
>> JDK-8289106: Add model of class file versions to core reflection
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/
On Wed, 6 Jul 2022 23:03:42 GMT, Stuart Marks wrote:
>> Simple javadoc fix of an editorial nature.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflow and adjust whitespace per Alan's & Iris' comments.
Marked as reviewe
On Thu, 30 Jun 2022 16:41:36 GMT, iaroslavski wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor javad
> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG
> or PKG otherwise it invalidates signature.
> - .package should be created when app image is generated, so this file can be
> signed.
> - Copying predefine app image for
On Mon, 27 Dec 2021 13:43:12 GMT, Markus KARG wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed missing BufferedInputStream
src/java.base/share/classes/java/io/BufferedInputStream
On Wed, 6 Jul 2022 20:49:25 GMT, John R Rose wrote:
> The code examples in these files were exdented to make it easier to extract
> example code and test it, and to maintain equivalence during active
> development of the APIs.
>
> The examples in runnable form are in
> test/jdk/java/lang/invo
I removed a section of via JDK_JAVA_OPTIONS because including main class is not
allowed in the specification.
This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
variable. At this time, this test is mismatch with the specification.
I tried to test and get Passed on Japanese
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association property
>> file to allow o
On Wed, 6 Jul 2022 00:32:00 GMT, Stuart Marks wrote:
> Simple javadoc fix of an editorial nature.
src/java.base/share/classes/java/util/Map.java line 745:
> 743: * ( href="{@docRoot}/java.base/java/util/Collection.html#optional-restrictions">optional)
> 744: * @throws NullPoin
We can skip bounds check and null check for Charset in case we use the array
entirely and the Charset is either default one or proven to be non-null.
Benchmark results:
before
Benchmark Mode Cnt Score
Error Units
StringConstructor.newString
Minor doc wording changes, to be consistent with HashSet.newHashSet et. al.
-
Commit messages:
- 8289872: wrong wording in @param doc for HashMap.newHashMap et. al.
Changes: https://git.openjdk.org/jdk19/pull/118/files
Webrev: https://webrevs.openjdk.org/?repo=jdk19&pr=118&range=00
> Simple javadoc fix of an editorial nature.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Reflow and adjust whitespace per Alan's & Iris' comments.
-
Changes:
- all: https://git.openjdk.org/jdk19/pull/111/files
-
On Mon, 27 Jun 2022 16:44:17 GMT, Jorn Vernee wrote:
> https://github.com/openjdk/jdk/pull/8817 added a button to copy a link to a
> section of javadoc to the clipboard. For the copy button to appear, the
> header needs to have an `id`.
>
> This cleanup PR canonicalizes all header ids in the j
On Fri, 1 Jul 2022 11:03:23 GMT, Maurizio Cimadamore
wrote:
> This patch fixes few javadoc issues in the memory layout API.
> The main issues are that `SequenceLayout::flatten` and
> `SequenceLayout::reshape` still mention failures caused by a lack of size.
> But that condition is no longer po
On Thu, 7 Jul 2022 10:21:06 GMT, Сергей Цыпанов wrote:
> We can skip bounds check and null check for Charset in case we use the array
> entirely and the Charset is either default one or proven to be non-null.
>
> Benchmark results:
>
> before
>
> Benchmark
On Fri, 1 Jul 2022 17:04:10 GMT, Joe Wang wrote:
> To improve efficiency, this patch moves the limit check to within the Lexer
> and reports any overlimit situation as soon as it happens.
>
> Note the change in XPathParser: diff (and also webrevs) showed the whole
> error-report block was chan
On Tue, 21 Jun 2022 09:30:30 GMT, Alex Kasko wrote:
> jpackage implementation of file association on Windows currently passes a
> selected filename as an only argument to associated executable.
>
> It is proposed to introduce additional option in file association property
> file to allow optio
On Thu, 7 Jul 2022 17:32:45 GMT, Joe Wang wrote:
>> To improve efficiency, this patch moves the limit check to within the Lexer
>> and reports any overlimit situation as soon as it happens.
>>
>> Note the change in XPathParser: diff (and also webrevs) showed the whole
>> error-report block was
64 matches
Mail list logo
