Re: jspawnhelper's sometimes problematic use of argv0

2023-06-18 Thread Thomas Stüfe
Thank you Daniel. Comment's fixed. Cheers, Thomas On Sun, Jun 18, 2023 at 2:25 AM Daniel Jarabek wrote: > Hi Thomas, > > Thank you for this quick fix! > > I have tested (after much difficultly getting cross compilation to work - > a good learning experience) and this fix works for me. Using QEM

Re: jspawnhelper's sometimes problematic use of argv0

2023-06-17 Thread Daniel Jarabek
Hi Thomas, Thank you for this quick fix! I have tested (after much difficultly getting cross compilation to work - a good learning experience) and this fix works for me. Using QEMU_STRACE, I verified that argv[0] is now the program name and argv[1] contains the fd data. While you are correc

Re: jspawnhelper's sometimes problematic use of argv0

2023-06-17 Thread Thomas Stüfe
Mind testing https://github.com/openjdk/jdk/pull/14531 ? On Sat, Jun 17, 2023 at 8:20 PM Thomas Stüfe wrote: > Hi Daniel, > > thank you for that thorough analysis. I opened > https://bugs.openjdk.org/browse/JDK-8310265 to track this issue. > > Looking at the code, this should be easy to fix, we

Re: jspawnhelper's sometimes problematic use of argv0

2023-06-17 Thread Thomas Stüfe
Hi Daniel, thank you for that thorough analysis. I opened https://bugs.openjdk.org/browse/JDK-8310265 to track this issue. Looking at the code, this should be easy to fix, we would not even have to fix jspawnhelper itself, just its spawn point. I did a small patch which seemed to work. But this

jspawnhelper's sometimes problematic use of argv0

2023-06-16 Thread Daniel Jarabek
Hi, While trying to run jshell in qemu-user-static using binfmt_misc (specifically, using this docker based tool [1]), I ran into an issue. Jshell would fail to start and print `This command is not for general use and should only be run as the result of a call to ProcessBuilder.start() or Run