Re: RFR: JDK-8321545: Override toString() for Format subclasses [v2]

2024-01-12 Thread Justin Lu
On Thu, 11 Jan 2024 19:42:42 GMT, Naoto Sato wrote: > I think test cases for these new overridden `toString()` methods would be > helpful. Added test cases for the new methods. Additionally, in the most recent commit, I swapped the placement of `compact patterns` with `decimal pattern`. As `c

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v2]

2024-01-11 Thread Naoto Sato
On Thu, 11 Jan 2024 19:30:09 GMT, Justin Lu wrote: >> Please review this PR which implements toString() for the `Format` >> subclasses. Corresponding CSR: >> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) >> >> The general specification follows a template that provides the locale (

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v2]

2024-01-11 Thread Justin Lu
> Please review this PR which implements toString() for the `Format` > subclasses. Corresponding CSR: > [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) > > The general specification follows a template that provides the locale (if the > class is localized) and any relevant patterns. T