Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

2023-07-06 Thread Roger Riggs
On Thu, 6 Jul 2023 13:27:15 GMT, Roger Riggs wrote: >> `WeakReferenceKey::equals` and `SoftReferenceKey::equals`: >> >> Instead of `return Objects.equals(get(), obj);`, suggest to do: >> >> >> return refersTo(obj); > >> @mlchung Not sure I catch the nuance. `refersTo` doesn't work if the s

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

2023-07-06 Thread Mandy Chung
On Thu, 6 Jul 2023 13:27:15 GMT, Roger Riggs wrote: >> `WeakReferenceKey::equals` and `SoftReferenceKey::equals`: >> >> Instead of `return Objects.equals(get(), obj);`, suggest to do: >> >> >> return refersTo(obj); > >> @mlchung Not sure I catch the nuance. `refersTo` doesn't work if the s

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

2023-07-06 Thread Roger Riggs
On Wed, 5 Jul 2023 19:33:28 GMT, Mandy Chung wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to use VirtualThread friendly stale queue. > > `WeakReferenceKey::equals` and `SoftReferenceKey::equals`: > > Inste

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

2023-07-06 Thread Jim Laskey
On Wed, 5 Jul 2023 19:33:28 GMT, Mandy Chung wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to use VirtualThread friendly stale queue. > > `WeakReferenceKey::equals` and `SoftReferenceKey::equals`: > > Inste

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

2023-07-05 Thread Mandy Chung
On Tue, 4 Jul 2023 12:55:22 GMT, Jim Laskey wrote: >> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent >> caching scheme for Carrier objects. The technique used is generally useful >> for a variety of caching schemes and is being moved to be shared in other >> parts of

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

2023-07-05 Thread Roger Riggs
On Tue, 4 Jul 2023 12:55:22 GMT, Jim Laskey wrote: >> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent >> caching scheme for Carrier objects. The technique used is generally useful >> for a variety of caching schemes and is being moved to be shared in other >> parts of

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

2023-07-04 Thread Jim Laskey
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent > caching scheme for Carrier objects. The technique used is generally useful > for a variety of caching schemes and is being moved to be shared in other > parts of the jdk. The MethodType interning case is one example.

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v3]

2023-07-04 Thread Jim Laskey
On Fri, 30 Jun 2023 17:29:20 GMT, Mandy Chung wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to use VirtualThread friendly stale queue. > > src/java.base/share/classes/java/lang/invoke/MethodType.java line 89