Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v4]

2023-07-13 Thread Alan Bateman
On Fri, 14 Jul 2023 03:45:47 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a code review for moving the contents of the jdk.crypto.ec module >> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into >> java.base. EC has always been separate from the base module/pkg becau

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v4]

2023-07-13 Thread Anthony Scarpino
> Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of > its dependence on a native library. That library was rem

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v3]

2023-07-03 Thread Valerie Peng
On Mon, 3 Jul 2023 17:51:10 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a code review for moving the contents of the jdk.crypto.ec module >> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into >> java.base. EC has always been separate from the base module/pkg because

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v3]

2023-07-03 Thread Anthony Scarpino
> Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of > its dependence on a native library. That library was rem

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v2]

2023-06-29 Thread Anthony Scarpino
On Thu, 29 Jun 2023 18:36:55 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update for review: changed test, removed commented out code in module, >> fixed switch statement, added --limit-m

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v2]

2023-06-29 Thread Valerie Peng
On Mon, 26 Jun 2023 22:52:18 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a code review for moving the contents of the jdk.crypto.ec module >> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into >> java.base. EC has always been separate from the base module/pkg becau

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v2]

2023-06-26 Thread Anthony Scarpino
> Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of > its dependence on a native library. That library was rem

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-20 Thread Anthony Scarpino
On Tue, 20 Jun 2023 10:55:12 GMT, Alan Bateman wrote: > I think we've converged on the right motivation. If would be good to check if > there are TLS tests that could run with --limit-modules java.base, that would > give confidence that the API/implementation will work when the run-time image

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-20 Thread Alan Bateman
On Tue, 20 Jun 2023 00:57:46 GMT, Sean Mullan wrote: > > Maybe you are thinking about the size of libsunec or non-technical issues > > that meant it wasn't included by some distributions? There weren't an issue > > with deciding which providers to include to java.base. I think the > > motivati

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-20 Thread Alan Bateman
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: > Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-19 Thread Anthony Scarpino
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: > Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-18 Thread Alan Bateman
On Mon, 19 Jun 2023 05:46:34 GMT, Anthony Scarpino wrote: > From what I was told, the native library was one of the reasons it was not in > the base pkg before modularization and just remained so afterwards. Maybe you are thinking about the size of libsunec or non-technical issues that meant

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-18 Thread Anthony Scarpino
On Sat, 17 Jun 2023 13:10:35 GMT, Alan Bateman wrote: > > This moves the SunEC JCE Provider (Elliptic Curve) into java.base. EC has > > always been separate from the base module/pkg because of its dependence on > > a native library. That library was removed in JDK 16. > > The proposed changes

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-18 Thread Anthony Scarpino
On Sat, 17 Jun 2023 12:53:17 GMT, Alan Bateman wrote: >> src/jdk.crypto.ec/share/classes/module-info.java line 36: >> >>> 34: @Deprecated(since="22", forRemoval = true) >>> 35: module jdk.crypto.ec { >>> 36: //provides java.security.Provider with sun.security.ec.SunEC; >> >> Just remove it.

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-17 Thread Alan Bateman
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: > This moves the SunEC JCE Provider (Elliptic Curve) into java.base. EC has > always been separate from the base module/pkg because of its dependence on a > native library. That library was removed in JDK 16. The proposed changes look

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-17 Thread Alan Bateman
On Fri, 16 Jun 2023 20:32:23 GMT, Weijun Wang wrote: >> Hi, >> >> I need a code review for moving the contents of the jdk.crypto.ec module >> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into >> java.base. EC has always been separate from the base module/pkg because of

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-16 Thread Weijun Wang
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: > Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of