Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v5]

2023-02-28 Thread Andrey Turbanov
On Mon, 27 Feb 2023 18:26:51 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v5]

2023-02-27 Thread Tobias Hartmann
On Mon, 27 Feb 2023 18:26:51 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v5]

2023-02-27 Thread Joe Darcy
On Mon, 27 Feb 2023 18:26:51 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v5]

2023-02-27 Thread Joe Darcy
> The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. Joe Darcy has updated the pull request with a new target bas

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Joe Darcy
On Sat, 25 Feb 2023 18:06:46 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add one one unsigned shift comment. > > src/java.base/share/classes/java/lang/FdLibm.java line 639: > >> 637:

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v4]

2023-02-25 Thread Joe Darcy
> The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. Joe Darcy has updated the pull request incrementally with on

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Joe Darcy
On Thu, 23 Feb 2023 23:30:46 GMT, Joe Darcy wrote: > I'll revert commenting out the intrinsic annotation before pushing. Turns out some VM updates are needed to preserve the intrinsic if this method declaration is changed; I'll be contacting the HotSpot team for assistance. - PR:

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Andrey Turbanov
On Fri, 24 Feb 2023 18:40:38 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-24 Thread Brian Burkhalter
On Fri, 24 Feb 2023 18:40:38 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-24 Thread Joe Darcy
> The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. Joe Darcy has updated the pull request incrementally with on

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v2]

2023-02-24 Thread Joe Darcy
On Fri, 24 Feb 2023 13:31:10 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > test/jdk/java/lang/StrictMath/ExhaustingTests.java line 71: > >> 69:

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v2]

2023-02-24 Thread Joe Darcy
On Fri, 24 Feb 2023 13:19:36 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/lang/FdLibm.java line 689: >> >>> 687: ix0 += (m << 20); >>> 688: z = __HI(z, ix0); >>> 689: z = __LO(z, ix1); >> >> I was tempted to rewrite these line as somet

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v2]

2023-02-24 Thread Joe Darcy
> The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. Joe Darcy has updated the pull request incrementally with on

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java

2023-02-24 Thread Raffaello Giulietti
On Thu, 23 Feb 2023 23:39:26 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java

2023-02-24 Thread Raffaello Giulietti
On Thu, 23 Feb 2023 23:28:11 GMT, Joe Darcy wrote: > The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. Otherwi

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java

2023-02-23 Thread Joe Darcy
On Thu, 23 Feb 2023 23:28:11 GMT, Joe Darcy wrote: > The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. src/jav

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java

2023-02-23 Thread Joe Darcy
On Thu, 23 Feb 2023 23:28:11 GMT, Joe Darcy wrote: > The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. src/jav

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java

2023-02-23 Thread Joe Darcy
On Thu, 23 Feb 2023 23:28:11 GMT, Joe Darcy wrote: > The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. In loca

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java

2023-02-23 Thread Joe Darcy
On Thu, 23 Feb 2023 23:28:11 GMT, Joe Darcy wrote: > The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. src/jav