On Wed, 15 Feb 2023 22:44:40 GMT, Joe Darcy wrote:
>> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
>> refactor the regression tests a bit to reduce duplication, but the actual
>> ports should be ready for review.
>>
>> Diff'ing the ports as before, original vs translit
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
On Wed, 8 Feb 2023 18:39:42 GMT, Magnus Ihse Bursie wrote:
>> Hmm. Wouldn't hurt to do so.
>>
>> I was thinking of making a pass over Fdlibm.java at some point to make sure
>> the nested classes had package-level rather than public accessibility and
>> that the classes had private constructors
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
On Wed, 8 Feb 2023 18:35:51 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/FdLibm.java line 1215:
>>
>>> 1213: * only sinh(0)=0 is exact for finite x.
>>> 1214: */
>>> 1215: static class Sinh {
>>
>> For clarity, should this not be declared `final`?
>
> Hmm. W
On Tue, 7 Feb 2023 16:02:19 GMT, Magnus Ihse Bursie wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct overflow limit in regression test.
>
> src/java.base/share/classes/java/lang/FdLibm.java line 1215:
>
>> 121
On Mon, 6 Feb 2023 22:08:06 GMT, Joe Darcy wrote:
>> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
>> refactor the regression tests a bit to reduce duplication, but the actual
>> ports should be ready for review.
>>
>> Diff'ing the ports as before, original vs translite
On Mon, 6 Feb 2023 22:03:17 GMT, Joe Darcy wrote:
>> Yes, it gave me pause when doing the transliteration.
>>
>> Unpacking the code a bit,
>>
>>
>> /* |x| in [log(maxdouble), overflowthresold] */
>> // lx = *( (((*(unsigned*)&one)>>29)) + (unsigned*)&x);
>>
On Mon, 6 Feb 2023 11:37:41 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct overflow limit in regression test.
>
> test/jdk/java/lang/StrictMath/FdlibmTranslit.java line 938:
>
>> 93
On Mon, 6 Feb 2023 21:55:26 GMT, Joe Darcy wrote:
>> test/jdk/java/lang/StrictMath/FdlibmTranslit.java line 874:
>>
>>> 872: // lx = *( (((*(unsigned*)&one)>>29)) + (unsigned*)&x);
>>> 873: // lx = (((*(unsigned*)&one)>>29)) + (unsigned*)&x ;
>>> 874: lx = __
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
On Mon, 6 Feb 2023 11:34:40 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Two more spacing fixes.
>> - Implement spacing improvements from code review comments.
>
> test/jdk/java/lang/St
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c Hyperbolic.tr
On Mon, 6 Feb 2023 08:33:37 GMT, Andrey Turbanov wrote:
>> Joe Darcy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Two more spacing fixes.
>> - Implement spacing improvements from code review comments.
>
> src/java.base/share/classe
On Sun, 5 Feb 2023 03:05:55 GMT, Joe Darcy wrote:
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteratio
On Sun, 5 Feb 2023 03:05:55 GMT, Joe Darcy wrote:
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteratio
On Sun, 5 Feb 2023 03:05:55 GMT, Joe Darcy wrote:
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteratio
23 matches
Mail list logo
