Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph [v2]

2025-07-22 Thread Ioi Lam
On Tue, 22 Jul 2025 16:59:07 GMT, Coleen Phillimore wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into 8360555-archive-all-unnamed-modules >> - 8360555: Archive all

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph [v2]

2025-07-22 Thread Coleen Phillimore
On Tue, 22 Jul 2025 16:27:18 GMT, Ioi Lam wrote: >> The CDS full module graph is supposed to contain a snapshot of the boot >> layer, which has 3 unnamed modules for the boot, platform and system class >> loaders. Each unnamed module is represented by a `java.lang.Module` Java >> object and a

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph [v2]

2025-07-22 Thread Ioi Lam
> The CDS full module graph is supposed to contain a snapshot of the boot > layer, which has 3 unnamed modules for the boot, platform and system class > loaders. Each unnamed module is represented by a `java.lang.Module` Java > object and a `ModuleEntry` C++ object. > > Currently, we archive on

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph

2025-07-21 Thread Vladimir Ivanov
On Wed, 2 Jul 2025 00:18:28 GMT, Ioi Lam wrote: > The CDS full module graph is supposed to contain a snapshot of the boot > layer, which has 3 unnamed modules for the boot, platform and system class > loaders. Each unnamed module is represented by a `java.lang.Module` Java > object and a `Modu

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph

2025-07-21 Thread Ioi Lam
On Mon, 21 Jul 2025 17:51:34 GMT, Coleen Phillimore wrote: >> The callstack is: >> >> >> jdk.internal.loader.BootLoader.setBootLoaderUnnamedModule0(java.base@26-internal/Native >> Method) >> jdk.internal.loader.BootLoader.(java.base@26-internal/BootLoader.java:71) >> jdk.internal.module.Module

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph

2025-07-21 Thread Coleen Phillimore
On Thu, 17 Jul 2025 22:41:34 GMT, Ioi Lam wrote: >> If you're storing the unnamed module oop in the archive should this method >> not be called? If it is, what are you saving by archiving the unnamed >> module? > > The callstack is: > > > jdk.internal.loader.BootLoader.setBootLoaderUnnamedMo

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph

2025-07-21 Thread Coleen Phillimore
On Wed, 2 Jul 2025 00:18:28 GMT, Ioi Lam wrote: > The CDS full module graph is supposed to contain a snapshot of the boot > layer, which has 3 unnamed modules for the boot, platform and system class > loaders. Each unnamed module is represented by a `java.lang.Module` Java > object and a `Modu

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph

2025-07-17 Thread Ioi Lam
On Thu, 17 Jul 2025 12:35:54 GMT, Coleen Phillimore wrote: >> src/hotspot/share/classfile/modules.cpp line 777: >> >>> 775: if (CDSConfig::is_using_full_module_graph()) { >>> 776: precond(unnamed_module == >>> ClassLoaderDataShared::archived_boot_unnamed_module()); >>> 777: unnamed_mo

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph

2025-07-17 Thread Coleen Phillimore
On Thu, 17 Jul 2025 12:29:39 GMT, Coleen Phillimore wrote: >> The CDS full module graph is supposed to contain a snapshot of the boot >> layer, which has 3 unnamed modules for the boot, platform and system class >> loaders. Each unnamed module is represented by a `java.lang.Module` Java >> obj

Re: RFR: 8360555: Archive all unnamed modules in CDS full module graph

2025-07-17 Thread Coleen Phillimore
On Wed, 2 Jul 2025 00:18:28 GMT, Ioi Lam wrote: > The CDS full module graph is supposed to contain a snapshot of the boot > layer, which has 3 unnamed modules for the boot, platform and system class > loaders. Each unnamed module is represented by a `java.lang.Module` Java > object and a `Modu