On Fri, 23 May 2025 02:03:48 GMT, Shaojin Wen wrote:
>> In HexDigits, getCharsLatin1 and getCharsUTF16 are no longer used, so remove
>> these methods
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
>
> In HexDigits, getCharsLatin1 and getCharsUTF16 are no longer used, so remove
> these methods
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge remote-tracking branch 'upstream/master' into hexdigits_
On Thu, 15 May 2025 22:03:22 GMT, Shaojin Wen wrote:
> In HexDigits, getCharsLatin1 and getCharsUTF16 are no longer used, so remove
> these methods
The getCharsLatin1/getCharsUTF16 methods of HexDigits may be used in
j.u.Formatter/HexFormat in the future. For this reason, should we keep them?
On Thu, 15 May 2025 22:03:22 GMT, Shaojin Wen wrote:
> In HexDigits, getCharsLatin1 and getCharsUTF16 are no longer used, so remove
> these methods
It does indeed look like these are unused. The change looks OK to me but please
wait for one more review from someone more familiar with this code
