Re: RFR: 8355720: Implement JEP 506: Scoped Values

2025-04-29 Thread Chen Liang
On Mon, 28 Apr 2025 14:32:04 GMT, Andrew Haley wrote: > Propose to finalize scoped values. > The only functional change is that the orElse() method no longer accepts a > null argument. Nit: is the no-arg constructor of `Snapshot` supposed to be `private` instead? - PR Comment: htt

Re: RFR: 8355720: Implement JEP 506: Scoped Values

2025-04-29 Thread Chen Liang
On Mon, 28 Apr 2025 17:15:34 GMT, ExE Boss wrote: >> Propose to finalize scoped values. >> The only functional change is that the orElse() method no longer accepts a >> null argument. > > src/java.base/share/classes/java/lang/ScopedValue.java line 614: > >> 612: */ >> 613: public T orE

Re: RFR: 8355720: Implement JEP 506: Scoped Values

2025-04-29 Thread ExE Boss
On Mon, 28 Apr 2025 14:32:04 GMT, Andrew Haley wrote: > Propose to finalize scoped values. > The only functional change is that the orElse() method no longer accepts a > null argument. src/java.base/share/classes/java/lang/ScopedValue.java line 614: > 612: */ > 613: public T orElse(T

Re: RFR: 8355720: Implement JEP 506: Scoped Values

2025-04-29 Thread Alan Bateman
On Mon, 28 Apr 2025 14:32:04 GMT, Andrew Haley wrote: > Propose to finalize scoped values. > The only functional change is that the orElse() method no longer accepts a > null argument. @theRealAph There are test updates in the loom repo that will also need to be included in this PR. -