On Tue, 22 Apr 2025 16:51:05 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Add Reader.readAllLines; test not yet updated
>
> src/java.base/share/classes/java/io/Reader.java line 403
On Tue, 22 Apr 2025 16:53:30 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Reader.java line 426:
>>
>>> 424: */
>>> 425: public List readAllLines() throws IOException {
>>> 426: return readAllChars().lines();
>>
>> I assume you are missing toList() here.
>
On Tue, 22 Apr 2025 16:48:43 GMT, Alan Bateman wrote:
> I assume you are missing toList() here.
Yes, that was stupid. The `make jdk` caught it but I somehow missed the error
message.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2054494622
On Tue, 22 Apr 2025 16:32:09 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Add Reader.readAllLines; test not yet updated
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add Reader.readAllLines; test not yet updated
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24
