Re: RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

2025-04-05 Thread Alan Bateman
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote: >> Those system property values on Windows were derived from Windows' >> `GetConsoleCP()` call, but they should have been taken from >> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one >> won't change any behavior, as

Re: RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

2025-03-28 Thread Naoto Sato
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote: >> Those system property values on Windows were derived from Windows' >> `GetConsoleCP()` call, but they should have been taken from >> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one >> won't change any behavior, as

Re: RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

2025-03-27 Thread Brian Burkhalter
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote: >> Those system property values on Windows were derived from Windows' >> `GetConsoleCP()` call, but they should have been taken from >> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one >> won't change any behavior, as

Re: RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

2025-03-27 Thread Naoto Sato
On Thu, 27 Mar 2025 16:11:47 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Handled the error case > > src/java.base/windows/native/libjava/java_props_md.c line 131: > >> 129: } >> 130: >> 131: s

Re: RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

2025-03-27 Thread Alan Bateman
On Thu, 27 Mar 2025 16:03:08 GMT, Naoto Sato wrote: >> Those system property values on Windows were derived from Windows' >> `GetConsoleCP()` call, but they should have been taken from >> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one >> won't change any behavior, as

Re: RFR: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call [v3]

2025-03-27 Thread Naoto Sato
> Those system property values on Windows were derived from Windows' > `GetConsoleCP()` call, but they should have been taken from > `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one > won't change any behavior, as both calls return the same value by default > (`GetOEMCP