On Thu, 10 Apr 2025 06:00:48 GMT, Per Minborg wrote:
>> This PR proposes to add `@ForceInline` to the `default` methods in
>> `SegmentAllocator` that do not already have it.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
On Fri, 14 Feb 2025 09:19:35 GMT, Per Minborg wrote:
> This PR proposes to add `@ForceInline` to the `default` methods in
> `SegmentAllocator` that do not already have it.
Base:
Benchmark Mode Cnt Score Error Units
AllocFromInlineTest.alloc00 thrpt
On Thu, 10 Apr 2025 06:00:48 GMT, Per Minborg wrote:
>> This PR proposes to add `@ForceInline` to the `default` methods in
>> `SegmentAllocator` that do not already have it.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev
> This PR proposes to add `@ForceInline` to the `default` methods in
> `SegmentAllocator` that do not already have it.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase
On Fri, 14 Feb 2025 09:19:35 GMT, Per Minborg wrote:
> This PR proposes to add `@ForceInline` to the `default` methods in
> `SegmentAllocator` that do not already have it.
Keep it open.
-
PR Comment: https://git.openjdk.org/jdk/pull/23628#issuecomment-2790078845
On Fri, 14 Feb 2025 09:19:35 GMT, Per Minborg wrote:
> This PR proposes to add `@ForceInline` to the `default` methods in
> `SegmentAllocator` that do not already have it.
There is [a microbenchmark from another
PR](test/micro/org/openjdk/bench/java/lang/foreign/ArenaPoolFromBench.java)
which
On Fri, 14 Feb 2025 09:19:35 GMT, Per Minborg wrote:
> This PR proposes to add `@ForceInline` to the `default` methods in
> `SegmentAllocator` that do not already have it.
Change is good. There should be a microbenchmark for this.
-
PR Review: https://git.openjdk.org/jdk/pull/2362
