Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v3]

2025-03-03 Thread Naoto Sato
On Mon, 3 Mar 2025 19:24:38 GMT, Joe Wang wrote: >> Fix handleCharacters by adding a guard to zero length and letting the rest >> of the process continue (e.g. closing tags and etc). > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v2]

2025-03-03 Thread Joe Wang
On Mon, 3 Mar 2025 18:01:48 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove commented section > > test/jaxp/javax/xml/jaxp/unittest/validation/ValidationTest.java line 151: > >> 149: * >> 1

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v3]

2025-03-03 Thread Joe Wang
> Fix handleCharacters by adding a guard to zero length and letting the rest of > the process continue (e.g. closing tags and etc). Joe Wang has updated the pull request incrementally with one additional commit since the last revision: improve the javadoc for the test - Changes:

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v2]

2025-03-03 Thread Naoto Sato
On Sat, 1 Mar 2025 01:19:17 GMT, Joe Wang wrote: >> Fix handleCharacters by adding a guard to zero length and letting the rest >> of the process continue (e.g. closing tags and etc). > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA

2025-03-01 Thread Joe Wang
On Fri, 28 Feb 2025 22:33:14 GMT, Naoto Sato wrote: >> Fix handleCharacters by adding a guard to zero length and letting the rest >> of the process continue (e.g. closing tags and etc). > > src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXStream2SAX.java > line 286: >

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v2]

2025-02-28 Thread Joe Wang
On Fri, 28 Feb 2025 23:02:28 GMT, Naoto Sato wrote: >> Hi Naoto, >> >> Yes, I did look through that code and bug 5046319. Unfortunately, it >> happened when JAXP was standalone, the history of the change was lost. >> The variable "buf" seems to be an instance variable that serves to cache the

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v2]

2025-02-28 Thread Joe Wang
> Fix handleCharacters by adding a guard to zero length and letting the rest of > the process continue (e.g. closing tags and etc). Joe Wang has updated the pull request incrementally with one additional commit since the last revision: remove commented section - Changes: - all

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA

2025-02-28 Thread Naoto Sato
On Fri, 28 Feb 2025 22:56:27 GMT, Joe Wang wrote: >> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXStream2SAX.java >> line 286: >> >>> 284: if (textLength > 0) { >>> 285: staxStreamReader.getTextCharacters(0, chars, 0, >>> textLength); >>> 286:

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA

2025-02-28 Thread Naoto Sato
On Fri, 28 Feb 2025 17:42:24 GMT, Joe Wang wrote: > Fix handleCharacters by adding a guard to zero length and letting the rest of > the process continue (e.g. closing tags and etc). src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXStream2SAX.java line 286: > 284: