Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v7]

2025-04-14 Thread Per Minborg
On Tue, 8 Apr 2025 12:24:41 GMT, Per Minborg wrote: >> This PR proposes to add some `@ForceInline` annotations in the `Module` >> class in order to assist inlining of FFM var/method handles. >> >> There are also some changes in other classes which, if implemented, can take >> us three addition

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v6]

2025-04-10 Thread Per Minborg
On Tue, 8 Apr 2025 11:33:54 GMT, Per Minborg wrote: >> This PR proposes to add some `@ForceInline` annotations in the `Module` >> class in order to assist inlining of FFM var/method handles. >> >> There are also some changes in other classes which, if implemented, can take >> us three addition

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v6]

2025-04-10 Thread Per Minborg
> This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > There are also some changes in other classes (notably `j.l.Object`) which, if > implemented, can take us four additional levels of inlining. However, there

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v7]

2025-04-10 Thread Maurizio Cimadamore
On Tue, 8 Apr 2025 12:24:41 GMT, Per Minborg wrote: >> This PR proposes to add some `@ForceInline` annotations in the `Module` >> class in order to assist inlining of FFM var/method handles. >> >> There are also some changes in other classes which, if implemented, can take >> us three addition

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v6]

2025-04-10 Thread Maurizio Cimadamore
On Thu, 10 Apr 2025 15:52:38 GMT, Maurizio Cimadamore wrote: > > Baseline: > > ``` > > Benchmark(offsetCount) (segmentSize) Mode > > CntScore Error Units > > FFMVarHandleInlineTest.t0_reference 2048 1024 thrpt > > 25 155261

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v6]

2025-04-10 Thread Maurizio Cimadamore
On Tue, 8 Apr 2025 12:13:25 GMT, Per Minborg wrote: > Baseline: > > ``` > Benchmark(offsetCount) (segmentSize) Mode Cnt >Score Error Units > FFMVarHandleInlineTest.t0_reference 2048 1024 thrpt 25 > 1552613.262 ? 14295.035

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v7]

2025-04-08 Thread Per Minborg
> This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > There are also some changes in other classes which, if implemented, can take > us three additional levels of inlining. I drew a line there. There is a > t

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v6]

2025-04-08 Thread Per Minborg
On Tue, 8 Apr 2025 11:33:54 GMT, Per Minborg wrote: >> This PR proposes to add some `@ForceInline` annotations in the `Module` >> class in order to assist inlining of FFM var/method handles. >> >> There are also some changes in other classes which, if implemented, can take >> us three addition

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v5]

2025-02-06 Thread Per Minborg
> This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > There are also some changes in other classes (notably `j.l.Object`) which, if > implemented, can take us four additional levels of inlining. However, there

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v5]

2025-02-06 Thread Per Minborg
On Thu, 6 Feb 2025 15:35:14 GMT, Per Minborg wrote: >> This PR proposes to add some `@ForceInline` annotations in the `Module` >> class in order to assist inlining of FFM var/method handles. >> >> There are also some changes in other classes (notably `j.l.Object`) which, >> if implemented, can

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v4]

2025-02-06 Thread Per Minborg
On Wed, 5 Feb 2025 14:43:52 GMT, Per Minborg wrote: >> This PR proposes to add some `@ForceInline` annotations in the `Module` >> class in order to assist inlining of FFM var/method handles. >> >> There are also some changes in other classes (notably `j.l.Object`) which, >> if implemented, can

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v4]

2025-02-05 Thread Per Minborg
> This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > Tested and passed tier1-3 Per Minborg has updated the pull request incrementally with two additional commits since the last revision: - Remove reformatt

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v2]

2025-02-05 Thread Per Minborg
> This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > Tested and passed tier1-3 Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Rename method and

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v3]

2025-02-05 Thread Per Minborg
> This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > Tested and passed tier1-3 Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Revert change ---

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret

2025-02-05 Thread Alan Bateman
On Wed, 5 Feb 2025 10:20:11 GMT, Per Minborg wrote: >> This PR proposes to add some `@ForceInline` annotations in the `Module` >> class in order to assist inlining of FFM var/method handles. >> >> Tested and passed tier1-3 > > src/java.base/share/classes/java/lang/Module.java line 488: > >> 48

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret

2025-02-05 Thread Alan Bateman
On Wed, 5 Feb 2025 10:17:09 GMT, Per Minborg wrote: > This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > Tested and passed tier1-3 src/java.base/share/classes/java/lang/Module.java line 344: > 342: } >

Re: RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret

2025-02-05 Thread Per Minborg
On Wed, 5 Feb 2025 10:17:09 GMT, Per Minborg wrote: > This PR proposes to add some `@ForceInline` annotations in the `Module` class > in order to assist inlining of FFM var/method handles. > > Tested and passed tier1-3 src/java.base/share/classes/java/lang/Module.java line 281: > 279: