Re: RFR: 8346986: Remove ASM from java.base [v7]

2025-01-13 Thread Magnus Ihse Bursie
On Mon, 13 Jan 2025 07:52:08 GMT, Adam Sotona wrote: > Is there a way to pre-compile a test library and point related tests (or > maybe all hotspot tests) to the library jar? My initial thought was just to add the jar to the classpath, but maybe it is better to use an explicit `@library` tag.

Re: RFR: 8346986: Remove ASM from java.base [v7]

2025-01-13 Thread Adam Sotona
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam

Re: RFR: 8346986: Remove ASM from java.base [v7]

2025-01-13 Thread Alan Bateman
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam

Re: RFR: 8346986: Remove ASM from java.base [v7]

2025-01-12 Thread Adam Sotona
On Mon, 13 Jan 2025 07:40:06 GMT, Adam Sotona wrote: >> There are no more consumers of ASM library except for hotspot tests. >> This patch moves ASM library from java.base module to the hotspot test >> libraries location and fixes the tests. >> >> Please review. >> >> Thanks, >> Adam > > Adam

Re: RFR: 8346986: Remove ASM from java.base [v7]

2025-01-12 Thread Adam Sotona
> There are no more consumers of ASM library except for hotspot tests. > This patch moves ASM library from java.base module to the hotspot test > libraries location and fixes the tests. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additio