Re: RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

2025-01-09 Thread Joakim Nordström
On Thu, 9 Jan 2025 01:25:09 GMT, David Holmes wrote: >> Joakim Nordström has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Merge >> - Copyright year. Doc updated. Comments revised. >> - Merge > > Okay looks good! Thanks > > I'll dru

Re: RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

2025-01-09 Thread duke
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström wrote: >> Could I get a review of this fix to refine the warnings printed by `libjsig` >> when using the deprecated `signal()`/`sigset()` functions? >> >> Currently the libjsig library supports chaining `signal()` and `sigset()`. >> With these

Re: RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

2025-01-09 Thread Kevin Walls
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström wrote: >> Could I get a review of this fix to refine the warnings printed by `libjsig` >> when using the deprecated `signal()`/`sigset()` functions? >> >> Currently the libjsig library supports chaining `signal()` and `sigset()`. >> With these

Re: RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

2025-01-09 Thread Kevin Walls
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström wrote: >> Could I get a review of this fix to refine the warnings printed by `libjsig` >> when using the deprecated `signal()`/`sigset()` functions? >> >> Currently the libjsig library supports chaining `signal()` and `sigset()`. >> With these

Re: RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

2025-01-08 Thread David Holmes
On Wed, 8 Jan 2025 11:03:06 GMT, Joakim Nordström wrote: >> Could I get a review of this fix to refine the warnings printed by `libjsig` >> when using the deprecated `signal()`/`sigset()` functions? >> >> Currently the libjsig library supports chaining `signal()` and `sigset()`. >> With these

Re: RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

2025-01-08 Thread David Holmes
On Wed, 8 Jan 2025 11:00:14 GMT, Joakim Nordström wrote: >> The test is skipped for SIGUSR2 on Linux and MacOS, and Windows skips all >> signal testing. So I guess that leaves aix, which seems to use >> signals_poxis.cpp... so perhaps the SIGUSR2 test should be skipped for aix >> too? >> But

Re: RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

2025-01-08 Thread Joakim Nordström
> Could I get a review of this fix to refine the warnings printed by `libjsig` > when using the deprecated `signal()`/`sigset()` functions? > > Currently the libjsig library supports chaining `signal()` and `sigset()`. > With these functions being deprecated, `libjsig` warns when a program calls

Re: RFR: 8345782: Refining the cases that libjsig deprecation warning is issued [v2]

2025-01-08 Thread Joakim Nordström
On Tue, 7 Jan 2025 14:26:13 GMT, Joakim Nordström wrote: >> test/hotspot/jtreg/runtime/signal/SigTestDriver.java line 176: >> >>> 174: /** >>> 175: * Return true for all signals used by the JVM. This only covers >>> the >>> 176: * case where the JVM is started normally, and not w