Re: RFR: 8345119: Some java/foreign tests wrongly assume aligned memory

2024-11-27 Thread Quan Anh Mai
On Wed, 27 Nov 2024 18:56:02 GMT, Maurizio Cimadamore wrote: >> Hi, >> >> This patch resolves some issues I found that the tests wrongly assume >> sufficient alignment from the segment returned by `Arena::allocate`. >> >> Please take a look and leave your reviews, thanks a lot. > > Marked as

Re: RFR: 8345119: Some java/foreign tests wrongly assume aligned memory

2024-11-27 Thread Jorn Vernee
On Wed, 27 Nov 2024 16:57:49 GMT, Quan Anh Mai wrote: >> test/jdk/java/foreign/TestByteBuffer.java line 414: >> >>> 412: ByteBuffer bb; >>> 413: try (Arena arena = Arena.ofConfined()) { >>> 414: MemorySegment segment = arena.allocate(bytes, Long.BYTES); >> >> Why doe

Re: RFR: 8345119: Some java/foreign tests wrongly assume aligned memory

2024-11-27 Thread Jorn Vernee
On Wed, 27 Nov 2024 16:12:04 GMT, Quan Anh Mai wrote: > Hi, > > This patch resolves some issues I found that the tests wrongly assume > sufficient alignment from the segment returned by `Arena::allocate`. > > Please take a look and leave your reviews, thanks a lot. Marked as reviewed by jvern

Re: RFR: 8345119: Some java/foreign tests wrongly assume aligned memory

2024-11-27 Thread Maurizio Cimadamore
On Wed, 27 Nov 2024 16:12:04 GMT, Quan Anh Mai wrote: > Hi, > > This patch resolves some issues I found that the tests wrongly assume > sufficient alignment from the segment returned by `Arena::allocate`. > > Please take a look and leave your reviews, thanks a lot. Looks good. Normally, what

Re: RFR: 8345119: Some java/foreign tests wrongly assume aligned memory

2024-11-27 Thread Quan Anh Mai
On Wed, 27 Nov 2024 16:41:39 GMT, Jorn Vernee wrote: >> Hi, >> >> This patch resolves some issues I found that the tests wrongly assume >> sufficient alignment from the segment returned by `Arena::allocate`. >> >> Please take a look and leave your reviews, thanks a lot. > > test/jdk/java/forei

Re: RFR: 8345119: Some java/foreign tests wrongly assume aligned memory

2024-11-27 Thread Jorn Vernee
On Wed, 27 Nov 2024 16:12:04 GMT, Quan Anh Mai wrote: > Hi, > > This patch resolves some issues I found that the tests wrongly assume > sufficient alignment from the segment returned by `Arena::allocate`. > > Please take a look and leave your reviews, thanks a lot. test/jdk/java/foreign/TestB