Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v8]

2025-04-30 Thread Maurizio Cimadamore
On Tue, 29 Apr 2025 12:33:59 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request incrementally with one additional > commit since the last revision: > > Reflect

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Jan Lahoda
On Tue, 29 Apr 2025 10:13:39 GMT, Maurizio Cimadamore wrote: >> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Startup.java line 345: >> >>> 343: boolean hasModuleImports = source == null || >>> 344: >>> Feature.MODULE_IMPORTS.allowedInSource(s

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Jan Lahoda
On Tue, 29 Apr 2025 10:23:26 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - Merge branch 'master' into JDK-8344708 >> - Adjusting ToolProviderTest to the update

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v8]

2025-04-29 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: Reflecting review feedback. - Changes: - all: https://gi

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Maurizio Cimadamore
On Mon, 28 Apr 2025 13:26:30 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Maurizio Cimadamore
On Mon, 28 Apr 2025 13:26:30 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-29 Thread Maurizio Cimadamore
On Tue, 29 Apr 2025 10:12:07 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 13 commits: >> >> - Merge branch 'master' into JDK-8344708 >> - Adjusting ToolProviderTest to the update

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-28 Thread Vicente Romero
On Mon, 28 Apr 2025 13:26:30 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v7]

2025-04-28 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge branch 'master' into JDK-8344708 - Ad

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v6]

2025-04-11 Thread Vicente Romero
On Fri, 11 Apr 2025 11:20:30 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev exclud

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v6]

2025-04-11 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v5]

2025-04-10 Thread Alan Bateman
On Thu, 10 Apr 2025 18:04:54 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request incrementally with one additional > commit since the last revision: > > Reflect

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v4]

2025-04-10 Thread Jan Lahoda
On Wed, 9 Apr 2025 17:52:26 GMT, Alan Bateman wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflecting review feedback - avoiding hardcoded constants. > > src/java.base/share/classes/jdk/internal/module/ModuleInfo.

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v5]

2025-04-10 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: Reflecting review feedback: cleanup formatting in ModuleInfo. -

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v4]

2025-04-09 Thread Alan Bateman
On Wed, 2 Apr 2025 16:59:16 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request incrementally with one additional > commit since the last revision: > > Reflecti

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v2]

2025-04-05 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request incrementally with four additional commits since the last revision: - Cleanup, fixing tests. - Adjusting JShell defaults. - Fixing tests.

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v4]

2025-04-05 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: Reflecting review feedback - avoiding hardcoded constants.

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v4]

2025-04-02 Thread Vicente Romero
On Wed, 2 Apr 2025 16:59:16 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request incrementally with one additional > commit since the last revision: > > Reflecti

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v3]

2025-04-02 Thread Jan Lahoda
On Wed, 2 Apr 2025 15:23:54 GMT, Vicente Romero wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing test. > > src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Startup.java line 340: > >> 338: */ >> 339:

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v3]

2025-04-02 Thread Vicente Romero
On Mon, 31 Mar 2025 17:40:25 GMT, Jan Lahoda wrote: >> This is a patch to finalize the module imports feature. Please see: >> https://bugs.openjdk.org/browse/JDK-8344700 > > Jan Lahoda has updated the pull request incrementally with one additional > commit since the last revision: > > Fixing

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations [v3]

2025-03-31 Thread Jan Lahoda
> This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: Fixing test. - Changes: - all: https://git.openjdk.org/j

Re: RFR: 8344708: Compiler Implementation of Module Import Declarations

2025-03-04 Thread Vicente Romero
On Wed, 26 Feb 2025 13:50:52 GMT, Jan Lahoda wrote: > This is a patch to finalize the module imports feature. Please see: > https://bugs.openjdk.org/browse/JDK-8344700 looks sensible test/langtools/tools/javac/modules/EdgeCases.java line 1190: > 1188: > 1189: List expected = List.of(