On Sun, 29 Jun 2025 20:43:56 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Fri, 4 Jul 2025 03:02:07 GMT, Roger Riggs wrote:
>> Kim Barrett has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add @Override for clean() method
>> - more commentary for reserveMemory
>
> Marked as reviewed by rriggs (Reviewer).
T
On Sun, 29 Jun 2025 20:43:56 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Sun, 29 Jun 2025 20:43:56 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Sun, 29 Jun 2025 20:43:56 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Sun, 29 Jun 2025 20:34:44 GMT, Kim Barrett wrote:
>> I would be in favor of renaming to avoid ambiguity. There is already
>> `java.lang.ref.Cleaner` and `jdk.internal.ref.Cleaner`, and now this
>> `Cleaner` is really the same thing as `java.lang.ref.Cleaner.Cleanable`.
>> It could be done as
On Sun, 29 Jun 2025 20:23:53 GMT, Kim Barrett wrote:
>> src/java.base/share/classes/java/nio/BufferCleaner.java line 243:
>>
>>> 241: return;
>>> 242: }
>>> 243: cleaningThread = new CleaningThread();
>>
>> I think double-checked locking could work well h
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
> use java.lang.ref.Cleaner.
>
> This change is algorithmica
On Fri, 27 Jun 2025 17:43:34 GMT, Brent Christian wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
On Fri, 27 Jun 2025 19:29:18 GMT, Brent Christian wrote:
>> I intentionally (re)used the "Cleaner" name to avoid a bunch of renames that
>> would increase the size of the change and distract from the meat of it. I
>> think the name to use might be affected by how the implementation of the set
>>
On Fri, 27 Jun 2025 21:06:03 GMT, Brent Christian wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
On Fri, 27 Jun 2025 20:57:01 GMT, Brent Christian wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
On Fri, 27 Jun 2025 20:21:07 GMT, Brent Christian wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
On Fri, 27 Jun 2025 18:24:46 GMT, Brent Christian wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits
On Mon, 19 May 2025 20:34:35 GMT, Kim Barrett wrote:
>> src/java.base/share/classes/sun/nio/Cleaner.java line 31:
>>
>>> 29: * {@code Cleaner} represents an object and a cleaning action.
>>> 30: */
>>> 31: public interface Cleaner {
>>
>> Can this be renamed NIOCleaner or NIOBufClenaer or som
On Fri, 27 Jun 2025 01:03:30 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Fri, 27 Jun 2025 01:03:30 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Fri, 27 Jun 2025 01:03:30 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
> use java.lang.ref.Cleaner.
>
> This change is algorithmica
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
> use java.lang.ref.Cleaner.
>
> This change is algorithmica
On Wed, 21 May 2025 05:42:34 GMT, Kim Barrett wrote:
>> Kim Barrett has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - add description of BufferCleaner class
>> - exception handling in cleaner for backward consistency
>> - detabify
>
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
> use java.lang.ref.Cleaner.
>
> This change is algorithmica
On Wed, 21 May 2025 02:36:16 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Mon, 19 May 2025 19:16:14 GMT, Roger Riggs wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/java/nio/BufferCleaner.java line 33:
>
>> 31: i
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
> use java.lang.ref.Cleaner.
>
> This change is algorithmica
On Tue, 20 May 2025 09:32:08 GMT, Kim Barrett wrote:
>> src/java.base/share/classes/java/nio/Bits.java line 170:
>>
>>> 168: // without it that test likely fails. Since failure here
>>> 169: // ends in OOME, there's no need to hurry.
>>> 170: for (int sleeps
On Mon, 19 May 2025 19:08:31 GMT, Roger Riggs wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/java/nio/Bits.java line 170:
>
>> 168:
On Mon, 19 May 2025 19:24:57 GMT, Roger Riggs wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 88:
On Mon, 19 May 2025 19:27:27 GMT, Roger Riggs wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/sun/nio/Cleaner.java line 31:
>
>> 29: * {@cod
On Mon, 19 May 2025 18:30:45 GMT, ExE Boss wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/java/nio/Bits.java line 145:
>
>> 143:
On Mon, 19 May 2025 19:37:58 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 209:
>>
>>> 207: super(-1, 0, cap, cap, fd, isSync, segment);
>>> 208: address = addr;
>>> 209:cleaner = (unmapper == null) ? null :
>>> Buffer
On Mon, 19 May 2025 18:40:56 GMT, ExE Boss wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 209:
>
On Sun, 18 May 2025 20:55:48 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Sun, 18 May 2025 20:50:41 GMT, Kim Barrett wrote:
>> src/java.base/share/classes/jdk/internal/nio/Cleaner.java line 26:
>>
>>> 24: */
>>> 25:
>>> 26: package jdk.internal.nio;
>>
>> The implementation/internal classes for this area are in sun.nio (for
>> historical reasons). Probably best
On Sun, 18 May 2025 20:55:48 GMT, Kim Barrett wrote:
>> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
>> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
>> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
>>
On Sun, 18 May 2025 12:11:21 GMT, Alan Bateman wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move jdk.internal.nio.Cleaner to sun.nio
>
> src/java.base/share/classes/jdk/internal/nio/Cleaner.java line 26:
>
>> 24
On Sun, 18 May 2025 11:35:55 GMT, Kim Barrett wrote:
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
> use
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
> use java.lang.ref.Cleaner.
>
> This change is algorithmica
On Sun, 18 May 2025 11:35:55 GMT, Kim Barrett wrote:
> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage
> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences
> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to
> use
39 matches
Mail list logo
