On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 18:12:31 GMT, Raffaello Giulietti
wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant suppression
>
> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line
On Fri, 15 Nov 2024 20:56:37 GMT, Sean Mullan wrote:
>> I would prefer if we could deal with getSavedProperty as a wider area follow
>> up, since that would creep out of scope for this particular PR.
>>
>> Ok with you, @liach ?
>>
>> Perhaps @seanjmullan has input on how to deal with VM.getSav
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 20:34:31 GMT, Eirik Bjørsnøs wrote:
>> Either way is fine. I think we probably need to review the majority of uses
>> of VM.savedPropoerty as they mostly relate to SM boot circularity. So we
>> will change this one either now or later.
>
> I would prefer if we could deal w
On Fri, 15 Nov 2024 17:09:11 GMT, Chen Liang wrote:
>> The use of the properties in ClassFileDumper is all in support of debug
>> capabilities and is not sensitive.
>
> Either way is fine. I think we probably need to review the majority of uses
> of VM.savedPropoerty as they mostly relate to S
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 16:31:54 GMT, Roger Riggs wrote:
>> VM.save props should only be used if there is a bootstrap issue.
>> If tampering is a concern, then the property should be added to
>> StaticProperties.
>
> The use of the properties in ClassFileDumper is all in support of debug
> capabili
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 16:28:13 GMT, Roger Riggs wrote:
>> VM saved props is still better imo as user code cannot tamper it with
>> System.setProperty.
>
> VM.save props should only be used if there is a bootstrap issue.
> If tampering is a concern, then the property should be added to
> StaticPro
On Fri, 15 Nov 2024 16:23:28 GMT, Chen Liang wrote:
>> @liach Does this mean we can/should use `System.getProperty` here?
>
> VM saved props is still better imo as user code cannot tamper it with
> System.setProperty.
VM.save props should only be used if there is a bootstrap issue.
If tampering
On Fri, 15 Nov 2024 16:15:02 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 82:
>>
>>> 80:
>>> 81: private ClassFileDumper(String key, String path) {
>>> 82: /*
>>
>> The comment might still be relevant if changed to System.getProp
On Fri, 15 Nov 2024 16:21:10 GMT, Eirik Bjørsnøs wrote:
>> It's fine now: previously user defined security manager was effectively
>> loading user code that uses java.lang.invoke, now users cannot specify
>> security managers, so this problem does not exist any more.
>
> @liach Does this mean w
On Fri, 15 Nov 2024 16:15:02 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 82:
>>
>>> 80:
>>> 81: private ClassFileDumper(String key, String path) {
>>> 82: /*
>>
>> The comment might still be relevant if changed to System.getProp
On Fri, 15 Nov 2024 15:58:36 GMT, Roger Riggs wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant suppression
>
> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 82:
>
>> 80:
On Fri, 15 Nov 2024 15:43:08 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
>> `StaticProperty` in the `jdk.internal.util` namespace:
>>
>> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
>> call with `Boolean:
On Fri, 15 Nov 2024 15:01:13 GMT, Chen Liang wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove redundant suppression
>
> src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java line 129:
>
>> 127
> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
> `StaticProperty` in the `jdk.internal.util` namespace:
>
> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
> call with `Boolean::getBoolean`. (Existing code uses
> `String::equalsIgnoreCase`
On Fri, 15 Nov 2024 09:35:17 GMT, Eirik Bjørsnøs wrote:
> Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and
> `StaticProperty` in the `jdk.internal.util` namespace:
>
> * `RandomSupport` is updated to replace an `AccessController::doPrivileged`
> call with `Boolean::getB
20 matches
Mail list logo
