On Sat, 18 Jan 2025 21:48:39 GMT, Chen Liang wrote:
>> The doc of `Unsafe::putChar()` delegates to the doc of `Unsafe::putInt()`
>> which clearly states that the `Object` and `offset` arguments must locate a
>> variable of the same type as the one of argument `x`, which is not the case
>> here
On Fri, 17 Jan 2025 16:05:32 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 434:
>>
>>> 432:
>>> 433: private static void putCharUTF16(byte[] buf, int charPos, int c) {
>>> 434: UNSAFE.putChar(buf, ARRAY_BYTE_BASE_OFFSET + (
On Fri, 17 Jan 2025 15:46:25 GMT, Raffaello Giulietti
wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix comment, from @rgiulietti
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 434:
>
On Fri, 17 Jan 2025 00:09:11 GMT, Shaojin Wen wrote:
>> This PR is a resubmission after PR #21593 was rolled back, and the unsafe
>> offset overflow issue has been fixed.
>>
>> 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to
>> reduce duplication.
>>
>> 2) HexDigi
On Fri, 17 Jan 2025 00:09:11 GMT, Shaojin Wen wrote:
>> This PR is a resubmission after PR #21593 was rolled back, and the unsafe
>> offset overflow issue has been fixed.
>>
>> 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to
>> reduce duplication.
>>
>> 2) HexDigi
> This PR is a resubmission after PR #21593 was rolled back, and the unsafe
> offset overflow issue has been fixed.
>
> 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to
> reduce duplication.
>
> 2) HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF
