Re: RFR: 8343178: Test BasicTest.java javac compile fails cannot find symbol

2024-10-28 Thread SendaoYan
On Tue, 29 Oct 2024 03:03:17 GMT, SendaoYan wrote: > Hi all, > The test `tools/jpackage/share/jdk/jpackage/tests/BasicTest.java` javac > compile fails `cannot find symbol TKit.assertPathNotEmptyDirectory` after > [JDK-8343101](https://bugs.openjdk.org/browse/JDK-8343101). I think we should > u

Re: RFR: 8343178: Test BasicTest.java javac compile fails cannot find symbol

2024-10-28 Thread Jaikiran Pai
On Tue, 29 Oct 2024 03:03:17 GMT, SendaoYan wrote: > Hi all, > The test `tools/jpackage/share/jdk/jpackage/tests/BasicTest.java` javac > compile fails `cannot find symbol TKit.assertPathNotEmptyDirectory` after > [JDK-8343101](https://bugs.openjdk.org/browse/JDK-8343101). I think we should > u

Re: RFR: 8343178: Test BasicTest.java javac compile fails cannot find symbol

2024-10-28 Thread SendaoYan
On Tue, 29 Oct 2024 04:57:13 GMT, Jaikiran Pai wrote: > I think you meant https://bugs.openjdk.org/browse/JDK-8343101. Yes, Sorry for the mistake. The PR description has been updated. - PR Comment: https://git.openjdk.org/jdk/pull/21750#issuecomment-2443273038

Re: RFR: 8343178: Test BasicTest.java javac compile fails cannot find symbol

2024-10-28 Thread Alexey Semenyuk
On Tue, 29 Oct 2024 03:03:17 GMT, SendaoYan wrote: > Hi all, > The test `tools/jpackage/share/jdk/jpackage/tests/BasicTest.java` javac > compile fails `cannot find symbol TKit.assertPathNotEmptyDirectory` after > [JDK-8343101](https://bugs.openjdk.org/browse/JDK-8343101). I think we should > u

Re: RFR: 8343178: Test BasicTest.java javac compile fails cannot find symbol

2024-10-28 Thread Jaikiran Pai
On Tue, 29 Oct 2024 03:03:17 GMT, SendaoYan wrote: > Hi all, > The test `tools/jpackage/share/jdk/jpackage/tests/BasicTest.java` javac > compile fails `cannot find symbol TKit.assertPathNotEmptyDirectory` after > JDK-8343178. I think we should use `TKit.assertDirectoryNotEmpty` instead of > `T