Re: RFR: 8341684: Typo in External Specifications link of java.util.Currency [v2]

2024-10-09 Thread Steven Loomis
On Wed, 9 Oct 2024 00:08:30 GMT, Justin Lu wrote: >> A trivial correction to the _j.util.Currency_ external specification ISO >> currency codes link. Browsers will auto resolve and correct the link, but it >> should still be fixed regardless. > > Justin Lu has updated the pull request incremen

Re: RFR: 8341684: Typo in External Specifications link of java.util.Currency [v2]

2024-10-09 Thread Naoto Sato
On Wed, 9 Oct 2024 00:08:30 GMT, Justin Lu wrote: >> A trivial correction to the _j.util.Currency_ external specification ISO >> currency codes link. Browsers will auto resolve and correct the link, but it >> should still be fixed regardless. > > Justin Lu has updated the pull request incremen

Re: RFR: 8341684: Typo in External Specifications link of java.util.Currency

2024-10-08 Thread Justin Lu
On Tue, 8 Oct 2024 23:48:03 GMT, Chen Liang wrote: > Isn't the right link https://www.iso.org/iso-4217-currency-codes.html while > simply changing the extension (and yes, the link in this PR) leads to a 404 > page? > > Also note that we prefer https links over http if possible. Thanks Chen, y

Re: RFR: 8341684: Typo in External Specifications link of java.util.Currency [v2]

2024-10-08 Thread Chen Liang
On Wed, 9 Oct 2024 00:05:15 GMT, Justin Lu wrote: >> A trivial correction to the _j.util.Currency_ external specification ISO >> currency codes link. Browsers will auto resolve and correct the link, but it >> should still be fixed regardless. > > Justin Lu has updated the pull request incremen

Re: RFR: 8341684: Typo in External Specifications link of java.util.Currency [v2]

2024-10-08 Thread Justin Lu
> A trivial correction to the _j.util.Currency_ external specification ISO > currency codes link. Browsers will auto resolve and correct the link, but it > should still be fixed regardless. Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8341684: Typo in External Specifications link of java.util.Currency

2024-10-08 Thread Chen Liang
On Tue, 8 Oct 2024 23:11:25 GMT, Justin Lu wrote: > A trivial correction to the _j.util.Currency_ external specification ISO > currency codes link. Browsers will auto resolve and correct the link, but it > should still be fixed regardless. Isn't the right link https://www.iso.org/iso-4217-cur