On Mon, 7 Oct 2024 20:00:03 GMT, Lance Andersen wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove trailing whitespace
>> - Use a ZIP64 test vector which may be reproduced using InfoZIP
>
> Marked as revie
On Tue, 8 Oct 2024 07:45:13 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which adds validation of the 'total entries' value
>> when fetched from the 'ZIP64 End of Central Directory' header.
>>
>> We should reject this value under the following conditions:
>>
>> 1. It is too large to fit
On Mon, 7 Oct 2024 20:00:03 GMT, Lance Andersen wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove trailing whitespace
>> - Use a ZIP64 test vector which may be reproduced using InfoZIP
>
> Marked as revie
> Please review this PR which adds validation of the 'total entries' value when
> fetched from the 'ZIP64 End of Central Directory' header.
>
> We should reject this value under the following conditions:
>
> 1. It is too large to fit within the specified CEN size (considering each CEN
> header
On Mon, 7 Oct 2024 19:54:15 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which adds validation of the 'total entries' value
>> when fetched from the 'ZIP64 End of Central Directory' header.
>>
>> We should reject this value under the following conditions:
>>
>> 1. It is too large to fit
On Mon, 7 Oct 2024 18:51:52 GMT, Lance Andersen wrote:
> It might be beneficial to future readers to provide the steps used to create
> the hex string in the format you have provided.
The test vector was crafted using a ZIP test library not available in OpenJDK.
I have replaced that with a tes
> Please review this PR which adds validation of the 'total entries' value when
> fetched from the 'ZIP64 End of Central Directory' header.
>
> We should reject this value under the following conditions:
>
> 1. It is too large to fit within the specified CEN size (considering each CEN
> header
On Mon, 7 Oct 2024 09:13:57 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds validation of the 'total entries' value when
> fetched from the 'ZIP64 End of Central Directory' header.
>
> We should reject this value under the following conditions:
>
> 1. It is too large to fit withi
