Re: RFR: 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils [v3]

2024-10-06 Thread Claes Redestad
On Sun, 6 Oct 2024 15:48:57 GMT, Eirik Bjørsnøs wrote: >> Sure, I think the JIT is pretty good at eliminating the (intrinsic) >> `checkIndex` calls when they are redundant though. Performance with and >> without these `checkIndex`es are the same in my testing, so we can eat and >> have the cak

Re: RFR: 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils [v3]

2024-10-06 Thread Claes Redestad
On Sun, 6 Oct 2024 16:27:52 GMT, Chen Liang wrote: >> test/micro/org/openjdk/bench/java/util/zip/ZipFileOpen.java line 110: >> >>> 108: zf2.close(); >>> 109: } >>> 110: >> >> A short comment stating the purpose of the main method would not hurt. > > https://github.com/openjdk/jdk/p

Re: RFR: 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils [v3]

2024-10-06 Thread Claes Redestad
> #14632 showed that coalescing loads in the `ZipUtils` utility methods could > improve performance in zip-related microbenchmarks, but doing so would > increase startup overheads. Progress was stalled as we backed out some > related early use of `ByteArray(LittleEndian)` and started exploring m