Re: RFR: 8340380: Improve source launcher's shebang script detection [v3]

2025-01-10 Thread Christian Stein
On Fri, 10 Jan 2025 16:06:32 GMT, Jaikiran Pai wrote: > [...] retain the previous order and first check for the suffix and if it's > not .java, only then do a stat system call. I started with that oder (before https://github.com/openjdk/jdk/pull/21910/commits/f0bd01d393a5d88e8b33723b7b4ca16379

Re: RFR: 8340380: Improve source launcher's shebang script detection [v3]

2025-01-10 Thread Jaikiran Pai
On Thu, 9 Jan 2025 09:20:51 GMT, Christian Stein wrote: >> Please review this change that improves the launcher mode detection by >> reading the initial two characters from the started file for being a shebang >> script. It addresses the reported confusing error messages and also supports >> m

Re: RFR: 8340380: Improve source launcher's shebang script detection [v3]

2025-01-10 Thread Athijegannathan Sundararajan
On Thu, 9 Jan 2025 09:20:51 GMT, Christian Stein wrote: >> Please review this change that improves the launcher mode detection by >> reading the initial two characters from the started file for being a shebang >> script. It addresses the reported confusing error messages and also supports >> m

Re: RFR: 8340380: Improve source launcher's shebang script detection [v3]

2025-01-09 Thread Christian Stein
> Please review this change that improves the launcher mode detection by > reading the initial two characters from the started file for being a shebang > script. It addresses the reported confusing error messages and also supports > more shebang line variations. Including those line variations t

Re: RFR: 8340380: Improve source launcher's shebang script detection [v2]

2025-01-09 Thread Christian Stein
> Please review this change that improves the launcher mode detection by > reading the initial two characters from the started file for being a shebang > script. It addresses the reported confusing error messages and also supports > more shebang line variations. Including those line variations t

Re: RFR: 8340380: Improve source launcher's shebang script detection

2025-01-08 Thread Athijegannathan Sundararajan
On Tue, 5 Nov 2024 16:16:13 GMT, Christian Stein wrote: > Please review this change that improves the launcher mode detection by > reading the initial two characters from the started file for being a shebang > script. It addresses the reported confusing error messages and also supports > more