Re: RFR: 8339635: StringConcatFactory optimization for CompactStrings off [v2]

2024-09-06 Thread duke
On Fri, 6 Sep 2024 00:21:07 GMT, Shaojin Wen wrote: >> A small optimization, when CompactStrings is turned off, the coder method is >> not generated, which improves the startup performance > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last rev

Re: RFR: 8339635: StringConcatFactory optimization for CompactStrings off [v2]

2024-09-05 Thread Chen Liang
On Fri, 6 Sep 2024 00:21:07 GMT, Shaojin Wen wrote: >> A small optimization, when CompactStrings is turned off, the coder method is >> not generated, which improves the startup performance > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last rev

Re: RFR: 8339635: StringConcatFactory optimization for CompactStrings off [v2]

2024-09-05 Thread Shaojin Wen
> A small optimization, when CompactStrings is turned off, the coder method is > not generated, which improves the startup performance Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: add java doc - Changes: - all: http

Re: RFR: 8339635: StringConcatFactory optimization for CompactStrings off

2024-09-05 Thread Chen Liang
On Tue, 27 Aug 2024 05:08:53 GMT, Shaojin Wen wrote: > A small optimization, when CompactStrings is turned off, the coder method is > not generated, which improves the startup performance src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 455: > 453: Object stringConc

Re: RFR: 8339635: StringConcatFactory optimization for CompactStrings off

2024-09-05 Thread Chen Liang
On Thu, 5 Sep 2024 23:39:58 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/java/lang/System.java line 2641: >> >>> 2639: } >>> 2640: >>> 2641: public byte stringInitCoder() { >> >> Why do we expose this as a coder instead of other ways, such as a `boolean >> ha

Re: RFR: 8339635: StringConcatFactory optimization for CompactStrings off

2024-09-05 Thread Shaojin Wen
On Thu, 5 Sep 2024 23:20:02 GMT, Chen Liang wrote: >> A small optimization, when CompactStrings is turned off, the coder method is >> not generated, which improves the startup performance > > src/java.base/share/classes/java/lang/System.java line 2641: > >> 2639: } >> 2640: >> 2641

Re: RFR: 8339635: StringConcatFactory optimization for CompactStrings off

2024-09-05 Thread Chen Liang
On Tue, 27 Aug 2024 05:08:53 GMT, Shaojin Wen wrote: > A small optimization, when CompactStrings is turned off, the coder method is > not generated, which improves the startup performance src/java.base/share/classes/java/lang/System.java line 2641: > 2639: } > 2640: > 2641:

Re: RFR: 8339635: StringConcatFactory optimization for CompactStrings off

2024-09-05 Thread ExE Boss
On Tue, 27 Aug 2024 05:08:53 GMT, Shaojin Wen wrote: > A small optimization, when CompactStrings is turned off, the coder method is > not generated, which improves the startup performance The `JLA​.stringInitCoder() != 0` check should probably be the first thing in  this method, so that **C2**