Re: RFR: 8338930: StringConcatFactory hardCoded string concatenation strategy [v2]

2024-08-26 Thread Shaojin Wen
On Sun, 25 Aug 2024 13:10:41 GMT, Claes Redestad wrote: > > If the number of parameters is greater than 2, the probability of reuse may > > not be high. Using hard-coded constants can avoid the use of forceinline. > > I think this entirely depends on the application. Too low a threshold and >

Re: RFR: 8338930: StringConcatFactory hardCoded string concatenation strategy [v2]

2024-08-25 Thread ExE Boss
On Sun, 25 Aug 2024 12:12:42 GMT, Shaojin Wen wrote: >> This is a follow-up to PR #20273, which improves performance when the number >> of parameters exceeds 20. >> >> When the number of parameters is large, the possibility of reuse will be >> lower, so we can use the static concat method and

Re: RFR: 8338930: StringConcatFactory hardCoded string concatenation strategy [v2]

2024-08-25 Thread Claes Redestad
On Sun, 25 Aug 2024 12:54:08 GMT, Shaojin Wen wrote: > If the number of parameters is greater than 2, the probability of reuse may > not be high. Using hard-coded constants can avoid the use of forceinline. I think this entirely depends on the application. Too low a threshold and many applicat

Re: RFR: 8338930: StringConcatFactory hardCoded string concatenation strategy [v2]

2024-08-25 Thread Shaojin Wen
On Sun, 25 Aug 2024 12:12:42 GMT, Shaojin Wen wrote: >> This is a follow-up to PR #20273, which improves performance when the number >> of parameters exceeds 20. >> >> When the number of parameters is large, the possibility of reuse will be >> lower, so we can use the static concat method and

Re: RFR: 8338930: StringConcatFactory hardCoded string concatenation strategy [v2]

2024-08-25 Thread Shaojin Wen
> This is a follow-up to PR #20273, which improves performance when the number > of parameters exceeds 20. > > When the number of parameters is large, the possibility of reuse will be > lower, so we can use the static concat method and write the length and coder > directly into the bytecode to