Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v2]

2024-08-24 Thread Thomas Stuefe
On Fri, 23 Aug 2024 20:46:39 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >>

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v2]

2024-08-23 Thread Coleen Phillimore
On Fri, 23 Aug 2024 06:43:24 GMT, Thomas Stuefe wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Incorporated a set of Thomas Stuefe's comments. Take out AbstractClass >> MetaspaceObj::Type. > > src/hotspot/sh

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v2]

2024-08-23 Thread Coleen Phillimore
On Fri, 23 Aug 2024 20:43:52 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >>

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v2]

2024-08-23 Thread Coleen Phillimore
On Fri, 23 Aug 2024 20:37:55 GMT, Coleen Phillimore wrote: >> src/hotspot/share/oops/klass.hpp line 214: >> >>> 212: virtual bool is_klass() const { return true; } >>> 213: >>> 214: bool is_in_klass_space() const { return !is_interface() && >>> !is_abstract(); } >> >> This name is mislead

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v2]

2024-08-23 Thread Coleen Phillimore
> This change stores InstanceKlass for interface and abstract classes in the > non-class metaspace, since class metaspace will have limits on number of > classes that can be represented when Lilliput changes go in. Classes that > have no instances created for them don't require compressed class